| Message ID | 20190924210106.27117-19-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing/next (docker,tcg, alpha ;-) | expand |
On 9/24/19 2:00 PM, Alex Bennée wrote: > Now we have fixed the signal delivary bug we can remove this horrible > hack from the system. > > Cc: Richard Henderson <richard.henderson@linaro.org> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > --- > v2 > - drop un-needed cflags > --- > tests/tcg/multiarch/Makefile.target | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Hi Alex, On 9/24/19 11:00 PM, Alex Bennée wrote: > Now we have fixed the signal delivary bug we can remove this horrible "delivery" > hack from the system. > > Cc: Richard Henderson <richard.henderson@linaro.org> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Can you reorder this patch after directly "target/ppc: fix signal delivery for ppc64abi32"? > > --- > v2 > - drop un-needed cflags > --- > tests/tcg/multiarch/Makefile.target | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target > index 6b1e30e2fec..657a04f802d 100644 > --- a/tests/tcg/multiarch/Makefile.target > +++ b/tests/tcg/multiarch/Makefile.target > @@ -12,14 +12,6 @@ VPATH += $(MULTIARCH_SRC) > MULTIARCH_SRCS =$(notdir $(wildcard $(MULTIARCH_SRC)/*.c)) > MULTIARCH_TESTS =$(MULTIARCH_SRCS:.c=) > > -# FIXME: ppc64abi32 linux-test seems to have issues but the other basic tests work > -ifeq ($(TARGET_NAME),ppc64abi32) > -BROKEN_TESTS = linux-test > -endif > - > -# Update TESTS > -TESTS += $(filter-out $(BROKEN_TESTS), $(MULTIARCH_TESTS)) > - > # > # The following are any additional rules needed to build things > # > @@ -39,3 +31,6 @@ run-test-mmap: test-mmap > run-test-mmap-%: test-mmap > $(call run-test, test-mmap-$*, $(QEMU) -p $* $<,\ > "$< ($* byte pages) on $(TARGET_NAME)") > + > +# Update TESTS > +TESTS += $(MULTIARCH_TESTS) > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> (via make 'run-tcg-tests-ppc64abi32-linux-user')
diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target index 6b1e30e2fec..657a04f802d 100644 --- a/tests/tcg/multiarch/Makefile.target +++ b/tests/tcg/multiarch/Makefile.target @@ -12,14 +12,6 @@ VPATH += $(MULTIARCH_SRC) MULTIARCH_SRCS =$(notdir $(wildcard $(MULTIARCH_SRC)/*.c)) MULTIARCH_TESTS =$(MULTIARCH_SRCS:.c=) -# FIXME: ppc64abi32 linux-test seems to have issues but the other basic tests work -ifeq ($(TARGET_NAME),ppc64abi32) -BROKEN_TESTS = linux-test -endif - -# Update TESTS -TESTS += $(filter-out $(BROKEN_TESTS), $(MULTIARCH_TESTS)) - # # The following are any additional rules needed to build things # @@ -39,3 +31,6 @@ run-test-mmap: test-mmap run-test-mmap-%: test-mmap $(call run-test, test-mmap-$*, $(QEMU) -p $* $<,\ "$< ($* byte pages) on $(TARGET_NAME)") + +# Update TESTS +TESTS += $(MULTIARCH_TESTS)
Now we have fixed the signal delivary bug we can remove this horrible hack from the system. Cc: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- v2 - drop un-needed cflags --- tests/tcg/multiarch/Makefile.target | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) -- 2.20.1