diff mbox series

[v1,2/9] tests/docker: fix DOCKER_PARTIAL_IMAGES

Message ID 20190917184109.12564-3-alex.bennee@linaro.org
State Superseded
Headers show
Series testing/next (docker,podman,float) | expand

Commit Message

Alex Bennée Sept. 17, 2019, 6:41 p.m. UTC 
Finger trouble in a previous clean-up inadvertently set
DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES.

Fixes: 44d5a8bf5d2
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/docker/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé Sept. 17, 2019, 7:44 p.m. UTC | #1 
On 9/17/19 8:41 PM, Alex Bennée wrote:
> Finger trouble in a previous clean-up inadvertently set

> DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES.


Arf :)

> Fixes: 44d5a8bf5d2

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  tests/docker/Makefile.include | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include

> index 50a400b573a..0d033bfbea8 100644

> --- a/tests/docker/Makefile.include

> +++ b/tests/docker/Makefile.include

> @@ -7,7 +7,7 @@ DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles

>  DOCKER_DEPRECATED_IMAGES := debian

>  # we don't run tests on intermediate images (used as base by another image)

>  DOCKER_PARTIAL_IMAGES := debian debian8 debian9 debian10 debian-sid

> -DEBIAN_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap

> +DOCKER_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap


As John noticed, we have another typo: "debian-9-mxe" -> "debian9-mxe"

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


>  DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))

>  DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))

>  # Use a global constant ccache directory to speed up repetitive builds

>
diff mbox series

Patch

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 50a400b573a..0d033bfbea8 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -7,7 +7,7 @@  DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
 DOCKER_DEPRECATED_IMAGES := debian
 # we don't run tests on intermediate images (used as base by another image)
 DOCKER_PARTIAL_IMAGES := debian debian8 debian9 debian10 debian-sid
-DEBIAN_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap
+DOCKER_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap
 DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))
 DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
 # Use a global constant ccache directory to speed up repetitive builds