From patchwork Wed Sep 4 19:29:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 172967 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp354795ilq; Wed, 4 Sep 2019 12:36:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqxrT/kTquhIm30qmCNSCEudOmQyTr94nUsViGpgruxGYlzeQer9J4lIe6Fvs76Bz+BdA51q X-Received: by 2002:a17:906:5915:: with SMTP id h21mr3260443ejq.28.1567625774257; Wed, 04 Sep 2019 12:36:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567625774; cv=none; d=google.com; s=arc-20160816; b=Ky0maycieVypkpGmoMSlc1At0AhJNr9JDHLQcyYpJukWpFbUCZBnPrxcm5LDmUMixG M2zHIIvRz72+ZE/7a1Be+bLaevf+7CLewuaq47OoFr911S9hjIZCKAaLSXqibxecfWyK JTY6HyJg+RKw3rMjHMqSFQTzN/zlDuHyhBA0trjkZWgCUrsekIKRY++vg7A1m7mo2Au6 bLONCUG7x9ZczQb6q7LwJoRqAwsv3GJOdxRXSbTKSpxc0YJid97WlqPXyvlezQajAp8B bs5XeHNCmY26msjKdimEpkcjSGGtB06cfwfHHS33YK0xXIvdsNLKkMgEbS714dhy/J4F +ywQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=mUfMuu94nY9iTVUmT2HpXRX8/pvEI2tD109hkQpzr/w=; b=JCoKHQm8SRjYr8cZJrNsthSubXNjpGfNszRPTl3UxZGhp8b0AZIesuI0tswVMj7XKi nUx0Hvat0ffr2HQt86eWpAQSFHVz3sAXw/kcMT4IT9L79smEcifLb9frZ1Yen4f4IQPf XEXBRxze8cNwVXntNfReFDgfonGz71RYspXZNWUkoiWXsp3HdmTkK77P53FLwuY/cXKt Gniqbox0pHaWt2n3Bx+m3fxfqjhqMW5JIzgunyKhw3Pwb/DcYDqqc9dvNKetUoOqXSt0 hR3b8JFBO6hIi5apbEd68v5q3Lh6ad2/Ls/Vfl9Klts0zZMRzis5mMds5QwNkTvdWRos YkNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eTUNQP7n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k37si1894079eda.408.2019.09.04.12.36.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Sep 2019 12:36:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eTUNQP7n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5b4f-0000Uw-0g for patch@linaro.org; Wed, 04 Sep 2019 15:36:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39816) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5azq-0004Cy-4H for qemu-devel@nongnu.org; Wed, 04 Sep 2019 15:31:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5azn-00029Y-QE for qemu-devel@nongnu.org; Wed, 04 Sep 2019 15:31:13 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:40813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5azn-00028h-Gu for qemu-devel@nongnu.org; Wed, 04 Sep 2019 15:31:11 -0400 Received: by mail-pf1-x441.google.com with SMTP id x127so1219540pfb.7 for ; Wed, 04 Sep 2019 12:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mUfMuu94nY9iTVUmT2HpXRX8/pvEI2tD109hkQpzr/w=; b=eTUNQP7nuw/1zXzNDy5hZ1YIGSvXVg8rujyUAG00PzwjJ3vzlL7jDdJeI9pE4q8dbh wCNZOn50+lnBnX1aXdMHrXtVdoIvy3v8rOoJMcLiOBBQoYT3WU+o3uwmMiw5h/NVi4/b IPtTBerwL7MkgFVN+BXAfrgO1Jmz8M8R04s9DcJOyhG8ReWUxe2pJu0nDa87qMlwHm5n weIQ9aat7rahADviAxFqNP9GC7LQ/7Fp7tCdbF7E/jQjvwkMyxUVp62VdQivWetcc3zq KCGMz6pYXRlJOtiFh9LxatENMrljJVVu03FfFAbR8uDP37+fzTlJeooBq1UwEtcjWvLB 318A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mUfMuu94nY9iTVUmT2HpXRX8/pvEI2tD109hkQpzr/w=; b=a58ElbmzxoEtb9O84NiRtz86fpcVKym9kotkCORgz4ZylfPPI78nDByHLDCHj0liaV dOQwiCuAny0MyMcZZQ+ILoJe5ZP8u2wQqJ7JIdr0p6B1anCjcJkx/FnV8ft+mLoOmBEs x1PJcPf4HEkuG0/P4yTP7W9P9U4hma16xisKvT3Wyux6pq1mbZSuZcU7zccQcM6NhUpl /vTbRP9zqmK1Q+LX4RrSzi9JiuPuQeYSqdnHHCWwzhVyDYDz66pEmqq/j69z1mtLZ6cp nmpnIyxtIOwVD21XqfsUkg9Yp8GzWbnyn7AMnSw7o+WXncJyUm63TGkOpRetkEbq4auf J1RQ== X-Gm-Message-State: APjAAAVYHRi64Txrs3fcPnHhr/RviW5ez1ttKsQJe4mCQTyaS2cs5FlT Mtjm1k4U7/EnrT0rPaf4kGxGJHwwq0o= X-Received: by 2002:a17:90a:db0e:: with SMTP id g14mr4882317pjv.54.1567625469925; Wed, 04 Sep 2019 12:31:09 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id f6sm18999174pga.50.2019.09.04.12.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 12:31:09 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 4 Sep 2019 12:29:57 -0700 Message-Id: <20190904193059.26202-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190904193059.26202-1-richard.henderson@linaro.org> References: <20190904193059.26202-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::441 Subject: [Qemu-devel] [PATCH v4 07/69] target/arm: Simplify UMAAL X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since all of the inputs and outputs are i32, dispense with the intermediate promotion to i64 and use tcg_gen_mulu2_i32 and tcg_gen_add2_i32. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 34 ++++++++++++---------------------- 1 file changed, 12 insertions(+), 22 deletions(-) -- 2.17.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index 9bcf1e0964..8d70f15a4f 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7346,21 +7346,6 @@ static void gen_storeq_reg(DisasContext *s, int rlow, int rhigh, TCGv_i64 val) store_reg(s, rhigh, tmp); } -/* load a 32-bit value from a register and perform a 64-bit accumulate. */ -static void gen_addq_lo(DisasContext *s, TCGv_i64 val, int rlow) -{ - TCGv_i64 tmp; - TCGv_i32 tmp2; - - /* Load value and extend to 64 bits. */ - tmp = tcg_temp_new_i64(); - tmp2 = load_reg(s, rlow); - tcg_gen_extu_i32_i64(tmp, tmp2); - tcg_temp_free_i32(tmp2); - tcg_gen_add_i64(val, val, tmp); - tcg_temp_free_i64(tmp); -} - /* load and add a 64-bit value from a register pair. */ static void gen_addq(DisasContext *s, TCGv_i64 val, int rlow, int rhigh) { @@ -8119,8 +8104,7 @@ static bool trans_SMLAL(DisasContext *s, arg_SMLAL *a) static bool trans_UMAAL(DisasContext *s, arg_UMAAL *a) { - TCGv_i32 t0, t1; - TCGv_i64 t64; + TCGv_i32 t0, t1, t2, zero; if (s->thumb ? !arm_dc_feature(s, ARM_FEATURE_THUMB_DSP) @@ -8130,11 +8114,17 @@ static bool trans_UMAAL(DisasContext *s, arg_UMAAL *a) t0 = load_reg(s, a->rm); t1 = load_reg(s, a->rn); - t64 = gen_mulu_i64_i32(t0, t1); - gen_addq_lo(s, t64, a->ra); - gen_addq_lo(s, t64, a->rd); - gen_storeq_reg(s, a->ra, a->rd, t64); - tcg_temp_free_i64(t64); + tcg_gen_mulu2_i32(t0, t1, t0, t1); + zero = tcg_const_i32(0); + t2 = load_reg(s, a->ra); + tcg_gen_add2_i32(t0, t1, t0, t1, t2, zero); + tcg_temp_free_i32(t2); + t2 = load_reg(s, a->rd); + tcg_gen_add2_i32(t0, t1, t0, t1, t2, zero); + tcg_temp_free_i32(t2); + tcg_temp_free_i32(zero); + store_reg(s, a->ra, t0); + store_reg(s, a->rd, t1); return true; }