From patchwork Tue Sep 3 16:08:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 172835 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp64732ily; Tue, 3 Sep 2019 09:17:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhWLNunhqi6s1bUHQbPJn80FDFVVoJ7lw9VrqXBJls/HPqDHZgw9uX69vMxotBQgO0ogFV X-Received: by 2002:a0c:ed47:: with SMTP id v7mr74660qvq.170.1567527433228; Tue, 03 Sep 2019 09:17:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567527433; cv=none; d=google.com; s=arc-20160816; b=WciRdW0R1GX/848yT30kch5pBUIx9ZHiQsBLYvTommqg1q7zQLbA56CEbzDP4KxXUs 4mgEhzmfLrE0XvrffPC/K1iFScoWIeMeWJXaltNwf7NheOM1MSgpPhF13w4KFtJSWJb9 LoSuVmckOx0JC64gLyTOhsNFPangeyfyAKSYqXF/5jS8DZhj9ml1lir5zUkFykaHkiXg SxCzdpPzkoyqqCergpevZXvWbhdzINhA2zGZH+kV+II64wjjHXkYj8FsQgpCkjPrL6xs ZP9cQz6y2NoTaZ2QB+INsjGSkc3l1GWfWXpoJ3kVoVbGnG5cKqroELosjyXRxWjOxgTA 0tyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=fzo/4dCtD9XDozJ1PtMm7FQw18sTkDVFqteJc2ZqQUI=; b=DjM4KcI34nqA03kSw1Ieo1FoKu28UHLoGgU/2htkdH838mJMnrQvr+YipR59y/XED2 w//EOVm9T4xyAOnpRvAMdUSJT4Jzrrsr4glnwcRxp4N7uavAevyiJIZX53FEK7m1kNlj FzwzJCojDS7ZxIWRQhaU0L6xH21c6kP4eFOqAJcmc+tMfzBFzUSQZWGADR1aFNRuEelz BaMakW3lOVT4L2WvmfMqKgsmBEYCn5KIEdC5d3bcINW5dUMs3n0zYg9TBTt3JlcS1blL qRBdR8GHnwv3VGTYLMiIYXG28KHrEgbkgV31o3kw1Fhl+o4fQGZ6Fm9DHog0782PQ6YT qrIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PDNKcL9Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i4si12579387qkh.68.2019.09.03.09.17.13 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Sep 2019 09:17:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PDNKcL9Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5BUV-0000D8-TY for patch@linaro.org; Tue, 03 Sep 2019 12:17:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37177) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5BMr-00016G-Vd for qemu-devel@nongnu.org; Tue, 03 Sep 2019 12:09:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5BMq-0003j2-Lp for qemu-devel@nongnu.org; Tue, 03 Sep 2019 12:09:17 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:41629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5BMp-0003hq-Fc for qemu-devel@nongnu.org; Tue, 03 Sep 2019 12:09:16 -0400 Received: by mail-pg1-x52d.google.com with SMTP id x15so9393537pgg.8 for ; Tue, 03 Sep 2019 09:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fzo/4dCtD9XDozJ1PtMm7FQw18sTkDVFqteJc2ZqQUI=; b=PDNKcL9QMs0N1Zjuav+LT+t/d4gvbLwlUefrlpigEapZkn9iuFsM/rsmwsCHxvLeVp 9nKZ+UMFobhWdaTkXdDDAx7T1cvUGVifiP4SgWns8BX6NyfPqc8OQ6XrU3GxNmJlr1pr fnKGKX3ryh+Lqc+YUpg8+yydds9h6rL+gijC9vZkKWtMk0paspVKacQSEbaabcvc0wPy pEJwFYgkEouJBZv1MyZJLu6ia6cX3zCxnqkCG468fYhrHrr7oDLLv54Q/JYjwuEIbMnG eWwYEQaXR8b63jNyOi1gka+vctIua3gKNc63SfbTwBRKmHJWWtM5OJx2a/uzv4JyLXQo j0MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fzo/4dCtD9XDozJ1PtMm7FQw18sTkDVFqteJc2ZqQUI=; b=TMDbp3Ge+/+9WMhvEbCNAk4dkuld6995OgfjfQ2kbSyV8wiHqrQXkmhaAdzk6N0h29 crc5kqJ4WExhIYTB13QKoM+rGfkbpvBlZsvg/khCyzguC+LbIQKNTqFDuhXMptRrkZ5M zTGe7vV4q6gqYz0JLM3F3+ZGnXdPaifw95HJHusNwHxABAw1P81eKjqM2Eb18ic2gYmV 8fahoY6jbXRg/FNJS1unXNpRBqdZbBQ1fvzdbB/QdTFpZwOFAtF1B77+ix7LkBqq7TGk GYM+d0MSUWqwR2Pu2lELP3C/BMajpxaaB5GKX3SeOpLT+MoCqXHP9zcVpqBozpaX5wpz /9KA== X-Gm-Message-State: APjAAAUzprbWEfubkkLpxNjfiFbpU4YLc0e99PiIhZFcZ2XZbxAUW9iR ir8F5duwUuP3BkQ/t4xIo3thXyYYvdA= X-Received: by 2002:a17:90a:bb92:: with SMTP id v18mr59534pjr.78.1567526954161; Tue, 03 Sep 2019 09:09:14 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id 127sm28089711pfy.56.2019.09.03.09.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 09:09:13 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 3 Sep 2019 09:08:33 -0700 Message-Id: <20190903160858.5296-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190903160858.5296-1-richard.henderson@linaro.org> References: <20190903160858.5296-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52d Subject: [Qemu-devel] [PATCH 11/36] hw/s390x: Hard code size with MO_{8|16|32|64} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Tony Nguyen Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Tony Nguyen Temporarily no-op size_memop was introduced to aid the conversion of memory_region_dispatch_{read|write} operand "unsigned size" into "MemOp op". Now size_memop is implemented, again hard coded size but with MO_{8|16|32|64}. This is more expressive and avoids size_memop calls. Signed-off-by: Tony Nguyen Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Message-Id: <76dc97273a8eb5e10170ffc16526863df808f487.1566466906.git.tony.nguyen@bt.com> Signed-off-by: Richard Henderson --- hw/s390x/s390-pci-inst.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index 0c958fc391..0e92a372ca 100644 --- a/hw/s390x/s390-pci-inst.c +++ b/hw/s390x/s390-pci-inst.c @@ -782,8 +782,7 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr, for (i = 0; i < len / 8; i++) { result = memory_region_dispatch_write(mr, offset + i * 8, ldq_p(buffer + i * 8), - size_memop(8), - MEMTXATTRS_UNSPECIFIED); + MO_64, MEMTXATTRS_UNSPECIFIED); if (result != MEMTX_OK) { s390_program_interrupt(env, PGM_OPERAND, 6, ra); return 0;