From patchwork Tue Jun 18 14:11:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 167163 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp4317296ilk; Tue, 18 Jun 2019 07:44:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqyGKtoG2kGXf2GGyPb0suuhZrakAvd+gu+oA7fzB0tdYDqlieXtJHtFKcQIOe/antHUcQJw X-Received: by 2002:ac8:3668:: with SMTP id n37mr55783121qtb.236.1560869060237; Tue, 18 Jun 2019 07:44:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560869060; cv=none; d=google.com; s=arc-20160816; b=CdEgRq3+bV14ZY2J7p9IlHQCjsOeAuqEO5Bu2SdO8mUqcFI3SftlVySC2ywvtRz4X/ 4YauTtMqo7ZS8DdaMGwK7WsSl7mf2c7AGgBtewotFgQh9PAbvq+BV+7dYCkmsPh31Op9 p1ZAJ4Nfr5OmRgNl2PoydvUW/e/6oQQeZAC1IsO7sBBbcZ/96DKM/+lsNDKzALm/6PJ8 sZiRIrnCJVc3v/hk5lNx4RxU9yYuDDysKNBJwNJyq40WTKME4LMXuEZAVd3rX1R/vQTX vPJPk8C4gi1J0qDQ0NjrLUiJlq2ZuDGThYxiGIQ+EN3O8h5uTZqyEA1rM6f3qdLeKpch omYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=VNx9Ajp99J+k2CxoHG8xzhuyro4Mwnnw0aZqs91u9dM=; b=yRzQX9LncWdXnQ2fiqCQrU7Vt+qqwVra9hvAu6I2xv0oZRjRcanP55oIqm9XM8Wdii 4gYHLKbrtaGa2Vy6pvBkm3RB2DN7/oOxr5piMz4K7hkHXhXORYukgaLfrHddwIksBPA2 Kq3oTqsJsqvwuktMqnjpAzr5Rjt7aJx0IuukUPS2/wG8Lrc6Bz10tvY8z9L2OqDdsTZe f8JA6QN3P1k3Y385nAn4eykP8uqI0Y9ZH2zXoRHz3PTaZALGFpFDSv7podc2KQqX8xaD eDl8PEX7Z3WXN7r3cTuNxbkpUYrsLglh9HAZwfnsyLCOInOCPQ2cEGH14EQIz3K/VU5u arCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d25si9934487qve.19.2019.06.18.07.44.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2019 07:44:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:58620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdFLP-0006mQ-QD for patch@linaro.org; Tue, 18 Jun 2019 10:44:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60374) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEqF-00032M-N2 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdEqE-0008Uk-9F for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:12:07 -0400 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:57064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hdEqA-0007ud-T3 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:12:05 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id A1AF94A2CF; Tue, 18 Jun 2019 23:11:34 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 58CA4240085; Tue, 18 Jun 2019 23:11:34 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Tue, 18 Jun 2019 23:11:04 +0900 Message-Id: <20190618141118.52955-26-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190618141118.52955-1-ysato@users.sourceforge.jp> References: <20190618141118.52955-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.15 Subject: [Qemu-devel] [PATCH v21 13/21] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, imammedo@redhat.com, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1