From patchwork Thu May 23 10:25:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 164981 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp1996048ili; Thu, 23 May 2019 03:37:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1q9Uql3hVO5ZQA7BA5I4XGSMvBR9+Zx7BsrKFk8bL9TELlBih3EPXbtOHsz/UTiFoONkA X-Received: by 2002:a17:906:4599:: with SMTP id t25mr49225097ejq.197.1558607857491; Thu, 23 May 2019 03:37:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558607857; cv=none; d=google.com; s=arc-20160816; b=O1kP3AcCzCrYZ/6F7532qGLxhhUvqLv2gachBgS582A3PdvHS3AKAWaRTwQLY5qVOh VXR+FhfSqWrJclP+mT7iknm7Ki0BlQAwZXZ6NHpwkrZoTITaYVs7/dHGkXOP5FFHkm4n 01mLeQTwXjMLAxZYF/g/eGtfGcmT74jqq6MY7Dwr5JepJj+9j9K2scFtTVY7AhiSC5uZ sxHv0DWYEk+5AQzTyz7p78PEA2vTYvyneZx+o8iUcmRGPivbb6Fsst3Xwjih0qdGWKJk glx5J10RO2MP9xd8xuGiJolDK6BjjLbwaH/22+rj9xcIwVNakhLODL8v2AP0LLE0Wev1 eseQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=oyPkJQUuoY6kZyyqgBjqwhy0PzvVeS2HQFmL5+Adi4A=; b=xZd4gvfox06uzbpupcf44cjlCurvRVVl/nEm150SpGE0+ayNXwBbPdYt4pj227kkPw isfra+WCOtKMhneSwop8ajWGkGgMYdSLqIRsJECTRiVqa9W+EViMhmTOE1reziTsOQ+F O3tQ1aiohiMaPX8PPIcerUoP6hTuhaceo5obKYsV+mZ/IbmNiyeYCT5frxkaEgyolUGE 59is9EVZ71UajITNqilmua5OhvCOix9YXBQ+Tzw1N4s2Woz9QuTWjjHZO9yPxGkHnzSW vKgfGnMha7aj2lyiSKKd5zlAnGVO1/AlhLdowAPKyue6v9v6RBR2cAXNre/29YvAidZe QA0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nuKPLW1+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l44si1971761eda.13.2019.05.23.03.37.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 23 May 2019 03:37:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nuKPLW1+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:33235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTl6O-0007R7-6x for patch@linaro.org; Thu, 23 May 2019 06:37:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTkvM-0005x3-9v for qemu-devel@nongnu.org; Thu, 23 May 2019 06:26:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTkvK-0001U4-9C for qemu-devel@nongnu.org; Thu, 23 May 2019 06:26:12 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:35840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTkvK-0000vB-1l for qemu-devel@nongnu.org; Thu, 23 May 2019 06:26:10 -0400 Received: by mail-wm1-x342.google.com with SMTP id j187so5195269wmj.1 for ; Thu, 23 May 2019 03:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oyPkJQUuoY6kZyyqgBjqwhy0PzvVeS2HQFmL5+Adi4A=; b=nuKPLW1+Z37vDr7p+bdJhWm3p3mAdionkRiJNbA0/6Jv/44BIiRTMDJdObos7VqT+d x4DIe5tUSUWwGUZj8bLiQiX/XH5dNBKmSuO/ugUjSv1c/5ATrfsTMHUS/SoQs837fOei slgJHtrA/H51XCwznG3ZMO2Nd1M2xdHQufpwj+FwUaH754oM5zGhVR+QbIYANgKv7RwV mD5fYyaBaFjcGEFqkkSBfcWoLEY6Uw/DVy1yYEBP4pVmpqbmgCDUKHlirQlXQ0HSIrdx JvUvwxUD0lmsg3SWOsUbqbnTxI/kyUJDjLyU+IWAhp3LpeSdH4l4v9Psoy5CJPyhjxEX No3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oyPkJQUuoY6kZyyqgBjqwhy0PzvVeS2HQFmL5+Adi4A=; b=ExUf9Q472D0xawVF2WDOkmiWu7M7hipDw0CP9W5QuFk4lZIFgBQQS+xPIws5nZFTda wnXs6jsc8dSF/wzWSBek4aYZYscIqM0wkdLWxocyF11OVIa0nGBp3/zqapeQgzwrgx0R vtfsgakTemeJNi8Pgw4W9G9ophRXWWX60VMNLy9XP7X+XyZvYLVPQXxlV88LifPY8baa wgrF4OJpjseJxps11MvxB61GX/8K2FYKQ1t3hImWOWSZ6DZFha3vp5eogqEQCIvQJFep +Nm6t8l6pPyf7ewrvQ6yNGmXfrRiNnNL3DP/RDeMjAy6cCiDeBlr1tRa0aQJ6GuhU1oB 7/Hg== X-Gm-Message-State: APjAAAUFbXQ52ukncwW2eCXnSzcFQl0nO8vwMhbGhV0uHFjYWYjOLP8R 9JcFpzvHabdV4Nu1EFVwrorNBw== X-Received: by 2002:a1c:eb07:: with SMTP id j7mr10801336wmh.138.1558607138116; Thu, 23 May 2019 03:25:38 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 6sm35343311wrd.51.2019.05.23.03.25.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 May 2019 03:25:35 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 205DC1FF96; Thu, 23 May 2019 11:25:33 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Thu, 23 May 2019 11:25:11 +0100 Message-Id: <20190523102532.10486-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190523102532.10486-1-alex.bennee@linaro.org> References: <20190523102532.10486-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v2 07/28] target/arm: add LOG_UNIMP messages to arm-semi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Clean-up our unimplemented bits with a proper message. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- target/arm/arm-semi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c index 253c66b172a..a3bbef18ef7 100644 --- a/target/arm/arm-semi.c +++ b/target/arm/arm-semi.c @@ -28,6 +28,7 @@ #include "cpu.h" #include "hw/semihosting/semihost.h" #include "hw/semihosting/console.h" +#include "qemu/log.h" #ifdef CONFIG_USER_ONLY #include "qemu.h" @@ -366,7 +367,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) return len - ret; } case TARGET_SYS_READC: - /* XXX: Read from debug console. Not implemented. */ + qemu_log_mask(LOG_UNIMP, "%s: SYS_READC not implemented", __func__); return 0; case TARGET_SYS_ISTTY: GET_ARG(0); @@ -400,7 +401,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) return buf.st_size; } case TARGET_SYS_TMPNAM: - /* XXX: Not implemented. */ + qemu_log_mask(LOG_UNIMP, "%s: SYS_TMPNAM not implemented", __func__); return -1; case TARGET_SYS_REMOVE: GET_ARG(0);