From patchwork Tue May 14 00:05:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164111 Delivered-To: patch@linaro.org Received: by 2002:ac9:2a84:0:0:0:0:0 with SMTP id p4csp5908038oca; Mon, 13 May 2019 23:10:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYdrdyOYvKIX+oyo5juWFdpv4aRf2UtyuO+w+RvWMpwZiKTSLJP04gFicWUkFMsp+J5Tha X-Received: by 2002:a50:9d43:: with SMTP id j3mr33224509edk.59.1557814258417; Mon, 13 May 2019 23:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557814258; cv=none; d=google.com; s=arc-20160816; b=tnP88HXHBhlbUBbeG+yzDmDvrcLJVe0rTABlQVeC++0gOYC7B10Sn74UwdJDabFHty lrmzs7zBYG6qCgLpNo094IaqMqHq6K+KekaVRUaOSje3eZbo+i2NY0xgn0yQlhNlfhXv SeMg4pmV5uQPVLbPTy2aRYf6B+v17I/CUyoHf8Mz5GobW45HaLaLqrwnyF61gj6W0bX/ cEiG9GTAv79f7F5b689Z8VAm76e52jzXqHDz1UwL52yqbfLw3bTeCdlI2I609QwXpGpK PZw8mankvta7f+WPeaZGJYJqJaBMDBJONOw1GY4KoQxKZv+iiXlr5cugB1VbtXN8V48r QO9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=jMr4oVpt08WI1vYqrX0gvWFc/UY/0FSsdcwMQYw/C7U=; b=dD0W1FboKCYclkxQygSRlRrV25yRBF8e/6plBghTafQ0LsDqS7Hte6qMBkVU20QETo EN35a3BgFtpfz96OXcQ0qKQdPsmCNnw/wFy6xaeIy5VBgpktG/cCv+rWuzhwrwEus20W Q8NI0fNFphHZVEUxYe0bzpLuKsaqehP2ptH+K+RZ7MxRVdjXrsyTYGQRcv4hT2phCXVP 1aIqgI7pGTWkna1K5HG7BvsvQmIXkEcttwbtTiavQT+f/bY4hcX6k1uF/PWOdltm7W+D wnwHvnwFdzBg/Q2OBIMrRYCzLpLmT3yCr9XmEKaxekwjF5lYvrfApswa/z6wqo+YSZ8V wONA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=qqlRZCs7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g28si312065eda.439.2019.05.13.23.10.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 13 May 2019 23:10:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=qqlRZCs7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:40018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQQeP-0002tG-Dk for patch@linaro.org; Tue, 14 May 2019 02:10:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQQcw-0001re-33 for qemu-devel@nongnu.org; Tue, 14 May 2019 02:09:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQQcv-000722-6A for qemu-devel@nongnu.org; Tue, 14 May 2019 02:09:26 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:38012) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQKxA-00035d-QN for qemu-devel@nongnu.org; Mon, 13 May 2019 20:05:58 -0400 Received: by mail-pg1-x532.google.com with SMTP id j26so7597823pgl.5 for ; Mon, 13 May 2019 17:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jMr4oVpt08WI1vYqrX0gvWFc/UY/0FSsdcwMQYw/C7U=; b=qqlRZCs7JRToB5ZfRsgr96EGQPqxfTfXeXuyOuXqL+hxuTEch6+KRMPYH32OY2r12d z7hNC35yW28DBFczbreaGOrMKBSLpVDAuGex6Sts3FdLIqATvg1R/Ob6iztzUvCMxDGW 4u+pTEEYcMDl++yMcNj/cfB38ObrlX6EnuzVIp4DdEvzI7GYtxkuVWbW0DuD6jxK7kVN AzO5gRf+85yzLlODaPnt7JkcyvPbYykg+YLS4zZs99bL3ZnHg6Kx8ZlAM0+DCs98Jkxp GsVAF8rTBtzSw4FTGjayUBeenf+UWDHSYNu4Cvh4XHUI++9Pj5z397P7bA/8bSn8s0LV lzFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jMr4oVpt08WI1vYqrX0gvWFc/UY/0FSsdcwMQYw/C7U=; b=i7BQ0npdekWukyNtuiSe/e5EBbP4jgg/lYk5sk9du9tsqOz+x3c8kfdEIJPI92nf7i Rcmlk+VBBHQISNcAX9asIwwrJ9IAGgQ9pNUCp66/9kl2FdW7oWbuD/HQBy/8xHdLZda3 xW7IcQtq3a9OdOPDnqFTSffTMWbWeUn3jbTAPEcHgBi4M0mFyGg7ALeuaqpjh2wL+BZj i6jZfllePNYeLzWFU0IQK9kAozpMkV3GqgQxIzsawNQxXhfj8BdIEN/spjI97VOz0GiC 04TbkZGV+FN4N3jdtnho11gApCqeqXWS2x5k5XaAMxUilzpluIk6PPYnKpMzxE6qyNSo 71Zg== X-Gm-Message-State: APjAAAX2aDadAXQhLiErK+uwQ4Gzv82t/AjLu3qGzztt0dnQeZD3ajgf ZpG8XHsAkKpTvbfKGPpTiDfT+WLgkXE= X-Received: by 2002:a62:5cc6:: with SMTP id q189mr6419457pfb.114.1557792354415; Mon, 13 May 2019 17:05:54 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id u3sm238151pfn.29.2019.05.13.17.05.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 17:05:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 13 May 2019 17:05:17 -0700 Message-Id: <20190514000540.4313-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190514000540.4313-1-richard.henderson@linaro.org> References: <20190514000540.4313-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::532 Subject: [Qemu-devel] [PULL 08/31] tcg: Support cross-class moves without instruction support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linux.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" PowerPC Altivec does not support direct moves between vector registers and general registers. So when tcg_out_mov fails, we can use the backing memory for the temporary to perform the move. Acked-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg.c | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/tcg/tcg.c b/tcg/tcg.c index 8ed7cb8654..68d86361e2 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -3368,7 +3368,20 @@ static void tcg_reg_alloc_mov(TCGContext *s, const TCGOp *op) ots->indirect_base); } if (!tcg_out_mov(s, otype, ots->reg, ts->reg)) { - abort(); + /* + * Cross register class move not supported. + * Store the source register into the destination slot + * and leave the destination temp as TEMP_VAL_MEM. + */ + assert(!ots->fixed_reg); + if (!ts->mem_allocated) { + temp_allocate_frame(s, ots); + } + tcg_out_st(s, ts->type, ts->reg, + ots->mem_base->reg, ots->mem_offset); + ots->mem_coherent = 1; + temp_free_or_dead(s, ots, -1); + return; } } ots->val_type = TEMP_VAL_REG; @@ -3470,7 +3483,13 @@ static void tcg_reg_alloc_op(TCGContext *s, const TCGOp *op) reg = tcg_reg_alloc(s, arg_ct->u.regs, i_allocated_regs, o_preferred_regs, ts->indirect_base); if (!tcg_out_mov(s, ts->type, reg, ts->reg)) { - abort(); + /* + * Cross register class move not supported. Sync the + * temp back to its slot and load from there. + */ + temp_sync(s, ts, i_allocated_regs, 0, 0); + tcg_out_ld(s, ts->type, reg, + ts->mem_base->reg, ts->mem_offset); } } new_args[i] = reg; @@ -3631,7 +3650,13 @@ static void tcg_reg_alloc_call(TCGContext *s, TCGOp *op) if (ts->reg != reg) { tcg_reg_free(s, reg, allocated_regs); if (!tcg_out_mov(s, ts->type, reg, ts->reg)) { - abort(); + /* + * Cross register class move not supported. Sync the + * temp back to its slot and load from there. + */ + temp_sync(s, ts, allocated_regs, 0, 0); + tcg_out_ld(s, ts->type, reg, + ts->mem_base->reg, ts->mem_offset); } } } else {