From patchwork Fri May 10 17:30:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 163927 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:142:0:0:0:0 with SMTP id j2csp2682370ilr; Fri, 10 May 2019 10:46:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpoOJx58Ep5xom1HXkgTzSlhC6CdIlft5QSs9QGeEuXzuV9FhR3ovKFznng4Yt5ITI7gnI X-Received: by 2002:a17:906:4d57:: with SMTP id b23mr9629728ejv.254.1557510400066; Fri, 10 May 2019 10:46:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557510400; cv=none; d=google.com; s=arc-20160816; b=X0qY9rgntnZx1pXypNeRQ8x76OIWw00ti0oRlbPPDQNKNfu68glDx3f9XfTkGBXio/ iOqfRiXbsCMeKVDw2C1BByVh+VVp/+UXmzvlrNyajJPe/v/4fmSS3Fgc6GmmOkbWkrwa Gtq/c044CAwkk9YCJDcLMbeR7pIE6TrFQKuaN0gUfzhE+MYKtPtOahM5UI3uT6YAZ7xX noce3i7cnOYCn9R7aKjgeKCFvcfZROlLmk6bWFp7LZHMk6LgutWyHRfFYaF2U8yy0Nm0 hmtzj+2apA+n8lt1AE9oV9VUMY9GPa7/TlFDP6CAJDUshhRtkF+6446pNpzDIEKcDq63 5sUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=iRt1ekpVqMBTFPlbEkwvccpMEH6z9s1kPn0wCee76Ys=; b=hadu5DLgEuJYWwvKHMuRKeKVclRboJ5Bj6anFAMU0+62A4DQlkF+k6olZ1Oh89v8M+ rXDQKdFW4cEgjkw9LE7MBj1K+3d5oPrg21ePYbIJE5kPjdHG94T4ykLSfC+ZX9SeryoN kDwgCygbpHjneAYU9NR5EOscVzAZESumtigxTIZcGSzEpeZs9097qr/2UuAlh6jFBlVW VMVJU1AgE6Uo9ssNUxpcUxEwlGkomyD3538kALi3/oThzV/P6swFSRGZGyzt8D60fUq+ YiWKPu/4H1fMADSyxUwCugkD5mwWasd/DO2Lh1ltw5SXeFDL1UCnQVcDNr4Y+FgVD1Sg QU1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ehYp3aoJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c53si764956eda.439.2019.05.10.10.46.39 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 10 May 2019 10:46:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ehYp3aoJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:47708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP9bS-0006T5-Vf for patch@linaro.org; Fri, 10 May 2019 13:46:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP9MZ-0007Ur-Rs for qemu-devel@nongnu.org; Fri, 10 May 2019 13:31:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP9MZ-0006AW-0P for qemu-devel@nongnu.org; Fri, 10 May 2019 13:31:15 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:43225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hP9MY-00069x-R4 for qemu-devel@nongnu.org; Fri, 10 May 2019 13:31:14 -0400 Received: by mail-pl1-x641.google.com with SMTP id n8so3133298plp.10 for ; Fri, 10 May 2019 10:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iRt1ekpVqMBTFPlbEkwvccpMEH6z9s1kPn0wCee76Ys=; b=ehYp3aoJk6VPXB0pVCayxMCdYclH7yxIWbfUw9HmALoWfx1ww1+x8dh8NkU3Mm61pn qp0V/jNsvuDFUBloYorQnMIpz4cu9R88FlvMwFFpm3o4ldLmwjPNM/rKhZW0qGDTbyh1 Y7ooTEjVXBiFk/MtZSBVTfBP2IcOST+JwL6JKSmGFi2S6sgWiDT539/vwYyhtd/K7aCt VLsU5v/xqpNRC0NQFevLXL121aU+vNNHn90nS0gxQ8gpZpCW5FighaCQMRZnotwFtpf5 DrlD4bwdMgpqV5O8tXZaWTr/+1H3fjb5Hrw5EN8AVjXgfc+N4hsbqZwqCiLl2brwYjTh O/9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iRt1ekpVqMBTFPlbEkwvccpMEH6z9s1kPn0wCee76Ys=; b=Tl69pUUIiPt7ioZPqnVKyKb9da6pYEpQ1ANSTRrhkdxCh0ulearsGK9z5R5REf0Puz JRXdYTiPLDAab5nskdqnKucuEiDckOgdjK6cWm5h/hTYGAq8/JWatJuCsYN6xA4PURjN CHknT+4DtXLNw6lLORj0G4zGOtUAqaGC2v2Q88EyUpSe4bP1U/shfqNduYoI3YC45Hf2 uLdZNPVfvGAbSa9fZsWiepGkHTUryw4i28zj+1+kt+L64PKkuc+H7fKRVqCrg7tXZej5 cP2AiHVl5X4dWy5lmq+MgewMH+6Rwff16mgVSS6y7FsqhD/uS9sX8jVfBpWgWGfnqd9V AkgQ== X-Gm-Message-State: APjAAAWHpOIluPQlN3IAOnxzRT3B6VWAYSKbxD4Bu8sbNnDe0DiClWt8 NMegViKlYw4Gz8P9mw1ETeScb+93Xr0= X-Received: by 2002:a17:902:446:: with SMTP id 64mr14480345ple.322.1557509473495; Fri, 10 May 2019 10:31:13 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id v64sm7936792pfv.106.2019.05.10.10.31.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 May 2019 10:31:12 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 10 May 2019 10:30:42 -0700 Message-Id: <20190510173049.28171-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190510173049.28171-1-richard.henderson@linaro.org> References: <20190510173049.28171-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: [Qemu-devel] [PATCH v6 18/25] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of error_abort directly. Cc: qemu-arm@nongnu.org Reviewed-by: Laurent Vivier Reviewed-by: Joel Stanley Signed-off-by: Richard Henderson --- hw/misc/nrf51_rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/hw/misc/nrf51_rng.c b/hw/misc/nrf51_rng.c index d188f044f4..3400e90a9b 100644 --- a/hw/misc/nrf51_rng.c +++ b/hw/misc/nrf51_rng.c @@ -14,7 +14,7 @@ #include "qapi/error.h" #include "hw/arm/nrf51.h" #include "hw/misc/nrf51_rng.h" -#include "crypto/random.h" +#include "qemu/guest-random.h" static void update_irq(NRF51RNGState *s) { @@ -145,7 +145,7 @@ static void nrf51_rng_timer_expire(void *opaque) { NRF51RNGState *s = NRF51_RNG(opaque); - qcrypto_random_bytes(&s->value, 1, &error_abort); + qemu_guest_getrandom_nofail(&s->value, 1); s->event_valrdy = 1; qemu_set_irq(s->eep_valrdy, 1);