From patchwork Thu May 9 06:02:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 163668 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:142:0:0:0:0 with SMTP id j2csp547187ilr; Wed, 8 May 2019 23:11:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxesiH3FtVepAzMIhhsxtxysfXlcWAU1Ro6BePG0XWZkMJ3TcQlpU+IKcKehCT3Hc31OeXR X-Received: by 2002:a05:6000:11cb:: with SMTP id i11mr1449604wrx.49.1557382284102; Wed, 08 May 2019 23:11:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557382284; cv=none; d=google.com; s=arc-20160816; b=xpAy5lRj1dhgixyNjAGKwY80L7sfjZpaUkiTxJHR+Hhk7V1Ytbu/U3V8ofmTYXH3Rg kjTcFELifSeuAUuxpsxbwwlG4x60AaMhssJu3enVtozM4ArhCYmm9SlWmwfGjEhMWJlJ FXc90lqbMhFmcSmirOhZzDqMMexXXd0AR8tjaYFfUTJ9JKwPrSGwGiqcbR4WKFd9dOYo AcpuotV1LUHfrFBG4gcBI73O3gxeXX1wGNTUUe8J66CO5q8lD3QR0Ux+RzDE/Cn8j9Np msBmVMTIB4bkqn64XEfkGJ5VM9OY3AyUpv9etExH9iGqI+IfHs1qTS48NTSEM3ZvpVM4 UX8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=07wHa/xA9yiJWa4ShTDFiM4bI0/fgquttB2WDIhcNlI=; b=RoZhazEYK0LYD7qAupByw2nDnNqT3gmEHkEr/+BfqCkOMOsFNEQm7O4DpfpSRzpaZu +ScdHxfTBVThh8Dm6n/gPMdr7RXV65YumvM9FBLFhmzvaJyOwH4spNQyhdPQ4mFGYtqw Yc8Tvp1HWINLqy7JdjFYFFl3xWi2aTiIhdekEs45jLtaOm0klhB+qvgG5EBtQDABfTjo AmVcTvIGxQgN+Z4Thhou9BzFs7E62J5nEOJ9Cx1vCbxoatnrhyWszQokfG1eDIw40+iy Njb9/tOKi1i2CvSbCOKLNWE9x6mFqwHyTt6MFw5QDGr4dHmQZhbyy9Ypcx1b42WAVwTE LlUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=uo0NjIK1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s17si815278wmj.170.2019.05.08.23.11.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 08 May 2019 23:11:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=uo0NjIK1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:48692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOcH4-0005oB-T1 for patch@linaro.org; Thu, 09 May 2019 02:11:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOc94-00063X-L0 for qemu-devel@nongnu.org; Thu, 09 May 2019 02:03:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOc93-000781-9r for qemu-devel@nongnu.org; Thu, 09 May 2019 02:03:06 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:41593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOc93-00077Z-3z for qemu-devel@nongnu.org; Thu, 09 May 2019 02:03:05 -0400 Received: by mail-pf1-x441.google.com with SMTP id l132so715040pfc.8 for ; Wed, 08 May 2019 23:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=07wHa/xA9yiJWa4ShTDFiM4bI0/fgquttB2WDIhcNlI=; b=uo0NjIK18+rwpny5vBRAv2imCPLqKp0zRGCaVI9E1fDaG4X/Wemi2ZJQekhdY/ov0q rNWC3uiC7nyykvmebq7KjE2pMOp4POOv0Y0t49h+wn+iffTW4T1EbxeGgDBiNIOjYdnE ydyOIqNn4XWVgbaU8QPMSAexvGIvu0yEgyX10Mv4Wgkw7lTVi+lGs/ggm1b5g/S+6bzm eb5MAInqV3RK3MkN1H59/nxI//IeSeLZG+P6ipgJADb6KrUBWE/HbXynOamiLkoBmNcC szMAbkFdS6nw9kJcPXzK63DE/2h9JrHfzOP+k13g9uu0zmozLaSsbZdFixgswaYYW4uM 0v8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=07wHa/xA9yiJWa4ShTDFiM4bI0/fgquttB2WDIhcNlI=; b=DgqMVRBjOxQuhPe6eGiv4Vev7w/rpzeqT1Fw8L26tgluJxKKqTJk86d3lSXLjy7gBz gzKPL+35J6N3WZUdxqq9P+d9nKkZO/uZ7Lq/wX2DNhMxlaUVafOfQQsLr8784AVzBb3Z /tQJh6e7Z4mJj6ChB9Nqgqp88gPfkXfxUt7eH5W5TvQc8QnNi/K09iAUn7XPanvI4pxr N3NDcSw2o6X7hcRdEtkSVm5pIEc3lStn4LiSJcctntNWoc1BN7OtX+oHgqe7hW2K0ICv +XMh9MlweY04ebiBee1cRjvFAvv5uZm7nqRd/ui+/yfWuKSAD+BcuISSbCXKARMgx8aw UDmQ== X-Gm-Message-State: APjAAAV8DoUMTtcJJCzpe0pYU7FolBe6NjFJb/+56/CpO7jrxvwrNFPi /MSXR9Xj43/416n7HJx8J71+1Ab0rwA= X-Received: by 2002:aa7:92d5:: with SMTP id k21mr2561289pfa.223.1557381783851; Wed, 08 May 2019 23:03:03 -0700 (PDT) Received: from localhost.localdomain (97-113-27-95.tukw.qwest.net. [97.113.27.95]) by smtp.gmail.com with ESMTPSA id n7sm1496109pff.45.2019.05.08.23.03.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 23:03:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 8 May 2019 23:02:31 -0700 Message-Id: <20190509060246.4031-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190509060246.4031-1-richard.henderson@linaro.org> References: <20190509060246.4031-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::441 Subject: [Qemu-devel] [PATCH v2 12/27] target/mips: Convert to CPUClass::tlb_fill X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Aleksandar Markovic Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Note that env->active_tc.PC is removed from the qemu_log as that value is garbage. The PC isn't recovered until cpu_restore_state, called from cpu_loop_exit_restore, called from do_raise_exception_err. Cc: Aleksandar Markovic Cc: Aleksandar Rikalo Signed-off-by: Richard Henderson --- v2: Split out other mips cleanups to simplify the diff --- target/mips/internal.h | 5 +++-- target/mips/cpu.c | 5 ++--- target/mips/helper.c | 45 ++++++++++++++++++++++------------------- target/mips/op_helper.c | 15 -------------- 4 files changed, 29 insertions(+), 41 deletions(-) -- 2.17.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/mips/internal.h b/target/mips/internal.h index 286e3888ab..b2b41a51ab 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -202,8 +202,9 @@ void cpu_mips_start_count(CPUMIPSState *env); void cpu_mips_stop_count(CPUMIPSState *env); /* helper.c */ -int mips_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int size, int rw, - int mmu_idx); +bool mips_cpu_tlb_fill(CPUState *cs, vaddr address, int size, + MMUAccessType access_type, int mmu_idx, + bool probe, uintptr_t retaddr); /* op_helper.c */ uint32_t float_class_s(uint32_t arg, float_status *fst); diff --git a/target/mips/cpu.c b/target/mips/cpu.c index e217fb3e36..ebdb834b97 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -197,9 +197,8 @@ static void mips_cpu_class_init(ObjectClass *c, void *data) cc->synchronize_from_tb = mips_cpu_synchronize_from_tb; cc->gdb_read_register = mips_cpu_gdb_read_register; cc->gdb_write_register = mips_cpu_gdb_write_register; -#ifdef CONFIG_USER_ONLY - cc->handle_mmu_fault = mips_cpu_handle_mmu_fault; -#else + cc->tlb_fill = mips_cpu_tlb_fill; +#ifndef CONFIG_USER_ONLY cc->do_unassigned_access = mips_cpu_unassigned_access; cc->do_unaligned_access = mips_cpu_do_unaligned_access; cc->get_phys_page_debug = mips_cpu_get_phys_page_debug; diff --git a/target/mips/helper.c b/target/mips/helper.c index 86e622efb8..3a4917ce7b 100644 --- a/target/mips/helper.c +++ b/target/mips/helper.c @@ -874,31 +874,25 @@ refill: #endif #endif -int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw, - int mmu_idx) +bool mips_cpu_tlb_fill(CPUState *cs, vaddr address, int size, + MMUAccessType access_type, int mmu_idx, + bool probe, uintptr_t retaddr) { MIPSCPU *cpu = MIPS_CPU(cs); CPUMIPSState *env = &cpu->env; #if !defined(CONFIG_USER_ONLY) hwaddr physical; int prot; - int access_type; + int mips_access_type; #endif int ret = TLBRET_BADADDR; -#if 0 - log_cpu_state(cs, 0); -#endif - qemu_log_mask(CPU_LOG_MMU, - "%s pc " TARGET_FMT_lx " ad %" VADDR_PRIx " rw %d mmu_idx %d\n", - __func__, env->active_tc.PC, address, rw, mmu_idx); - /* data access */ #if !defined(CONFIG_USER_ONLY) /* XXX: put correct access by using cpu_restore_state() correctly */ - access_type = ACCESS_INT; - ret = get_physical_address(env, &physical, &prot, - address, rw, access_type, mmu_idx); + mips_access_type = ACCESS_INT; + ret = get_physical_address(env, &physical, &prot, address, + access_type, mips_access_type, mmu_idx); switch (ret) { case TLBRET_MATCH: qemu_log_mask(CPU_LOG_MMU, @@ -915,7 +909,7 @@ int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw, tlb_set_page(cs, address & TARGET_PAGE_MASK, physical & TARGET_PAGE_MASK, prot | PAGE_EXEC, mmu_idx, TARGET_PAGE_SIZE); - return 0; + return true; } #if !defined(TARGET_MIPS64) if ((ret == TLBRET_NOMATCH) && (env->tlb->nb_tlb > 1)) { @@ -926,27 +920,36 @@ int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw, int mode = (env->hflags & MIPS_HFLAG_KSU); bool ret_walker; env->hflags &= ~MIPS_HFLAG_KSU; - ret_walker = page_table_walk_refill(env, address, rw, mmu_idx); + ret_walker = page_table_walk_refill(env, address, access_type, mmu_idx); env->hflags |= mode; if (ret_walker) { - ret = get_physical_address(env, &physical, &prot, - address, rw, access_type, mmu_idx); + ret = get_physical_address(env, &physical, &prot, address, + access_type, mips_access_type, mmu_idx); if (ret == TLBRET_MATCH) { tlb_set_page(cs, address & TARGET_PAGE_MASK, physical & TARGET_PAGE_MASK, prot | PAGE_EXEC, mmu_idx, TARGET_PAGE_SIZE); - return 0; + return true; } } } #endif + if (probe) { + return false; + } #endif - raise_mmu_exception(env, address, rw, ret); - return 1; + raise_mmu_exception(env, address, access_type, ret); + do_raise_exception_err(env, cs->exception_index, env->error_code, retaddr); +} + +#ifndef CONFIG_USER_ONLY +void tlb_fill(CPUState *cs, target_ulong addr, int size, + MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) +{ + mips_cpu_tlb_fill(cs, addr, size, access_type, mmu_idx, false, retaddr); } -#if !defined(CONFIG_USER_ONLY) hwaddr cpu_mips_translate_address(CPUMIPSState *env, target_ulong address, int rw) { hwaddr physical; diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 0f272a5b93..6d86912958 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -2669,21 +2669,6 @@ void mips_cpu_do_unaligned_access(CPUState *cs, vaddr addr, do_raise_exception_err(env, excp, error_code, retaddr); } -void tlb_fill(CPUState *cs, target_ulong addr, int size, - MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) -{ - int ret; - - ret = mips_cpu_handle_mmu_fault(cs, addr, size, access_type, mmu_idx); - if (ret) { - MIPSCPU *cpu = MIPS_CPU(cs); - CPUMIPSState *env = &cpu->env; - - do_raise_exception_err(env, cs->exception_index, - env->error_code, retaddr); - } -} - void mips_cpu_unassigned_access(CPUState *cs, hwaddr addr, bool is_write, bool is_exec, int unused, unsigned size)