| Message ID | 20190420073442.7488-25-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tcg vector improvements | expand |
On 20.04.19 09:34, Richard Henderson wrote: > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/s390x/translate.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index 0afa8f7ca5..030129acbb 100644 > --- a/target/s390x/translate.c > +++ b/target/s390x/translate.c > @@ -1407,13 +1407,7 @@ static DisasJumpType help_branch(DisasContext *s, DisasCompare *c, > > static DisasJumpType op_abs(DisasContext *s, DisasOps *o) > { > - TCGv_i64 z, n; > - z = tcg_const_i64(0); > - n = tcg_temp_new_i64(); > - tcg_gen_neg_i64(n, o->in2); > - tcg_gen_movcond_i64(TCG_COND_LT, o->out, o->in2, z, n, o->in2); > - tcg_temp_free_i64(n); > - tcg_temp_free_i64(z); > + tcg_gen_abs_i64(o->out, o->in2); > return DISAS_NEXT; > } > > Reviewed-by: David Hildenbrand <david@redhat.com> -- Thanks, David / dhildenb
On 4/20/19 9:34 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/s390x/translate.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index 0afa8f7ca5..030129acbb 100644 > --- a/target/s390x/translate.c > +++ b/target/s390x/translate.c > @@ -1407,13 +1407,7 @@ static DisasJumpType help_branch(DisasContext *s, DisasCompare *c, > > static DisasJumpType op_abs(DisasContext *s, DisasOps *o) > { > - TCGv_i64 z, n; > - z = tcg_const_i64(0); > - n = tcg_temp_new_i64(); > - tcg_gen_neg_i64(n, o->in2); > - tcg_gen_movcond_i64(TCG_COND_LT, o->out, o->in2, z, n, o->in2); > - tcg_temp_free_i64(n); > - tcg_temp_free_i64(z); > + tcg_gen_abs_i64(o->out, o->in2); > return DISAS_NEXT; > } > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 0afa8f7ca5..030129acbb 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -1407,13 +1407,7 @@ static DisasJumpType help_branch(DisasContext *s, DisasCompare *c, static DisasJumpType op_abs(DisasContext *s, DisasOps *o) { - TCGv_i64 z, n; - z = tcg_const_i64(0); - n = tcg_temp_new_i64(); - tcg_gen_neg_i64(n, o->in2); - tcg_gen_movcond_i64(TCG_COND_LT, o->out, o->in2, z, n, o->in2); - tcg_temp_free_i64(n); - tcg_temp_free_i64(z); + tcg_gen_abs_i64(o->out, o->in2); return DISAS_NEXT; }
Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/s390x/translate.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) -- 2.17.1