From patchwork Fri Mar 15 03:26:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160390 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp16276990jad; Thu, 14 Mar 2019 20:56:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzh8vMShaHJBA3vdN5cgrNLXdMZEneuyTArt5A2EQMVpBR+VsUdJlCh4yM805TVG/B6PmlF X-Received: by 2002:a1c:6555:: with SMTP id z82mr514200wmb.125.1552622160050; Thu, 14 Mar 2019 20:56:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552622160; cv=none; d=google.com; s=arc-20160816; b=WpBvsuo12n173Kn/KKHZ7R2BDrWu0QYKL0+WHbOTgP6K6Ar+qwYkn7qUuNOiEVPYe1 CLB4FMwjgWspzLVXMJvWtDdLL2nEHa2etQvv7Tvj0ktp2ZQebJQHL65z08GvD014I3q4 wM4ZcjUmeJlTfZq8NsIjnJ18sHo1lUzPlPQKyR7S3gKIB+f8RXeKEDsQ4EH8oZcSPlhe Fbk2l1Oi2lFh96jYe535KF8YNQOjDXDLk1XicLlYomhhe4+lKkZ3sOAfJAL+q0ng4xsI PqU1GKMxN2st0jgqDJQ6BLYtVOQkAq3TYDMPyNyJSo/S7K6972OZdaFw4ilTDGvzIYXa 03Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=qYcAKtdWYXUNf1fKI4qFDzlyltObQFn2JF2oGmL9Qc4=; b=rf+lPW5TJJRrxwfwk27aKWmzbM2LucJ2aMxsDHpePMx96HrlvwGzlR3Gn6Dh73Iy2u Ppk1sVNThwtQelY951Iisf7swXBfPVCPn3mL/7kUkpyMnTWrUeltG8iYeiB8vU7Xie99 CA0OWVmn782uSlScYstk7b9a9VnK0wMjX5DJmwZFjFT9USaihdqXndCqGy/5M8Ci356X FQXzSiOFAIUe0alMIoQRjvI9fYtNDTBq3RfJg5EjuirTNpTkmXrbhiI7MXp8a02OhdCh y6DHxLPJH6JohOS7JV5krnN0jxCbaVcnZFQO1ufIsn7YFC6GVGFRMQ7PcsEtpEMAo++H plfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UAVulb15; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s17si517377wri.457.2019.03.14.20.55.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 14 Mar 2019 20:56:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UAVulb15; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:49162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4dwt-0005q8-3a for patch@linaro.org; Thu, 14 Mar 2019 23:55:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4dcL-00059H-RM for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:34:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4dUU-0002mD-Qf for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:26:39 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:43361) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4dUU-0002jw-IU for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:26:38 -0400 Received: by mail-pf1-x444.google.com with SMTP id q17so5268968pfh.10 for ; Thu, 14 Mar 2019 20:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=qYcAKtdWYXUNf1fKI4qFDzlyltObQFn2JF2oGmL9Qc4=; b=UAVulb15W4ZK+fxP3Zn2T9/6HolA5xelkQvJojVlix06yNVK5470tIwR+GhDDJP3CT 25zWd1Fiy5QWkYuwXhGEd961yvButhqW28aUSDmdW2gBxZZd77Yp0Kawan1PFT24ZsYq SmYo4pFMxFy1xUeC96F1QuEvaY3myo57ESgkHzlou/GQmLtPAYase+oLpLqIzLMB58uw xq3jw6jRQ8EG1XOWcPOsBDrMMHY/DBcApYb8Nd/SZAmEndzu7HYRkiu/jt5QpZXMDjCN uXIiP3KIOyp1IlSxj3xWxWY8QSRCtUy3HpLlcagI/snmzy9u52YSyXkfP3lmvzQctHbi 5szw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qYcAKtdWYXUNf1fKI4qFDzlyltObQFn2JF2oGmL9Qc4=; b=BUkxzXFRhZBR5MRxetz//gl2faV7z2YlZJxDMp8Ia8t4EFpkL37jKTpBuPIR/oql0+ JcBqR9MzG3B/SmaWnNKg0I0/hHp/1VnaPJGNPctTvNnGTkYOSZWimkV5pk82Ere7tIQu XtNMhpJo51HN7dgdo7yzTbUxquHuZccpGbGMGFAdcKL9QFfNWBxMO3Wul7hlUv7yUYBu I+I6VvWAlh7rmske2RsHCsKSSSV7QFQLcgqKoiQ3WnXbg+LSOZXz6m0+I7iZT8g/61cW JOY/vE2X2XiYkX2GXff/wL7vKqe7T0WV+7qg3tKmeeZ9XOFkCB+gTc/XP01QXq14azCM scKA== X-Gm-Message-State: APjAAAW9pRzqG2yeA2xCoyn9D+gMNPop3rssV4EtV2EcGmv8/s+uAeN4 NCwX5zYQPYN6T4jEUk7K1Lfa6mLaLio= X-Received: by 2002:a62:5c3:: with SMTP id 186mr1697763pff.35.1552620396869; Thu, 14 Mar 2019 20:26:36 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id d26sm690816pfn.86.2019.03.14.20.26.35 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 20:26:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 14 Mar 2019 20:26:10 -0700 Message-Id: <20190315032629.21234-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190315032629.21234-1-richard.henderson@linaro.org> References: <20190315032629.21234-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 Subject: [Qemu-devel] [PATCH v3 04/23] crypto: Use O_CLOEXEC in qcrypto_random_init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Avoids leaking the /dev/urandom fd into any child processes. Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.2 Reviewed-by: Philippe Mathieu-Daudé diff --git a/crypto/random-platform.c b/crypto/random-platform.c index 260b64564d..6df40744c7 100644 --- a/crypto/random-platform.c +++ b/crypto/random-platform.c @@ -42,9 +42,9 @@ int qcrypto_random_init(Error **errp) #else /* TBD perhaps also add support for BSD getentropy / Linux * getrandom syscalls directly */ - fd = open("/dev/urandom", O_RDONLY); + fd = open("/dev/urandom", O_RDONLY | O_CLOEXEC); if (fd == -1 && errno == ENOENT) { - fd = open("/dev/random", O_RDONLY); + fd = open("/dev/random", O_RDONLY | O_CLOEXEC); } if (fd < 0) {