From patchwork Fri Mar 15 03:26:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160367 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp16264096jad; Thu, 14 Mar 2019 20:35:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqx60tztcZFu1CYgB1w6H+aPAiF+XiXXiBtbNkno1ruTAVB/FpCR3eXXfCum0wbhbSqgLSjK X-Received: by 2002:adf:ce90:: with SMTP id r16mr731558wrn.64.1552620921056; Thu, 14 Mar 2019 20:35:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552620921; cv=none; d=google.com; s=arc-20160816; b=X74SAA4deRsjho5qZya5i3sqrM8RBxZbjeCx7IXqVLIVQ0sIEbMZNIeFdk8MsK0Hpa hgLcFdRAi6YypLQtlDQpVw6R+cA8dJUPQvomxnhCgTgJ/hsSbmWx7xrKCZ2jwfKDwlin 2fTHFQ21eq4ZYMsAbjeD5DAU2iM3MIWhhNwCT8FycLI4BesKr5X7X27ot4Yh33jm6rwP y/IN+Vn7T0JrP74aTABhUFGtgXuOIQIQt47363X05vCFGKMZoRGCz+n6MzfguPMuoPW9 kTjp1jHdjgqhCk4n4ORGSXbRvpIvMzEhS7cabPdd1tAulZftHF5Hkd/RFqMBplhk6A69 cixw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=g09DjJXhGsFzGWxwKf5V5HWGbXw30Sr7rYhBrQNj528=; b=IwX85wUlkI+jy6c0R1P4dAek6tmk4yQ+E4eXpTR89Sv4vWZ8NXEaDjG3x94SFK5Hua LJ4pSYe4wN/3E1IdrfJHd4hPc5FmD3HoMLg/dj/oJpHkvzW+c3V/6kH62oebAsVM4aTx 2DuU1Z4wX26oBl0LPJsLmBPSFDxcfNYujVQVkPru4OjU5GRSBzmAT3RMYmgUdqXyec+I 5R7Hplrg4cuqm9fn4hl+3ie/B0HHk2Tg0AebvispBpwY2ZwPjmCFkgzRun0QciHCVU3x lUHDkqKXpgVO6OVsoRAIKuHcnivtAAyn+A8qpqwQgrZ9J2u2h3dyBBU54K5vIaw5P7EM 0aFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sIlm5vi3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x18si461603wrv.199.2019.03.14.20.35.20 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 14 Mar 2019 20:35:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sIlm5vi3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:48662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4dct-0005El-W6 for patch@linaro.org; Thu, 14 Mar 2019 23:35:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4dcH-00057Y-Pf for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:34:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4dUs-0003CA-94 for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:27:03 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:46689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4dUs-0003BL-0x for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:27:02 -0400 Received: by mail-pf1-x434.google.com with SMTP id s23so5258712pfe.13 for ; Thu, 14 Mar 2019 20:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g09DjJXhGsFzGWxwKf5V5HWGbXw30Sr7rYhBrQNj528=; b=sIlm5vi3Wy+q706fV4TQmyPwjSvjhUwoH9WdL2JZuyXs17B8EqdbansQloZgy4cy3F diXd1tsjTTWgsDnzzlGhhs1r5ee3rtlvnBvhOwUFLC0lBG2sb4NUoeGTPTKQS5EwGbf0 G83h3SDSWEcdSP0AsszHCJRsd1aQNkmHqh5jkVQ/Zll9RoJbcZTQxsWk1Y+rws4j2lSK 4DxNEsquHV9f0jJOEiR9IIW84ukXsbMOm+W3Krat1shV6K4nSZJG3f6z5S0Yugodj7Di RSf29mTNGdhnE+wRo1ZkpeYI//ZQBGDeqhx22Umm//bh02rkT1R8U0Rs70uPAb5NCuFP xJTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g09DjJXhGsFzGWxwKf5V5HWGbXw30Sr7rYhBrQNj528=; b=FlMZ67lWnb0LNBNtOY/OAXxabfiD9UF8SuDPPu2viXiuRrK7GKCa6MYbeT1sHmLNa2 8fTMRoXz1pTJTc5rYngXq47QOl+GaQvMum2jkZs21dsZDs2XHN+SW0qkjjllCbVv2FNu TicK8APsmjv6p7m7uCAg/LsJIJvqF2iPLD1ZGcgz7apdGpa7eD5nWWDnFujcK2CvzdrD paKqfTtGheaNfK+Q4cS/urRLhSabawF0PPl4N7iW8PvDVzEVmuGU53VQIF56FS4kO3xU CXJgs1gx3ezknlTbHjgaVxXFspTwBSnNzVNIsCol4hF46uIJTRhXATgpKXhY/neIBYnv IqPw== X-Gm-Message-State: APjAAAWOR9cCeVfAVj6GL0cDTszu9V7oNENvOzs9weNAQxPGKigR4bJd eGuMjBujb7b35qLQBh96s2U8aU8UbyQ= X-Received: by 2002:a17:902:622:: with SMTP id 31mr1828164plg.31.1552620420674; Thu, 14 Mar 2019 20:27:00 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id d26sm690816pfn.86.2019.03.14.20.26.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 20:26:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 14 Mar 2019 20:26:28 -0700 Message-Id: <20190315032629.21234-23-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190315032629.21234-1-richard.henderson@linaro.org> References: <20190315032629.21234-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::434 Subject: [Qemu-devel] [PATCH v3 22/23] target/ppc: Use qemu_guest_getrandom for DARN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We now have an interface for guest visible random numbers. Cc: qemu-ppc@nongnu.org Cc: David Gibson Signed-off-by: Richard Henderson --- target/ppc/int_helper.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-) -- 2.17.2 Acked-by: David Gibson diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index 162add561e..c26531e598 100644 --- a/target/ppc/int_helper.c +++ b/target/ppc/int_helper.c @@ -23,6 +23,8 @@ #include "exec/helper-proto.h" #include "crypto/aes.h" #include "fpu/softfloat.h" +#include "qapi/error.h" +#include "qemu/guest-random.h" #include "helper_regs.h" /*****************************************************************************/ @@ -156,25 +158,39 @@ uint32_t helper_cmpeqb(target_ulong ra, target_ulong rb) #undef haszero #undef hasvalue -/* Return invalid random number. - * - * FIXME: Add rng backend or other mechanism to get cryptographically suitable - * random number - */ target_ulong helper_darn32(void) { - return -1; + Error *err = NULL; + uint32_t ret; + + if (qemu_guest_getrandom(&ret, 4, &err) < 0) { + qemu_log_mask(LOG_UNIMP, "darn: Crypto failure: %s", + error_get_pretty(err)); + error_free(err); + return -1; + } + + return ret; } target_ulong helper_darn64(void) { - return -1; + Error *err = NULL; + uint64_t ret; + + do { + if (qemu_guest_getrandom(&ret, 8, &err) < 0) { + qemu_log_mask(LOG_UNIMP, "darn: Crypto failure: %s", + error_get_pretty(err)); + error_free(err); + return -1; + } + /* Since -1 is the error condition, try again for that case. */ + } while (unlikely(ret == -1)); + + return ret; } -#endif - -#if defined(TARGET_PPC64) - uint64_t helper_bpermd(uint64_t rs, uint64_t rb) { int i;