From patchwork Thu Mar 14 04:55:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160288 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp15073413jad; Wed, 13 Mar 2019 21:59:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwhBePrPneplkBAU078P3djtvmObauI1fVtGO0Na20APXixy/JeylqPFrE5f4ir3UjM200r X-Received: by 2002:a25:34d3:: with SMTP id b202mr40239944yba.188.1552539550414; Wed, 13 Mar 2019 21:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552539550; cv=none; d=google.com; s=arc-20160816; b=SPV8yFpBNFTkGtX6dlaetrMv1ayynH/KLIwdKvfb8Jw8sO9dcA5ubVerxenjsvw4vl 56Iao9GQ9j6F44Qc4CL4hs0KgfHBvZYPVu8CF6t19z8bSasO+9zXqAgENxlMVELBeFUe kTuglblYlfzKj3FhNS7eVGO9n508oyZJ/jDSlhV3bo9UlPwTaVNMg+97ZfwHn1Bi+Mgf S6+MKPc56W09l3f7CsW9RxmXXLpTmudGG333kjlNAoVCGaYAygV3JJmVM2GqMdNM2mau 0HPNolqUXqWKma3PnhGCJVhw582P7wmfySLuqPDmltS6f+CAIcq55U3bou37IM2uv1/f rpWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=xzvOFE0efPIbOrrniJr0rCF+lgmieAStNQzr5aCVccg=; b=DhkeCUKv6CrjAZI1l7nQwBQx9ZTPd4wTk9romm2byr5CucomiKvvCGWFQxjZLAnzm6 l/By41oMlZd43nneVvhnoqbXmOmNUKN7x2oN9g65DYmu4L/i+71bI5HGsEmXJh9tTNBT Ryjm3Do70MVyBd7ZoE3gSMDNR3y27jWB8IxbbA1BZCSjqV3Z9NTOCSnKiRIrxB6umsGh Z09EaNk0rH9BiT0UIe09ysMdjgHsfy7UzKvAyquI8knSQ4sTtKgU8nE1RV7eyJERVLav RGIoHk7IjYlwsOWF4YDvylF/cHT+TWdAux0TeSBsLopAnT5KeHbNcDtXCfiwS6FSRT9I FcJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UHIxX9Lk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k10si8167319ybb.486.2019.03.13.21.59.10 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 13 Mar 2019 21:59:10 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UHIxX9Lk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:56871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4ISS-0006tG-Bs for patch@linaro.org; Thu, 14 Mar 2019 00:59:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4IP5-0004XY-Dm for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4IP4-0007Of-KW for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:39 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:39624) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4IP4-0007OM-Ca for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:38 -0400 Received: by mail-pg1-x542.google.com with SMTP id h8so3146945pgp.6 for ; Wed, 13 Mar 2019 21:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xzvOFE0efPIbOrrniJr0rCF+lgmieAStNQzr5aCVccg=; b=UHIxX9LkHu52su0CP7YXy10UbQPtFne/AoPEa0HbGCTzkshD7J4YnENOOIwXy30ljo W/+qs+JmMbx7MB34v1u2ujGukCDED0VUEExv8XwMUMOegmTUn3vIYuzrCH5Q0dFBE/mR EdTPABSolCLVQ1HMWYs9uaVkxaf0QsjMysiFODn2eQGTda57+HaV/5uNqY5bbv/LkuEv r9cCGpX0AmFUPQ5yVoJY5G9vCavxmnnT35Iw2cFhK74gPnz39eehQ/RBSP1u3XQd1wkO UUbRXpJgcNAapGwgjyaQ9gRcXbfQiJFOyQyR5OTUSQLsqccZNXtDlsGf77VUqmyHGFdL NmOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xzvOFE0efPIbOrrniJr0rCF+lgmieAStNQzr5aCVccg=; b=DB9EIcrt57L6GB9c9/bGbDqpkstrBYB3fIMRCnNkI8GnMRhOB/Sv7TuYAwtZnpsLPz bkWn8RFvOi0y6GTwSnUDURzBUt+qkorwKPPX+1hpGAF+ETgusjUKBnsbjHKf8UyQBSCD hC342s6//wWF7i0yoBv9E5WQYxPKjvjcyf0d03JbkjZiKW3Bwtoq6HNK74OT3WOTgm5d Jwmo98mXvUvG6pplZXeQlZG4rxjJH6dKQi5lRGFdMQAf38DVPZ+pYxopUr3fe1AyDvlS HO5iVApw0rR9OF3Dv9ecFEUksJZouef1MpDrKOT3Ofb2g0V67mPSzdcEt8GuMIHEOvkF FjTw== X-Gm-Message-State: APjAAAV2dnHR7ssxQxtWa3fJPHsxO7py+OFhh7Ccuvez7RmubUnj9t8i Ib+bShnpBjlqZkEMDlyfFhE2Kh2xyEU= X-Received: by 2002:a63:ef05:: with SMTP id u5mr43563817pgh.177.1552539337152; Wed, 13 Mar 2019 21:55:37 -0700 (PDT) Received: from localhost.localdomain (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id d9sm16185027pgq.6.2019.03.13.21.55.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 21:55:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 13 Mar 2019 21:55:19 -0700 Message-Id: <20190314045526.13342-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190314045526.13342-1-richard.henderson@linaro.org> References: <20190314045526.13342-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Use a better interface for random numbers than rand, plus some useless floating point arithmetic. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is no need for deterministic results for this interface. --- ui/vnc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.17.1 Reviewed-by: Gerd Hoffmann diff --git a/ui/vnc.c b/ui/vnc.c index 1871422e1d..9fa586dfa0 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -43,6 +43,7 @@ #include "crypto/hash.h" #include "crypto/tlscredsanon.h" #include "crypto/tlscredsx509.h" +#include "crypto/random.h" #include "qom/object_interfaces.h" #include "qemu/cutils.h" #include "io/dns-resolver.h" @@ -2537,12 +2538,7 @@ void start_client_init(VncState *vs) static void make_challenge(VncState *vs) { - int i; - - srand(time(NULL)+getpid()+getpid()*987654+rand()); - - for (i = 0 ; i < sizeof(vs->challenge) ; i++) - vs->challenge[i] = (int) (256.0*rand()/(RAND_MAX+1.0)); + qcrypto_random_bytes(vs->challenge, sizeof(vs->challenge), &error_fatal); } static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)