From patchwork Thu Mar 14 04:55:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160296 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp15079378jad; Wed, 13 Mar 2019 22:07:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTk+Y/YvnV1sThUWD4oip1kmnMeo1Uo6Wv/Qhc4PEgpgPsdV7E5ZOvmPjA1KgmAOCJe5WQ X-Received: by 2002:a81:65c2:: with SMTP id z185mr37198787ywb.430.1552540027984; Wed, 13 Mar 2019 22:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552540027; cv=none; d=google.com; s=arc-20160816; b=zWFbUAqegy4LB5cJZISeLbx/PpZG1x5yzG9JmssOH1Hfjl7DNmBYR4OfDfqJ+m1N9i Wn+PmJAb8grFAOFnxonIr3Brfgyby3vZnyQS8Vs/Mq7+NSPlxklwZbbZGgLY3Bj02Yox N1cM8XMcBCK3Q+DokOt0wcF4MwjK80hM9F36VMZWFGz3ke03FwkwrM/NXgf70UEyzBys WxcKNWWWxX8SLccUznFcAeBzXkNnyCh75i7FAiiUepOIIiGy737XM7a7uwXGnDpRMRRU +eKMWLMVEHS4NqkfifapXT72YTr7xadFQcqq3zMZ6vf3U2ndrEGxOEcdQe1hfVECfp2L xVpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=gqAwyLmZC+r281Bx+Ixa5zHetQPvXenm/6ftztHIm1Y=; b=U9dd5xyts2H5U9yJCtlFmJAMKGReUk91jMFpYlMivOInyq1kZGX1XfaAiWY8Vfio1G f/jCZTN7tGuMl/P2X9wRrn59HoIVOAWWu3FZKdkketFvr2TtmdicMCy5+/x2Zb9XL1cb ucn+MGzFmOJLT+7+SkvXaj9kwGq0fRGgHVkszyWGpOFcADGsfxG+v8NHZhgB8WJ5F4DH jMwll+Spfw75T76F3aMIZXU6Fpkei8J7/CfBJAZ7zZcJT4uz5Fe2mTli51YvFw0AMTn8 JBRndhCEZNA7f/xYvD4bCAw8doQsQ6yIm1LUeX+65HsE6mFZecZSsJo8jW5SsjmdZsOV HkuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sXHw1scq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s189si8006518ywe.132.2019.03.13.22.07.07 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 13 Mar 2019 22:07:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sXHw1scq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:57000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4IaB-0004ZG-CQ for patch@linaro.org; Thu, 14 Mar 2019 01:07:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4IP9-0004Yr-Re for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4IP8-0007Qc-HL for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:43 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:34719) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4IP8-0007Q6-7n for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:42 -0400 Received: by mail-pf1-x442.google.com with SMTP id v64so3017716pfb.1 for ; Wed, 13 Mar 2019 21:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gqAwyLmZC+r281Bx+Ixa5zHetQPvXenm/6ftztHIm1Y=; b=sXHw1scqL7CUZNZV1rqroSCFf1Sx7Bsx8zwGvUXl0FjRYv55YIEq7jqFxANqR+Q6pK +xymAI/7SZsGEWWVbI6Baqp6LiTvy/VdjoAzR+A3kWNKxyJq7vtI2Se3VrhN72id/J3u I9LPQoTwTh1LCQZkfN+qYial2jqe8g4V6TKSrnqF7KREawYtV7hhqkX0b/ah3fpnXePw HoU5PNBTIk4EitSLmb5GlBtqPbzTTec54164ey6K0Mm+4i4ENGTcwVutWwSlOpjyUige 4HnQykDqLFdIi1ZHp+YY11Pu1xTGTfd70v0D0iaU78UFZEB5i/HixDipcd7xH9RIusTK Ibgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gqAwyLmZC+r281Bx+Ixa5zHetQPvXenm/6ftztHIm1Y=; b=tuxDkEYJS3yWSkfx8bKygf1ZTMcVQGpYDu0aKg/wCiLWNXd7PxY6MhvX9q2nAlwAcU CT+vfee6lK63a6zfbrpjhDVERnscGerEr4ql8yyGtwLrxhgzZj/Rdz9vHboeco/WtqiT IpSQl+zfukcnIjAxVuvgUGlNGUX8LvpX/xd6e6FP89xNntlcI6Oag3+bH0ZzkWma+2yX wjaU3+Ar366OeqdObJWdqjU/P44XoxLFzCO8vP1v8VJ0XwrxqIDdlPulEIiZ7rsYgseb r2UMNwPPMdvSQ3692QSUDlVNuZqDufpJrSC3zH9Oot6xgf9KfRjhoUhldF/d/G3pe1v0 VOEg== X-Gm-Message-State: APjAAAXQaiAhHjkEklPNKE2SRbw2NMSc6bpk3L8AzmZsKe1NgHWrlYt0 WC2YKQgp0QJYoPkj0IRTyutaJ+4f1Lk= X-Received: by 2002:a65:5cc7:: with SMTP id b7mr43655937pgt.396.1552539336134; Wed, 13 Mar 2019 21:55:36 -0700 (PDT) Received: from localhost.localdomain (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id d9sm16185027pgq.6.2019.03.13.21.55.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 21:55:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 13 Mar 2019 21:55:18 -0700 Message-Id: <20190314045526.13342-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190314045526.13342-1-richard.henderson@linaro.org> References: <20190314045526.13342-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 Subject: [Qemu-devel] [PATCH v2 06/14] crypto: Change the qcrypto_random_bytes buffer type to void* X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- include/crypto/random.h | 2 +- crypto/random-gcrypt.c | 2 +- crypto/random-gnutls.c | 2 +- crypto/random-platform.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) -- 2.17.1 Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé diff --git a/include/crypto/random.h b/include/crypto/random.h index 8764ca0562..fde592904e 100644 --- a/include/crypto/random.h +++ b/include/crypto/random.h @@ -34,7 +34,7 @@ * * Returns 0 on success, -1 on error */ -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp); diff --git a/crypto/random-gcrypt.c b/crypto/random-gcrypt.c index 9f1c9ee60e..7aea4ac81f 100644 --- a/crypto/random-gcrypt.c +++ b/crypto/random-gcrypt.c @@ -24,7 +24,7 @@ #include -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp G_GNUC_UNUSED) { diff --git a/crypto/random-gnutls.c b/crypto/random-gnutls.c index 445fd6a30b..ed6c9ca12f 100644 --- a/crypto/random-gnutls.c +++ b/crypto/random-gnutls.c @@ -26,7 +26,7 @@ #include #include -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp) { diff --git a/crypto/random-platform.c b/crypto/random-platform.c index bdaa8fbbfb..51c219701d 100644 --- a/crypto/random-platform.c +++ b/crypto/random-platform.c @@ -63,8 +63,8 @@ int qcrypto_random_init(Error **errp) return 0; } -int qcrypto_random_bytes(uint8_t *buf G_GNUC_UNUSED, - size_t buflen G_GNUC_UNUSED, +int qcrypto_random_bytes(void *buf, + size_t buflen, Error **errp) { #ifdef _WIN32