| Message ID | 20190314045526.13342-7-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add qemu_getrandom and ARMv8.5-RNG | expand |
On Wed, Mar 13, 2019 at 09:55:18PM -0700, Richard Henderson wrote: > Using uint8_t* merely requires useless casts for use with > other types to be filled with randomness. > > Cc: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > include/crypto/random.h | 2 +- > crypto/random-gcrypt.c | 2 +- > crypto/random-gnutls.c | 2 +- > crypto/random-platform.c | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 3/14/19 5:55 AM, Richard Henderson wrote: > Using uint8_t* merely requires useless casts for use with > other types to be filled with randomness. > > Cc: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > include/crypto/random.h | 2 +- > crypto/random-gcrypt.c | 2 +- > crypto/random-gnutls.c | 2 +- > crypto/random-platform.c | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/crypto/random.h b/include/crypto/random.h > index 8764ca0562..fde592904e 100644 > --- a/include/crypto/random.h > +++ b/include/crypto/random.h > @@ -34,7 +34,7 @@ > * > * Returns 0 on success, -1 on error > */ > -int qcrypto_random_bytes(uint8_t *buf, > +int qcrypto_random_bytes(void *buf, > size_t buflen, > Error **errp); > > diff --git a/crypto/random-gcrypt.c b/crypto/random-gcrypt.c > index 9f1c9ee60e..7aea4ac81f 100644 > --- a/crypto/random-gcrypt.c > +++ b/crypto/random-gcrypt.c > @@ -24,7 +24,7 @@ > > #include <gcrypt.h> > > -int qcrypto_random_bytes(uint8_t *buf, > +int qcrypto_random_bytes(void *buf, > size_t buflen, > Error **errp G_GNUC_UNUSED) > { > diff --git a/crypto/random-gnutls.c b/crypto/random-gnutls.c > index 445fd6a30b..ed6c9ca12f 100644 > --- a/crypto/random-gnutls.c > +++ b/crypto/random-gnutls.c > @@ -26,7 +26,7 @@ > #include <gnutls/gnutls.h> > #include <gnutls/crypto.h> > > -int qcrypto_random_bytes(uint8_t *buf, > +int qcrypto_random_bytes(void *buf, > size_t buflen, > Error **errp) > { > diff --git a/crypto/random-platform.c b/crypto/random-platform.c > index bdaa8fbbfb..51c219701d 100644 > --- a/crypto/random-platform.c > +++ b/crypto/random-platform.c > @@ -63,8 +63,8 @@ int qcrypto_random_init(Error **errp) > return 0; > } > > -int qcrypto_random_bytes(uint8_t *buf G_GNUC_UNUSED, > - size_t buflen G_GNUC_UNUSED, > +int qcrypto_random_bytes(void *buf, > + size_t buflen, > Error **errp) > { > #ifdef _WIN32 >
diff --git a/include/crypto/random.h b/include/crypto/random.h index 8764ca0562..fde592904e 100644 --- a/include/crypto/random.h +++ b/include/crypto/random.h @@ -34,7 +34,7 @@ * * Returns 0 on success, -1 on error */ -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp); diff --git a/crypto/random-gcrypt.c b/crypto/random-gcrypt.c index 9f1c9ee60e..7aea4ac81f 100644 --- a/crypto/random-gcrypt.c +++ b/crypto/random-gcrypt.c @@ -24,7 +24,7 @@ #include <gcrypt.h> -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp G_GNUC_UNUSED) { diff --git a/crypto/random-gnutls.c b/crypto/random-gnutls.c index 445fd6a30b..ed6c9ca12f 100644 --- a/crypto/random-gnutls.c +++ b/crypto/random-gnutls.c @@ -26,7 +26,7 @@ #include <gnutls/gnutls.h> #include <gnutls/crypto.h> -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp) { diff --git a/crypto/random-platform.c b/crypto/random-platform.c index bdaa8fbbfb..51c219701d 100644 --- a/crypto/random-platform.c +++ b/crypto/random-platform.c @@ -63,8 +63,8 @@ int qcrypto_random_init(Error **errp) return 0; } -int qcrypto_random_bytes(uint8_t *buf G_GNUC_UNUSED, - size_t buflen G_GNUC_UNUSED, +int qcrypto_random_bytes(void *buf, + size_t buflen, Error **errp) { #ifdef _WIN32
Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Cc: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- include/crypto/random.h | 2 +- crypto/random-gcrypt.c | 2 +- crypto/random-gnutls.c | 2 +- crypto/random-platform.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) -- 2.17.1