From patchwork Tue Mar 12 16:18:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160121 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp13303446jad; Tue, 12 Mar 2019 09:28:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuHNLjPWUH9/UnY4f1db6NJbfysxxk+2knVk1JnWy/iXmdOE1tZHfEJkllaQAxcy2ZimGI X-Received: by 2002:a0d:eb09:: with SMTP id u9mr10463613ywe.91.1552408123297; Tue, 12 Mar 2019 09:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552408123; cv=none; d=google.com; s=arc-20160816; b=QqSxX9LLj5DYmQ1ANTJgrQyxzgwNquCSznK15+aqn8PTj5NPWviMVaaUU3Vxq7dOBd mIdIGm8kEXHrw//ukWirqOHOb7jnie+GLWtSbWtdoDgbl0hg+Ez1mx7AgzhqqmzDAFWo VnGh8RlV3UKoggwXTTz8F2EU329M7GZzNdQuW3fO0MDR/AnY63q1bviRbUYZJp/6O01W d2+/PzzvounlDKPjjLjr/gcYNnKJh6qn/KYU9ry9TREb0jAOT1DolZ1qHPy1QZDw88gr smtGFORkELDta/or5c9zfYYN9GNQGcS0VeY4vFSlYY2H2a+fiCU2lEGU2yVttSnKFogv 87qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=gvBn1oFPxdecBnMqY3F27gHaqyuY4YgyVT6y3G8ypTI=; b=RJ5UMIzazKMSwR+HquguPlMa3W90aVeVc9Mbuy/jFg/d1q0PVWx10FdcRWHJlTeB7J hbAraGbtAHm/oamuEFp6DzD2UCJ+8xPyLK59V+6r5nwssxnWTM1w1I89WMCT8r5NYqR2 rRQH305COB4GE6YNY2F9o/NVfUMizzeaubvJ0en11ZCt6VgWrp7qanwPUPjTUYPKyTlF 4+J6CDaSxTD7nP/RJPsWH54ExOCTNtM5TJtrnOSW0P77FQZhy0xyhfhbAisMdWcqHTsE kHd8ssb7PzAhFWXja45kBMyX7xhS1LlZQpzN1GWRhi1VpzzSdruB1j0U4SIiBAautXx+ MmFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fFy1wfXh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y128si443293ywe.25.2019.03.12.09.28.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 12 Mar 2019 09:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fFy1wfXh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:55367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3kGg-00054e-N0 for patch@linaro.org; Tue, 12 Mar 2019 12:28:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3k7j-00065W-3Y for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3k7c-0003wL-Gh for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:22 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:36443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3k7Z-0003tg-Af for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:18 -0400 Received: by mail-pg1-x536.google.com with SMTP id r124so2208409pgr.3 for ; Tue, 12 Mar 2019 09:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gvBn1oFPxdecBnMqY3F27gHaqyuY4YgyVT6y3G8ypTI=; b=fFy1wfXhyoWw7W52QA6TPx4crVYh240x0M4+CLHA2leMUu/bMHPb9Qvy/F8X2IUNo+ UQY/klEIVl3I6HyzIksaSBqqpXLkilR0WDXxpCO053nVQPM1T4ZPXeDfkqmKNqGjNNIP ks5XrDcUhSRX+fk+/LcIbksR/X7SbNMwHKLrySnQeajJ5NAh+iMPR4mYZwCv9v4kmLTe TSwUZYMnRwnu31VUkjN5Cywd16lrzHKD8s9ZRGVDFC3NzxaBsNfHC7EH1hvmbYuW6gVR BcnN3waF1yaT0XdKls0U5z7iizEWD64fOenRXH4t6Tks97m0mEcpV64MkP6BhMuVY/7/ 0tBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gvBn1oFPxdecBnMqY3F27gHaqyuY4YgyVT6y3G8ypTI=; b=h2c1Vne9JRUpMauNKo61tSNARpstEaKaBX3UrgTedvaD3XT1iKU+3NVwm67fUBYdaJ tiYRaDn0sZwPCAgjTIoANEZElfmtCcRqd9N2AaTmDARpcQuuluwU5LWGUPh2B55iImzj j5qSU5ev6hy2/3EFdoo+G8p7FuqqsCDvUTUwx9k/kPB4wrChoJIQMbOm46yB5DLhZ6Od nl1ByEsfNmdeBP8rh3S1b6JjDFbwIjoM6UndVpkln7vn54fxKKflCUK0Sj5F8Tn8R9/G BCS0KhqpqZ7SsqiNJtwbqHiWHvSD4NQyyAW7ti6PhlYl6OAHSf+e1VrYu0Pk25IvJdtR ZN1g== X-Gm-Message-State: APjAAAVQpWJtiG6UbR77MsNqAmGrcrfo5Op8sM6KN/6ozWepyq3CQM4v yJPRMLYj0NqB1Q1Db2hq6UH9yB2tndU= X-Received: by 2002:a17:902:1008:: with SMTP id b8mr39441673pla.120.1552407555927; Tue, 12 Mar 2019 09:19:15 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id q62sm12605644pga.32.2019.03.12.09.19.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 09:19:15 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 12 Mar 2019 09:18:59 -0700 Message-Id: <20190312161904.31130-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190312161904.31130-1-richard.henderson@linaro.org> References: <20190312161904.31130-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::536 Subject: [Qemu-devel] [PULL 06/11] target/hppa: remove PSW I/R/Q bit check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Sven Schnelle HP ODE use rfi to set the Q bit, and i don't see anything in the documentation that this is forbidden. So remove it. Signed-off-by: Sven Schnelle Message-Id: <20190311191602.25796-6-svens@stackframe.org> Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson --- target/hppa/op_helper.c | 5 ----- 1 file changed, 5 deletions(-) -- 2.17.2 diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index a05681d480..a55a5dfc02 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -678,11 +678,6 @@ target_ureg HELPER(swap_system_mask)(CPUHPPAState *env, target_ureg nsm) void HELPER(rfi)(CPUHPPAState *env) { - /* ??? On second reading this condition simply seems - to be undefined rather than a diagnosed trap. */ - if (env->psw & (PSW_I | PSW_R | PSW_Q)) { - helper_excp(env, EXCP_ILL); - } env->iasq_f = (uint64_t)env->cr[CR_IIASQ] << 32; env->iasq_b = (uint64_t)env->cr_back[0] << 32; env->iaoq_f = env->cr[CR_IIAOQ];