From patchwork Tue Mar 12 16:19:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160133 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp13330224jad; Tue, 12 Mar 2019 09:57:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqzk1uRZpXukeXroSqUd2eEra9eyno9cSiSk0qDYtTELgQTcp3Ohzx6rMK6phWZaImTKLr6x X-Received: by 2002:a81:5a06:: with SMTP id o6mr12722568ywb.8.1552409878352; Tue, 12 Mar 2019 09:57:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552409878; cv=none; d=google.com; s=arc-20160816; b=cb7oU+ZDFoZ/RFlYzILcQNOvFRuBHw7j6/HX3ue0KtGSmz/fq0YF8cA1d4QxeRr7gB ComVplxp537PKQL0trrZO9cZ/VdO0DeN/Qtr6fHmTTCrR2N5wwoQk2GC74okPa7K0Wk2 NqKjAbiabVPmiFc0Qr4AzUJcn+BD8L0yXxi/RCV/MjuSNKDOZsnMQH7pKZ7qixyWhDW2 84kzLdBCYS783/40NTKWkno8nr6XIDZalQzRQcJk1ugbeQck2rXwcRZiu4ODCnQTyWId e68PdW81xQLRUx6PZuWQIfaXz5oTgNB4AmAysbsqzpvtEKozqO38aOrd+0utLNwoyy95 0OZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=/OsS4tNr9ZMYHuULfhS05VN2vAKDB0y9il2P8ildqH4=; b=pFE4iByKbNRBhCRGsmN0OXnah1L2q1cXKen0uSvSRlQssG8BZ3dbrPcCO6xnl/fNV8 PLIulhmPvayDo6rvaiLc2q9dDgNKwRRqWJMDcAFXdY6VDKnDQ830J/nOtIWh6iogjMhh 1+Xq9hgknKfjXTKW2ApwJHfsjyG5HplCuvhwch3hq6UQW0MRoHq88BiJt79noOeEX5AW hixHUonqKWR1kxClRD5TlPX6i74qrRowvi5wXHdqPLH27wr+fg1ifdqA7yY3cwfe1Q76 Lj6hCqTFxKE2rdJsO3g8RMDdhjZRzjnnYtrAT4Bh7MbVD8y2x0itVrOqkKG5h2NZLtAl LPSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=X3jcs08s; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v2si5478829ybj.483.2019.03.12.09.57.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 12 Mar 2019 09:57:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=X3jcs08s; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:55883 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3kiz-0005XD-SI for patch@linaro.org; Tue, 12 Mar 2019 12:57:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3k7o-000688-Pk for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3k7j-00042O-6X for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:29 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:34659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3k7f-0003wM-HD for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:25 -0400 Received: by mail-pg1-x529.google.com with SMTP id v12so2217408pgq.1 for ; Tue, 12 Mar 2019 09:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/OsS4tNr9ZMYHuULfhS05VN2vAKDB0y9il2P8ildqH4=; b=X3jcs08ssxuO0LyA4oUCkzdV5D278FsIVE4Ws7UNEoB79vDTtMYu7y9oc1eNQ8RdcU vu32yFS9DiPFdRsd9aEfQ/Mc/6pczrvxdllde9GdkX+SNBX7y3/6gooloqh7Uj0LrXwG BwyKonD/brb/lirRlwDgjUlp2XhY8RbgUMoOkx2M6jJuH3R+rjia27KuPDlX0UtIHJ/o akTiL03Rbwo/Sbcngc6HwulRs1FMxfEcPW/M8jaXKf4CWCKl1HQPxe2hq3Cu690L7ZTR MZOY1fI4SGaJEIpaDXCpu8u4JOsZfjVrt8oZeG2TRkW4+V8K4y14PRnxjp66Rn2q9r7L RuUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/OsS4tNr9ZMYHuULfhS05VN2vAKDB0y9il2P8ildqH4=; b=XAcWO/qmTczutqau3XQabsicIW6vNDYIotA3j4Egknb5DaGAf+dob6uhr0H4eLcmtk vo/9unGvX5hzWDCsAdNsnnnM5hnvgsDZG4GFfyHHmzx2DNj+P83Wfsxxa8oUt0eMFxyR fTQjPuh9nFJRUQH/B9WEjtoOX9c9dYRiqMNSzI3Aoe5b3Qe5bTSQMHtqCP1MCqMJk1I8 n4AmSpFnyMZy9H6hgOjRcdTb5rqYkCd1yWtS7BBV4KsHLFzdSXEiVuIiWV+WPMYxrfpV EUHYEH51YAJm8dR3IW5BsSb3xdRKjD1hv+fMfURUAnKeZpSNiM6Ux3vVmyOg5bYW6Oay gITA== X-Gm-Message-State: APjAAAXMikJ3qpwMOYCq9EAjrnhe2Hw35X8HL6AZE2NtD5h074MUg2vC kYJLpikCho/hFP3tDzfDIBra/8h/fCo= X-Received: by 2002:a63:29c3:: with SMTP id p186mr36124528pgp.24.1552407559626; Tue, 12 Mar 2019 09:19:19 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id q62sm12605644pga.32.2019.03.12.09.19.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 09:19:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 12 Mar 2019 09:19:02 -0700 Message-Id: <20190312161904.31130-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190312161904.31130-1-richard.henderson@linaro.org> References: <20190312161904.31130-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::529 Subject: [Qemu-devel] [PULL 09/11] target/hppa: allow multiple itlbp without itlba X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Sven Schnelle The ODE software calls itlbp on existing TLB entries without calling itlba first, so this seems to be valid. Signed-off-by: Sven Schnelle Message-Id: <20190311191602.25796-9-svens@stackframe.org> Signed-off-by: Richard Henderson --- target/hppa/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.2 diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index d32ae6e7d9..a69cca9c5d 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -278,7 +278,7 @@ void HELPER(itlbp)(CPUHPPAState *env, target_ulong addr, target_ureg reg) { hppa_tlb_entry *ent = hppa_find_tlb(env, addr); - if (unlikely(ent == NULL || ent->entry_valid)) { + if (unlikely(ent == NULL)) { qemu_log_mask(LOG_GUEST_ERROR, "ITLBP not following ITLBA\n"); return; }