From patchwork Tue Feb 26 14:12:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 159213 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp3275014jad; Tue, 26 Feb 2019 06:24:29 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibzt72VtqmCnKNYiTxU5A3Ps+IhMAmoCjUJwXZ/afV90mtTf4PIUKI7qhbB+yyqQVLhxIBk X-Received: by 2002:a25:2552:: with SMTP id l79mr12317017ybl.299.1551191069751; Tue, 26 Feb 2019 06:24:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551191069; cv=none; d=google.com; s=arc-20160816; b=m7RHOT19raD4qvHDnE8bKIBGilBOEGZ9lzxlPEKe63uMopVDyF3EOfjj3KGPiS+caB wWn5oYjVYwOzkIsfrm1ihoA/bK9EMIO2ZJpjnelE4NqxrnLWmVYer2KonaD02aI9eUBF AWAvMZT5VSRm1PqjOXAjxGWbr3AtTgMJ1WvF2m2+nnzPvtabPuH4yBwVE9D/speyHMi7 vU7Ofb719k5r40PIdz10v4HalpXy0LzwNQqV9eDJpMWOtyA3c43EdBtInGG0ng7RHLmQ lWjDDAyXuTpPX102hYBvOEe68cH9Ycz+ji1p/FaLk4kJAOni5Bm/9g+KbHlwV0UWrBYb jB8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=qe2kZXq7+BsdpDpRE+R5guw1kKnFhbyMtqHGKOaBfBY=; b=KMwQjfzH8o5c+SP8kt5NOcQL0ZrImtxdTq6ZcmNv2SZ/g+8rEkiNn77s/nZ61YiNEP DDmpo8Yij5ClBBkGaRxfp8uTI5lvutzTrXhR1iWeK84ZR4BJe+zPelerZmx9As5y6dn4 8JNd+bO2sTMu8y30ifnI0b8iiXXFDTWUa2cPwmm0tDMdNeXw8z54/LmKjiYh4o79Cu3U 0Ghw4kJIsl3qjPAjxNXZedZk6idU0VBGb1sq/wazgw7kxbTpmkWFXkBmKlsSOrXcdI1P hOX4llb1S8VZ+Je7XAhYuaS3gEAN9wx+I6IXe49nLATGTUztgMVIA7qlJhUapnKkZOaZ 2pRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CR8iK4V+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t6si6618113ybl.365.2019.02.26.06.24.29 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 26 Feb 2019 06:24:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CR8iK4V+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([127.0.0.1]:56270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyden-0000G5-90 for patch@linaro.org; Tue, 26 Feb 2019 09:24:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gydSu-0008C4-8n for qemu-devel@nongnu.org; Tue, 26 Feb 2019 09:12:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gydSt-0003Rc-B0 for qemu-devel@nongnu.org; Tue, 26 Feb 2019 09:12:12 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:52641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gydSt-0003QP-4c for qemu-devel@nongnu.org; Tue, 26 Feb 2019 09:12:11 -0500 Received: by mail-wm1-x336.google.com with SMTP id m1so2569861wml.2 for ; Tue, 26 Feb 2019 06:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qe2kZXq7+BsdpDpRE+R5guw1kKnFhbyMtqHGKOaBfBY=; b=CR8iK4V+6rf827+nBuXIMQwwXMUieTytFT/nlp4ekVFx+RuXZfY5CFc5IqpV64terz A5Y3AySLvvQ7lt0EFMDjbVg/yBc/cLGz5fLmak5oqGZ2ksth1JcRl4yrL8290/a+nqFF ILDsPvm9559hftotD5/Gxthv01xGBGzu1Gfwke3gN85Ty/PyhW3OVsJ+kCEio95wIuCj Imud/fir//LyGJQ9bWhwlp5f4/Krjf9GFOxKP37v5/2HZwqwpZIn4apfDvvIdgos5A8c 7lSuJaKuNhL4OQtfrYALCV67fg+bl7uiEEWt4fK05JYu2pQQS4Qsr57tW4oeZ79UJ8+y Iigg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qe2kZXq7+BsdpDpRE+R5guw1kKnFhbyMtqHGKOaBfBY=; b=uE0N5iPAXd1gZYlK4+JbE8nrvj7jKetBkI3k+eejknzmml47VFxHDqm7BvdD7O1wDb m485uzD5iwtjcAcT+7sQMYOjj9CEf8n7uF4JHQmQoiQOJIEgnd/lZEiOJ2IT+R1jqH0G YxqwH9Ee2irwA8FIUTRBTpADJyuIEi153EmleEGHxrYqa75A8I6nFZZ7TNalzhdlJxqR lP3tYkJEyvUZEFpdOS0u9sqEjmT96qx/cjb2f7+0KqG12fB1yTP++1AcdFB+5Chr/hDq fBJRM93iYZJg+ZBNOV7SyAmvRtpvUsizAOXaOPgxFDmu3jsNLjXUjQ0z0KYy9dpPuVbD 1SCQ== X-Gm-Message-State: AHQUAubRMbd83JiXRzuyBQYV7E4D1u7sH7QRv6+tLc0mD98lkjdvq+EM Lpbn7wmOeHo4ruaP13dpVjN7OA== X-Received: by 2002:a1c:8088:: with SMTP id b130mr2739730wmd.96.1551190330080; Tue, 26 Feb 2019 06:12:10 -0800 (PST) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id n3sm10594689wrs.10.2019.02.26.06.12.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Feb 2019 06:12:07 -0800 (PST) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2E5111FF8A; Tue, 26 Feb 2019 14:12:02 +0000 (UTC) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Tue, 26 Feb 2019 14:12:01 +0000 Message-Id: <20190226141201.16999-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190226141201.16999-1-alex.bennee@linaro.org> References: <20190226141201.16999-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::336 Subject: [Qemu-devel] [PULL 7/7] tests/Makefile.include: test all rounding modes of softfloat X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-devel@nongnu.org, david@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We missed a bug in a recent patch as we were not testing all the rounding modes for all operations. However enabling all rounding modes for mulAdd does slow down the already slowest test and doesn't really buy us much additional coverage so lets allow the default test flags to be overridden. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson -- 2.20.1 diff --git a/tests/Makefile.include b/tests/Makefile.include index 060f765b0e..f260014f02 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -898,12 +898,12 @@ $(FP_TEST_BIN): # The full test suite can take a bit of time, default to a quick run # "-l 2 -r all" can take more than a day for some operations and is best # run manually -FP_TL=-l 1 +FP_TL=-l 1 -r all -# $1 = tests, $2 = description +# $1 = tests, $2 = description, $3 = test flags test-softfloat = $(call quiet-command, \ cd $(BUILD_DIR)/tests/fp && \ - ./fp-test -s $(FP_TL) $1 > $2.out 2>&1 || \ + ./fp-test -s $(if $3,$3,$(FP_TL)) $1 > $2.out 2>&1 || \ (cat $2.out && exit 1;), \ "FLOAT TEST", $2) @@ -984,7 +984,7 @@ check-softfloat-compare: $(SF_COMPARE_RULES) check-softfloat-mulAdd: $(FP_TEST_BIN) $(call test-softfloat, \ f16_mulAdd f32_mulAdd f64_mulAdd f128_mulAdd, \ - mulAdd) + mulAdd,-l 1) # FIXME: extF80_rem (broken) check-softfloat-rem: $(FP_TEST_BIN)