From patchwork Fri Feb 15 10:00:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Cave-Ayland X-Patchwork-Id: 158495 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp526684jaa; Fri, 15 Feb 2019 02:16:15 -0800 (PST) X-Google-Smtp-Source: AHgI3IY2a8UQoB/dd6HvYB/KHI5+b175foLZRU1Isml1Lx3We6636+5C0zZkNklHwfAYVxm6JT6r X-Received: by 2002:a5b:784:: with SMTP id b4mr5964585ybq.89.1550225775864; Fri, 15 Feb 2019 02:16:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550225775; cv=none; d=google.com; s=arc-20160816; b=dotAkjVOERFey0wLdvAF0cMW+S0LjkvoXg84E3nUDgppQmTgEQWGitGZafMlyt9N9Q v4i3zpL8VZbjoYVXZCuuQv3IRlvwparlFq1hsCx+jYraa3ro4v1fUYNSeIELx3HNX/v0 5vilEtXv0knum+mW++uoJwpPcBLfmhTJNU6ggP9L5UcJGlBAaUm7RK8NfZgPUmP3Xnqn mpzhGLeqaZdhNJqNDLVn+qO5A3BBfAEfHiIo3KOcf7UESrLP9QUogpUCKtGwwaM1e4Kr iOaT/aiFR8mb3dTUeSLN3Bv5BNUyP2VK0xeS4UKq16AomAvHXSGY1Pj6gkAKQ6glgHkv K9XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from; bh=BGbaK22LAwQ+L5u4zVySnt66swECzQkb/QRpkJov6yw=; b=bM5r1VSj4ostT4dMxyneG3DmtUQlil7HGzXaRylsW7zmpUycQzhROTjXiEYecD97eq LvlysRdkRM+5MWxufSTyJMf2Xws2ZAYT7nVXRwvXCgLP4EwfWEq6qjOE2JYtRt3zejKl 8Bn03JnXg33OL6Gm7IpZlu+j4dxN0WP5N2FA6NpmHpQ8lscf8AGK8QX8y6zH6KJyT1Xo QoPQHnCy9JjAO4+RzRFd1nh8wcO6t/SqD14o+N6DcyzXl00JPTKfWJm6YgFO5Z7+hKRZ pp83EzcJkCoTOzA7IPjuT495pjdn59qFhwjbulv5HoEsMIeKQ9hbnieGhzDIhKdrETA/ Y1gA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k195si2878561ybk.422.2019.02.15.02.16.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 15 Feb 2019 02:16:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([127.0.0.1]:35971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guaXX-00083w-Cs for patch@linaro.org; Fri, 15 Feb 2019 05:16:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guaPb-0002tq-T8 for qemu-devel@nongnu.org; Fri, 15 Feb 2019 05:08:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1guaPW-0002HB-MM for qemu-devel@nongnu.org; Fri, 15 Feb 2019 05:08:03 -0500 Received: from chuckie.co.uk ([82.165.15.123]:38825 helo=s16892447.onlinehome-server.info) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1guaPW-0002Fb-Bw; Fri, 15 Feb 2019 05:07:58 -0500 Received: from host86-133-194-245.range86-133.btcentralplus.com ([86.133.194.245] helo=kentang.home) by s16892447.onlinehome-server.info with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1guaJa-00027S-Ns; Fri, 15 Feb 2019 10:01:51 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, richard.henderson@linaro.org Date: Fri, 15 Feb 2019 10:00:51 +0000 Message-Id: <20190215100058.20015-11-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190215100058.20015-1-mark.cave-ayland@ilande.co.uk> References: <20190215100058.20015-1-mark.cave-ayland@ilande.co.uk> X-SA-Exim-Connect-IP: 86.133.194.245 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000) X-SA-Exim-Scanned: Yes (on s16892447.onlinehome-server.info) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 82.165.15.123 Subject: [Qemu-devel] [PATCH 10/17] target/ppc: Use helper_mtvscr for reset and gdb X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Not setting flush_to_zero from gdb_set_avr_reg was a bug. Signed-off-by: Richard Henderson Acked-by: David Gibson --- target/ppc/translate_init.inc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.11.0 diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c index 59e0b86762..c8b2b760e5 100644 --- a/target/ppc/translate_init.inc.c +++ b/target/ppc/translate_init.inc.c @@ -601,10 +601,9 @@ static void spr_write_excp_vector(DisasContext *ctx, int sprn, int gprn) static inline void vscr_init(CPUPPCState *env, uint32_t val) { - env->vscr = val; /* Altivec always uses round-to-nearest */ set_float_rounding_mode(float_round_nearest_even, &env->vec_status); - set_flush_to_zero(vscr_nj, &env->vec_status); + helper_mtvscr(env, val); } #ifdef CONFIG_USER_ONLY @@ -9550,7 +9549,7 @@ static int gdb_set_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n) } if (n == 32) { ppc_maybe_bswap_register(env, mem_buf, 4); - env->vscr = ldl_p(mem_buf); + helper_mtvscr(env, ldl_p(mem_buf)); return 4; } if (n == 33) {