From patchwork Tue Feb 12 04:57:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 158086 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3423365jaa; Mon, 11 Feb 2019 21:15:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IZpJCTVpU/teAZRr8xYQWQoKgyunxIK27whDjlhFgbcR7IIqQDaY/vYNGH+rTTJ+ruq6SsW X-Received: by 2002:a81:4520:: with SMTP id s32mr1422874ywa.7.1549948500735; Mon, 11 Feb 2019 21:15:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549948500; cv=none; d=google.com; s=arc-20160816; b=rT1HzO47wP0LcwU3+Znpxp1sb6xZpZVGuDHAkSIlW2NA2HkmUr83JtSghdzU5jLng/ tAVZRDzg/bHLAoqPn11qpWW6Y97pin6cYWUDoLhhrJM3VMOQpkP5KhJmpdttUE6qmvwT UJxAdIU0sRIaw8ls106Ojj0QAbV21QQeyV2AT/zfZlFt49/t0CebZ25Z5Vi6r2MrHluw g46j/uXyIu/So8R+MXDwCOlSiMyTL7sLdGBnAWnOm/iMy6yBcWp+hxUSk16KD52fNmGR yT3nO7w7Gml6YKChILniJvp0bDZ8cd4cswoY+R1jcaCVwhpF2WOgVzv9d8T0XJY+Gwp8 bMpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=LQx4iIAd57ZETj1BkBplWIuFkn9BqTCpgRS1QGdjw0M=; b=O8qX/6uFfSG3ECHe833z5cA3bsdO56TNx5a4Q6M4flyBey2nXGiJRKc2g7S3L3z2i0 DfB8oS5JfHmZXa9IjNMqQvrCFHMvKbqQRcmZFMtPe35WjQDfH197JXn6xT7sccZA6fq4 P70U/tZ+iP3Oa2cqKwV+0H+QKXAQqcAjbkM/9J1aRsZjPj+3Huy4WntXWySRYZIT3Zwp JvM+vSxs7TIBru8GSB4LhG4izMJUesCLGg7P9sJQsdsT3fVTQvaNy2wPFt//llENOmMb 3UX8+qe3VjWV5eDK2lnlj3qar/HbA2y6ZWAtyV+3pYF2oLqCUYr1VdWlsVrMyUYGvVZj 1F1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TaVx33DA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b18si5992974yba.289.2019.02.11.21.15.00 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Feb 2019 21:15:00 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TaVx33DA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:33313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtQPM-0006z2-8e for patch@linaro.org; Tue, 12 Feb 2019 00:15:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtQ95-0002n1-A3 for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:58:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtQ8p-0001zk-Mi for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:58:04 -0500 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:43248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtQ8n-0001qc-Ac for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:57:55 -0500 Received: by mail-pg1-x52c.google.com with SMTP id v28so655006pgk.10 for ; Mon, 11 Feb 2019 20:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LQx4iIAd57ZETj1BkBplWIuFkn9BqTCpgRS1QGdjw0M=; b=TaVx33DAq22GZ+33AC7zBPAWoYks8NiIibGl5TuRBxbPWWECN398iBMyQnh7BJ7Ahb i/zhwqVpPV7lrWJC2Ml1hKlmE5y3hIq3OUDhHYFqh9sbdS/8bMWCzV7yIczv16mcR132 r+md4CbvLXQkfvF98mg7+dioGokZZwbPm5EyP53cCcWcLAvuFQkzTP45aegCI10lTXFJ jhKM+dbQygteG+0C/mhDhHAqMBI22fqfROv7Z2IDHmU2heL50MAzFEb4lpW6RqvAcBPr lQ4wkI/pJwUmeJrMfOFjfvPOtA5DOmFQLntgXeUDEHQvTZjM4AxvzLaB17ZdWYUpjCK0 xgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LQx4iIAd57ZETj1BkBplWIuFkn9BqTCpgRS1QGdjw0M=; b=ixeLT4JXg/TMnNcU8b5Ns+IJaoj9PWo2r61Yp7VAAMLTFUzNoJ85CPi1G1kPcL+amK o8EGduOLzoVececjGBIIhYMDAQc7lJP2T8D4AXPSalr3lJLuKGCSkwh2095GA/l7h/lq qY9GKf/cZ89iR7ZfYs0npM7pFfYca/dSHU0AVastTW898dzOlb394c8cc+M2VShGrsMI chJxnE/wRLq5n8JwgUBE+KCApju1h7P/NmMlYsWMbX3hYkTQf1EP4jFzG25nlVP7QffG tXQN0OBj+7DPrdQaQNx7AG6ziE8uxd3fq/HIwSABwXaUPxnK0XPtECJjyChHHMHImJjV yi4A== X-Gm-Message-State: AHQUAub8SZ7cHIDyaglQO2qx3gTWV26nd0G7b2/jVMZF6vQwouzu2BV2 7fsqjx1WkKr7xwdFKcXT6po6AgLYMME= X-Received: by 2002:a63:1b4b:: with SMTP id b11mr1928694pgm.10.1549947471810; Mon, 11 Feb 2019 20:57:51 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id a90sm22088923pfj.109.2019.02.11.20.57.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 20:57:51 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 11 Feb 2019 20:57:20 -0800 Message-Id: <20190212045721.28041-24-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190212045721.28041-1-richard.henderson@linaro.org> References: <20190212045721.28041-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52c Subject: [Qemu-devel] [PULL 23/24] target/hppa: fix dcor instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Sven Schnelle It looks like the operands where exchanged. HP bootrom tests the following sequence: 0x00000000f0004064: ldil L%-66666800,r7 0x00000000f0004068: addi 19f,r7,r7 0x00000000f000406c: addi -1,r0,rp 0x00000000f0004070: addi f,r0,r4 0x00000000f0004074: addi 1,r4,r5 0x00000000f0004078: dcor rp,r6 0x00000000f000407c: cmpb,<>,n r6,r7,0xf000411 This returned 0x66666661 instead of the expected 0x9999999f in QEMU. Signed-off-by: Sven Schnelle Message-Id: <20190211181907.2219-6-svens@stackframe.org> Signed-off-by: Richard Henderson --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.2 diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 026ba5cb3e..b4fd307b77 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -2744,7 +2744,7 @@ static bool do_dcor(DisasContext *ctx, arg_rr_cf *a, bool is_i) } tcg_gen_andi_reg(tmp, tmp, 0x11111111); tcg_gen_muli_reg(tmp, tmp, 6); - do_unit(ctx, a->t, tmp, load_gpr(ctx, a->r), a->cf, false, + do_unit(ctx, a->t, load_gpr(ctx, a->r), tmp, a->cf, false, is_i ? tcg_gen_add_reg : tcg_gen_sub_reg); return nullify_end(ctx); }