From patchwork Sat Feb 9 03:38:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 157907 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp240423jaa; Fri, 8 Feb 2019 19:44:44 -0800 (PST) X-Google-Smtp-Source: AHgI3IbrvBMZYlHXNt23qT7EAJ9w5S+D1K+51PxfjwALfU3grJo3U5BG9cQZwwldeeOy0APivkUK X-Received: by 2002:adf:f4d0:: with SMTP id h16mr5364075wrp.103.1549683884832; Fri, 08 Feb 2019 19:44:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549683884; cv=none; d=google.com; s=arc-20160816; b=K0hUFKMF5wB3ls7TqZOqSGhhmD7CpOHQ4qKh9nrOg0p+Qq69rVTtgDDriU9GLHpmle Z8XG8+sMgu6ZaME5AOSi17ma+2musMfI3vZSN9gPVsRT1GZQwZQEQ+vrRfuAdDWbCoJO v6mkzW3DMfES5ItBFeuk/a26rbUrlsxZyZcveA/WKdK/d2zsWNXjJXOImzWdoXzDgPEk kx44LQ75QkJ44y386Fa6jyKqivotJYM/GQYRekdigVD4YBr/GK8o3VutZ5y1/8LRIBQn QT+selXQAc6T01h+8IYaKQpNDIeCqr3Fl155gUkQT2SZyMOdIuqoAJf9pzFQyTgBKIX7 L1tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=smm0FHV8915qY07Dv9BtLFPbyAAqc9wK+rxK6VxHR+0=; b=KdgaaF64ZTlr3FFD5JIKwRjc9w6Lee+T1zYoYhK7od/lD1GGXjywyiInI7VEiHmvoo siCTQQrT2hOmrKgiG4rJm0hY3WRiYDNkNVRi1pOpR/IF+soxuTWpT6BVg6fHGv5B7STD VNBxjwstKTeWJgfmqpGtwMD7TMllkC7Z/FgDIJE13gbCqNXJKtle9Q51+NG/C9Nf6kyS bnZy1kDb13B9UT7lgsbEh3wACY1H0eL9Uirl5eHMdfhxUJKGFCugNFKxDADSFftm0TPQ wbT2mOU5SXQ/NfrbYiwwxB7KJfLwZALzrGUIhbBafqmulmAAwBkWWz8DGTiCBT+vGMnU loLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="A/PAtmne"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z22si2600314wmk.84.2019.02.08.19.44.44 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 08 Feb 2019 19:44:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="A/PAtmne"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:39100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsJZL-0001xF-PA for patch@linaro.org; Fri, 08 Feb 2019 22:44:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsJTz-0006uv-4E for qemu-devel@nongnu.org; Fri, 08 Feb 2019 22:39:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsJTs-0000Vg-ED for qemu-devel@nongnu.org; Fri, 08 Feb 2019 22:39:06 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:38674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsJTq-0000Uf-DF for qemu-devel@nongnu.org; Fri, 08 Feb 2019 22:39:03 -0500 Received: by mail-pf1-x443.google.com with SMTP id q1so2580848pfi.5 for ; Fri, 08 Feb 2019 19:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=smm0FHV8915qY07Dv9BtLFPbyAAqc9wK+rxK6VxHR+0=; b=A/PAtmne+yqlBtPRDH5fR8bxxaJusg5ZlTWvRMCW1kB7sArJpqGSP7sPDBAMeO1h+m c8kREu3FgBJOdl7hyU7uLqmX5SYXKq6IkrXg4khnUxA/8yiTU9HUV/a7ocWelmRWC07X 4rEeJrw2gWhkzKWtXcPaKBgl+eDJKi0Z5UqKex6uvtumfX5ZjfSQhhtkhx/WCLtyLI8p goEwP6jUMZACaAxV7w3H5liJLVqixEUqwEfwtXQcd8QAAJPYlMy2vloWc+BoPWXwWto8 5h2GqbhYl/8uq9Mp4pUybwR/e9ByyceKIhsJSPq5gmUD6EM+BR3C69aTrYPTjv4SFnXN mmVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=smm0FHV8915qY07Dv9BtLFPbyAAqc9wK+rxK6VxHR+0=; b=a6XkUh8ikCExxyyxecHJW/Jc6TYwRQdTBFsab9t5src9s2bj0Qq6YTVqx9IoFx794W p0IqBP6UuQA5hGr1yWgbhHB89RYt57a1SjIxE1U5LU3Qo1QgDu3J8cbPzkFibI7sigzS f/m0erUa0PL9s4QnpotXoYZlsxGO0ZER7mn4rSv/c0TdGG+JDsZ0AS8WlyRPMNJ2Jp5L JJTR3A5Lb4U9ZTvtGfYUdnTlhX0ZB7VQvgU1IsK/U+SkaAo9RWVeygBF7HM/SAHC1Mg+ 7EXQt8uMsc1V6PbwsxER4thkiD9Pp05buuAroCyzfDua5OoqpYwCRPKSVGvyz1gXYZpx KeMQ== X-Gm-Message-State: AHQUAuZpg6/QRDQ4fNiQOkuJVG06G7hjmLS+bf4yzXVDu3UotxODhbU7 Ww4HXmAFw5a2orO5kaiAiyEmfhqr5S0= X-Received: by 2002:a63:e545:: with SMTP id z5mr23968485pgj.195.1549683540818; Fri, 08 Feb 2019 19:39:00 -0800 (PST) Received: from cloudburst.twiddle.net (97-126-115-157.tukw.qwest.net. [97.126.115.157]) by smtp.gmail.com with ESMTPSA id s84sm6340737pfi.15.2019.02.08.19.38.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 19:39:00 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 8 Feb 2019 19:38:41 -0800 Message-Id: <20190209033847.9014-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190209033847.9014-1-richard.henderson@linaro.org> References: <20190209033847.9014-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH v3 06/12] target/arm: Fix vfp_gdb_get/set_reg vs FPSCR X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The components of this register is stored in several different locations. Signed-off-by: Richard Henderson --- target/arm/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.2 diff --git a/target/arm/helper.c b/target/arm/helper.c index 520ceea7a4..6ac81c2ca2 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -81,7 +81,7 @@ static int vfp_gdb_get_reg(CPUARMState *env, uint8_t *buf, int reg) } switch (reg - nregs) { case 0: stl_p(buf, env->vfp.xregs[ARM_VFP_FPSID]); return 4; - case 1: stl_p(buf, env->vfp.xregs[ARM_VFP_FPSCR]); return 4; + case 1: stl_p(buf, vfp_get_fpscr(env)); return 4; case 2: stl_p(buf, env->vfp.xregs[ARM_VFP_FPEXC]); return 4; } return 0; @@ -107,7 +107,7 @@ static int vfp_gdb_set_reg(CPUARMState *env, uint8_t *buf, int reg) } switch (reg - nregs) { case 0: env->vfp.xregs[ARM_VFP_FPSID] = ldl_p(buf); return 4; - case 1: env->vfp.xregs[ARM_VFP_FPSCR] = ldl_p(buf); return 4; + case 1: vfp_set_fpscr(env, ldl_p(buf)); return 4; case 2: env->vfp.xregs[ARM_VFP_FPEXC] = ldl_p(buf) & (1 << 30); return 4; } return 0;