From patchwork Mon Jan 28 17:54:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 156839 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3726484jaa; Mon, 28 Jan 2019 10:11:35 -0800 (PST) X-Google-Smtp-Source: ALg8bN5o+EWWb/XbPWD9Og+WJB35nkj+Y1R03/lZfB4QVO/wT+KdNATMFF1HWieJrjj27r1QeIiq X-Received: by 2002:adf:f211:: with SMTP id p17mr22543797wro.293.1548699094995; Mon, 28 Jan 2019 10:11:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548699094; cv=none; d=google.com; s=arc-20160816; b=AvJ1OWxlS8Cm6i2rZtlL97W33qFQpaVF8+w5EypTtJUgpFmZ5f/rKjEzg9wdV427ff TxkA6K7UyfBsZuyB6vxN8HWEWs2UGmBRsEUnN/Y3jJZRVUUcQ1Px2nPc2Lu95w8k7JP7 m7HYcWbE2bo2/LH9xPdOegYbyHN2TqdlR0X7vSXtpxeJ66J8aahFdjRW3C0RU8Sm5+iA WpvLOvOiAfzWrkUqTuYuvJhbbx/bU9QAWZUiu27t5+RE1D0cAFLUChh0O4a9uKab4J0Z ewvYfpg4UZijpTNWs+psKIBbGYE+CxfOcyvSlOfBu8VNDOMAG+pe8a8cQ8hC5Uni4xlf vbvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=svuzWVNFVxTePD7ae2vZHZ2knvcJaHejcIGBHx/4TyyuAWEOb8+oXSkD/ol9ZljYms vMsADMeWa9JXmthTHHZ4e5K3gu2mtoeV8Ee9mahXp68CdVlhpH+2m6dLe52KE13Cbk90 wwJp9hdsDtNhiBEbtiHPyMQx5HCt3ibNbpdPSEGlTYaSQDmfZvO0KW7Mr4LlYv8+vblG XLHfKBewGOoLP+7TdlBbXY1kU0734aD2pmP9txEdUg0Ht6m1WH9ft//cU/xhS3JcvVrA FGh71LpQUm2MrbV3ls4d3KC1dwz4ET7FM34HbY3fL8CXrwLK4O3HjdifAaOHHXTExA7r e6sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="TtA6V/Ma"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g7si75470wme.195.2019.01.28.10.11.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 28 Jan 2019 10:11:34 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="TtA6V/Ma"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([127.0.0.1]:36352 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goBNd-0002qs-Tr for patch@linaro.org; Mon, 28 Jan 2019 13:11:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goBEF-0003Zq-Sx for qemu-devel@nongnu.org; Mon, 28 Jan 2019 13:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goB7r-0005W0-EY for qemu-devel@nongnu.org; Mon, 28 Jan 2019 12:55:30 -0500 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]:43120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goB7r-0005UU-9D for qemu-devel@nongnu.org; Mon, 28 Jan 2019 12:55:15 -0500 Received: by mail-io1-xd41.google.com with SMTP id b23so14206132ios.10 for ; Mon, 28 Jan 2019 09:55:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=TtA6V/Mac4db4NB8K83uk1e61SvGKgMEUuivqYz658VsUUKqdFM/XxOhPJwupmbIFN Rcl5eRskTWzfs2DmQqEvZMadZvrrcQXecUxG2qynbJU9x19cmI//j779fwt1kFsoaJv9 2EbdgMT0kxhbp0H3F/wZbmxuJ0gWkwmrTK6Dix5a0HL9TONFeT+3bZFxh6eq54c+jG2M D/tKLYRIubMj6PL+Bfug7ftXwBD0/IMuS937ArsnZNonLXm/7iGyMxrKKj23dfhyudV6 S8edFeEGEevf8+Kl2/c3DoEh6yrJhc/v5Yd0d5HNoHd8lGMikIjyTuPm+aglAwJ2kiwN lYBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=RE7zfA1l011W+OYvUTARPprKuFrgp2gky/I4PYZ0mlUxQDlAZAghZh+We87tXkx77v xTERecKrecVCB+vh8gt/sh1vCN0lvmVKyKsdrD35WxD9dlS8Xws1XttdcLhjwHBWmDfC 5Iaci+DagRZLkxgA9y6hAm6Rkboe4YGabILvdk3FjBmdW35LnMeep25Ec+TEK9s/Xmji JJORP2z6BiGjz3we6oLY1DOAbQqyJ0lfLpYpPjO8AeGuChGQzFO2wb5qd15ebcCPy0cx MhNUnAMZ+lqoQU3JPaVuwzmrEBCNvx1tuelbeXsHThy9mcUvQlN+lIlQeZpjCEQYiYM2 pZjA== X-Gm-Message-State: AJcUukf8Ja3ZNLxW8QQc4uMc3DE5viRwYmiwDBuqCu63WCYhTK4qyKh9 iJgZ2ZlfxHj9ooyOWbSqxg== X-Received: by 2002:a6b:900b:: with SMTP id s11mr13359931iod.159.1548698112686; Mon, 28 Jan 2019 09:55:12 -0800 (PST) Received: from serve.minyard.net ([47.184.128.64]) by smtp.gmail.com with ESMTPSA id 193sm41954itl.19.2019.01.28.09.55.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 09:55:12 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id E573AB93; Mon, 28 Jan 2019 11:55:10 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id D209F30054B; Mon, 28 Jan 2019 11:55:07 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org, "Dr . David Alan Gilbert" Date: Mon, 28 Jan 2019 11:54:47 -0600 Message-Id: <20190128175458.27255-9-minyard@acm.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190128175458.27255-1-minyard@acm.org> References: <20190128175458.27255-1-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d41 Subject: [Qemu-devel] [PATCH v4 08/19] i2c:smbus_eeprom: Get rid of the quick command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paolo Bonzini , Corey Minyard , Corey Minyard , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard It's not necessary, it won't be called if it's NULL. Signed-off-by: Corey Minyard --- hw/i2c/smbus_eeprom.c | 8 -------- 1 file changed, 8 deletions(-) -- 2.17.1 diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index c2b9e3383e..4bc579e69e 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -36,13 +36,6 @@ typedef struct SMBusEEPROMDevice { uint8_t offset; } SMBusEEPROMDevice; -static void eeprom_quick_cmd(SMBusDevice *dev, uint8_t read) -{ -#ifdef DEBUG - printf("eeprom_quick_cmd: addr=0x%02x read=%d\n", dev->i2c.address, read); -#endif -} - static uint8_t eeprom_receive_byte(SMBusDevice *dev) { SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *) dev; @@ -95,7 +88,6 @@ static void smbus_eeprom_class_initfn(ObjectClass *klass, void *data) SMBusDeviceClass *sc = SMBUS_DEVICE_CLASS(klass); dc->realize = smbus_eeprom_realize; - sc->quick_cmd = eeprom_quick_cmd; sc->receive_byte = eeprom_receive_byte; sc->write_data = eeprom_write_data; dc->props = smbus_eeprom_properties;