From patchwork Wed Jan 16 20:23:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 155761 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1100328jaa; Wed, 16 Jan 2019 12:26:17 -0800 (PST) X-Google-Smtp-Source: ALg8bN5slFDqttHB3er/mW5xb+qbywX/kTDnB/Ni8AZxFsNpNAzoNrDvV8jksrpUnEXsSFolfcXt X-Received: by 2002:adf:9323:: with SMTP id 32mr8860065wro.213.1547670377502; Wed, 16 Jan 2019 12:26:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547670377; cv=none; d=google.com; s=arc-20160816; b=LHIM2rQDBOJ7wPYBo3IIbMOZYX+Fq5xTZHmObYJF/O5C1tGTIHn4lNxqKOZtzlnquU uKWFIz92rZmwjUtxmJ2kqYBU6gHzihjbwH//LIBjeLWlnyXvyyrUxJKUipJkH/36d0HD 6ckCzbUeNFW+MWvYf+nne2b9jBPVlxDAnlpEjWZ6t/5c+8hvYueoQHXozyNeuCCAbtdy OgmaoOglHb7BCEWvmA6pdtjB66yB/wv8aUC8KOrnMrOTlJ44vgyrst8cIuzxPVjw4oFh C3NXPkVcBeCPh7rGDlAQB4mG+IqbY0e2xl6h2btMx/8hMxWjLbrfO7ng8ZP0T0uK8Q0c IKCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=Sb4joxdWLCLO2hDCTg5yW7EpXhC4j4oCngYSkAwAnNZc8qOkeFECDsARBounYuDsEB pe/s63NPafdGgPqo+PCQhFlOS32Argt2lz2LpvBFMfWLuEKYbHh6P7CCPdAibr/YxE9y h/KjWxt7rbl+2J3yZw8hOZ7mwebMJxl5gx7853Ce7vJIZGlUGjIWXY/3J2EWj4fe1f90 9R0yHHOC2RGWjVi+SD8khY+TVpKc2vwIvVMI23jyCUbVA4KoWThQF0XLR5VKY/AMhkNY mz63rNCH3epwvwwothyT6D3oyAIj0V9MnHQKmPUaMqFlXtv+bBReXIzNEMVGJb8QhQEy Y9ZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ICMTDAm2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w1si23414817wmk.68.2019.01.16.12.26.17 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 16 Jan 2019 12:26:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ICMTDAm2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:45566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjrlQ-0007pn-Es for patch@linaro.org; Wed, 16 Jan 2019 15:26:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjrj8-0006tO-Bb for qemu-devel@nongnu.org; Wed, 16 Jan 2019 15:23:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjrj7-0005yI-BS for qemu-devel@nongnu.org; Wed, 16 Jan 2019 15:23:54 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:51851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gjrj6-0005li-DN for qemu-devel@nongnu.org; Wed, 16 Jan 2019 15:23:53 -0500 Received: by mail-wm1-x343.google.com with SMTP id b11so3461048wmj.1 for ; Wed, 16 Jan 2019 12:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=ICMTDAm2MYZElsEOd0ownrO3SpNz1ed+/j32/X7wENSRMAfuzvY6ZQN3ecpS9Ch3fp Vyt+UlP4ucv/adkJq22zQWCtuWgQbBTbYu1pTqSpx6/Ukjo0u9hb05ySd6vZdMd6hov6 fkklox1wALq0Ce8KpDM9yGpyh4m+rcv1TLoFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=n9onb6feOq8CFslHV7icXyZieAt5HoTwM+rB9WgRO5ZFRitry4UmwhYKC1yMXI1tSW T/ubjTF17qzTqX1uJRRmLIiszvgo6dPuEVg9xtShr5OTNadoAtbeZVIukG1yU+cYYZV9 d30OyaZmaSZT0XcLY8FhEtNCEnINVBJrD/1lRoQfGVG5pjx5v2PlBviBTaHsqvEUuXeA klrLkah+Je9pHmMldSiLRSihVuxBN7mfNypKO6mn3qiaUXRkm4pvT96npt7kzBEh4Jrm D2CCBxwnZqaUAYo4GMAVxjV2nnRTmZM2CTi+fXVrj6qa3e+DP2JfAvBhB7apJ7XB705r V69g== X-Gm-Message-State: AJcUukftLWO8WYAlDYeYhz35R3Lx0EsZQkUTd/rJhzn81QMLYZagZZGS vf0wYFUq13B/sP5PNeQzUDLM1Q== X-Received: by 2002:a1c:7c07:: with SMTP id x7mr9062655wmc.82.1547670231083; Wed, 16 Jan 2019 12:23:51 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id s8sm93817298wrn.44.2019.01.16.12.23.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 12:23:50 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 8EAD43E0F3C; Wed, 16 Jan 2019 20:23:49 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 16 Jan 2019 20:23:44 +0000 Message-Id: <20190116202349.29272-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190116202349.29272-1-alex.bennee@linaro.org> References: <20190116202349.29272-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v2 2/7] fp-bench: remove wrong exponent raise in fill_random X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , cohuck@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , "Emilio G. Cota" , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" At this point random_ops[] only contains normals, so there's no need to do anything to them. In fact, raising the exponent here can make the output !normal, which is precisely what the comment says we want to avoid. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index 546bac9c9c..4ba5e1d2d4 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -176,8 +176,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float32_is_neg(ops[i].f32)) { ops[i].f32 = float32_chs(ops[i].f32); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f32 |= 0x40000000; break; case PREC_DOUBLE: case PREC_FLOAT64: @@ -185,8 +183,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float64_is_neg(ops[i].f64)) { ops[i].f64 = float64_chs(ops[i].f64); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f64 |= LIT64(0x4000000000000000); break; default: g_assert_not_reached();