From patchwork Wed Jan 16 20:23:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 155765 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1102909jaa; Wed, 16 Jan 2019 12:28:47 -0800 (PST) X-Google-Smtp-Source: ALg8bN4NQnQqBnZmOYZiijjXr/C/Tx5N3fdCsqtYFGC/dOXdyJ4lvIjx0ADyzEm5qllUFEbhOYQY X-Received: by 2002:a1c:2856:: with SMTP id o83mr9576840wmo.45.1547670527269; Wed, 16 Jan 2019 12:28:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547670527; cv=none; d=google.com; s=arc-20160816; b=MfrCrrHN9J2Biwc8ANUw1BaJlYLnhA1WUH3zIV5EScREJ6xwwFFaFWSWhW2sQZceLk dtasLdsta8UTx4bvr2bgaTOjR71Xw4QnPHa0c61//pn5rFDaV7ecf4gSFRTy4xt/1RBT TkNpwJ2JS+Tpe+uR4Sn9vWZaF2cpM+5mc2cCIRJc6pPdDPg4JldNz+O0aMQ5YHYsKOrR zlqPJP6n3RLm0/3OxMDdZdpailjYcPHtAbH7OYbhtiMnrCfJAg7cmEEFoxwyKq8A0xmg 6U+ST2gSvmKoBb57EEC8XICmyzeMwzFoWhdQbHbtVYA5ulbHqehWAEBF4zuBVBxgpYY4 njNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=F4xieiuSGqqMJCZRrk4MmRbOQ9MdsYPNyyxXECLqEvE=; b=oSJAqUuPDo9AmReN3KZVcC5DrQPCTyQ5SHn4lPUle0GU4t4emw2B4PlEJPViqhiINI muMwsb7XdzhADPK3PyRPWIrvAj55WIzzOwZUQsNi+/Tprqm1jKeSsPtPCDrqgbMPAwUr AqhYwG8h1AI6vUY8ogPT4mo+JzhXyr3BBP0583j3f4zuMmzHRSQkfRHE++5IHWMWcbHC VDQTBvjRhASDFSzU0HtqXcBONc1g7fx2VO+HskFx0Rbb5Eafvr7R50mzKOqOpJDwb2Nc aAdu/zW8ZItawAmlp5KHYknsYUiIv2l1LhCAdw/OTKDqUkNHsHncJS0iHfiY8hr4o0S7 0tIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UeojzR1x; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d63si23744319wmf.51.2019.01.16.12.28.47 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 16 Jan 2019 12:28:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UeojzR1x; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:45980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjrnq-0001IB-46 for patch@linaro.org; Wed, 16 Jan 2019 15:28:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjrjD-0006xz-58 for qemu-devel@nongnu.org; Wed, 16 Jan 2019 15:23:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjrjB-0006Re-OH for qemu-devel@nongnu.org; Wed, 16 Jan 2019 15:23:59 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:40835) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gjrjB-0006L0-G6 for qemu-devel@nongnu.org; Wed, 16 Jan 2019 15:23:57 -0500 Received: by mail-wr1-x441.google.com with SMTP id p4so8475056wrt.7 for ; Wed, 16 Jan 2019 12:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F4xieiuSGqqMJCZRrk4MmRbOQ9MdsYPNyyxXECLqEvE=; b=UeojzR1xFfuUFIKIptlt/HuOr6v2o/BRtRVfoZ5+SWAHY/+IidELqZR6LBG81ArypM FWJgG5Xr/Q2u1xmpT44ctt2/qSO19Z7Ry+Bclyzz6pIFwUFSD/U/OYsId0f6zLUWjeLl XQt9R0Xv2bY9hxB46Y974Q9mDfJC25sIxY2ks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F4xieiuSGqqMJCZRrk4MmRbOQ9MdsYPNyyxXECLqEvE=; b=ODKCQl/o+2YZLTaUjjvTAvnhkpQbdeKmfpC4evzANruIV/B9RhqtPC4zy5P+xtYMNG prMK+SyE8SibW4Ir1pekRTrxa9CYELEuj5neto9re+8FZBMXd1xufnIfMEu7Zzl0x3eo n1bhdjLIXrRZAPKWC896G9EcZcyxfKV/16Y9rqM3zNqlYSETaNrUMNWucsRYQIFWndr8 uAwgpmQi+OGO3ezKhBel9vCrdQnZNguV6YGw2+rRS2PZO+a0tOvqDOKxFYr9A++Rcfpw yzZqDEF8iWGTCuD4cLpqqpBZwSXLAFUssABnWVhpoED54MLez1QRKJPm35zZmz64h4YU kduw== X-Gm-Message-State: AJcUukfYBKBNxZPinapjcPfA9Mlr/8UjxcDYw341Aq66haCBbvFa8SKx S5TeDWUQitW2SF67fK6ayP6uM29hyOw= X-Received: by 2002:adf:9521:: with SMTP id 30mr8548762wrs.192.1547670236205; Wed, 16 Jan 2019 12:23:56 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id l19sm37407893wme.21.2019.01.16.12.23.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 12:23:53 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 79F353E0F34; Wed, 16 Jan 2019 20:23:49 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 16 Jan 2019 20:23:43 +0000 Message-Id: <20190116202349.29272-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190116202349.29272-1-alex.bennee@linaro.org> References: <20190116202349.29272-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v2 1/7] fp-bench: fix update_random_ops X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , cohuck@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , "Emilio G. Cota" , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The second test in the branches is wrong; fix while converting to a switch statement, which is easier to get right. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/fp/fp-bench.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index f5bc5edebf..546bac9c9c 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision prec) for (i = 0; i < n_ops; i++) { uint64_t r = random_ops[i]; - if (prec == PREC_SINGLE || PREC_FLOAT32) { + switch (prec) { + case PREC_SINGLE: + case PREC_FLOAT32: do { r = xorshift64star(r); } while (!float32_is_normal(r)); - } else if (prec == PREC_DOUBLE || PREC_FLOAT64) { + break; + case PREC_DOUBLE: + case PREC_FLOAT64: do { r = xorshift64star(r); } while (!float64_is_normal(r)); - } else { + break; + default: g_assert_not_reached(); } random_ops[i] = r;