From patchwork Tue Jan 8 16:21:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 154982 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5062705jaa; Tue, 8 Jan 2019 08:22:26 -0800 (PST) X-Google-Smtp-Source: ALg8bN7zNep8JGyzylUIcE0mO+8BT3sVeaZo5GoTKn9oai1kwOsuZs2XhXm16VkcjR/wpfJo+qkE X-Received: by 2002:adf:efd1:: with SMTP id i17mr1919598wrp.200.1546964546270; Tue, 08 Jan 2019 08:22:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546964546; cv=none; d=google.com; s=arc-20160816; b=wk18zoFVhUu82+dnsmlWuOYodfHGQ7WyDwSs5JQOEsCUJKtEpfpmgeo9jM7ge9TliG J2WtYTPzfFKp1D77iMu01vFxvOl73AbtRxrHeTAZ6c+XNvvYx6XWrlVm+iApcJ9CJIa4 IHjOfMILseTI8rpljKbT1OPYrlxiz6Q41Fdk1cFOhfpW3o3rOpn3HsIdWL68OMxYZOcs brXDCOtqJhGpBkqFNUoCna6vom2WfZcHnwsTV5mmGvG5qEKUPHvXmFQ15LsQdcUqH54d R7lvMP2pHjXeGrXyOxOcgP/hXJfSBVu1FrzXSB9sMs5ppcZ4Fb6IjupVLbY8XB54Rk2L OoGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=ETldxgIHGVeH/a1n8S6Mva5jjGnnGUzADuQ4s825HYgxgriy4fGEpF7etnfUrwE7Gm hvFaJYkvArNB034IHZWkytQRRDDVO9NYsWXDS5CZAcaH/kcMA9Id/bL7upMP4ITgaeOd 79Z7gmZ65kFCibqVu48eUIfux9XcjQbmIpzdw3yp7Cg0MOg16MxuOAgGGsmaL1iJ6vvA 3tf2QHzoq3N+oTEWKyJCia2oPDe0oeIQZ1IxDB/qwtMVsFJmpfyx4Cgw9/1oaxfVVBQY 0nGYuxlCFjogLbdwaypaVMQxPt9x+R8xbiNz/tCw4v7ifcVwOVs+/6bAsgO0wcZayyYj GuYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HCRm+rbF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a130si7166759wma.94.2019.01.08.08.22.26 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 08:22:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HCRm+rbF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:53783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu93-0004G7-80 for patch@linaro.org; Tue, 08 Jan 2019 11:22:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu8h-0004Er-SU for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggu8e-0000a3-7n for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:02 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:38049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggu8d-0000Rc-Uh for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:00 -0500 Received: by mail-wr1-x442.google.com with SMTP id v13so4663626wrw.5 for ; Tue, 08 Jan 2019 08:21:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=HCRm+rbFBQGNLLSMSNjNgL4vP+lJGx8Bfu88+dckemNj+DAVJRur00v6sCx7YxvI26 pgGk5TM5gK0wf2VwK0oK2QhrjOuHcT8GYOjDq2055uvypFJpuUmoRp+PTllu/PkMo27o 9XzHLMnFgnu1VwLhBNbWAkxxxk/PwFkKdMX6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=i2JSwxH70aE8vp1sVyvZNcN9yAdwSh/WiNfkDhtS10Qc6XJF1SDTBsgZ990l3pGyGW zX5pmRvFQWxNlUx7F+G1HJwIZYJqWbJThjx8WfVhSEm8mSa6g2C9OaV5peavf3ilOK2S xWPCCrVrqyPEoGeqoEOhzE/UcB0O8JZ9htv/eLTIJ1ZTmk4hyT9pKlWg5LmmcfCR0ZHS WXBihPw/g6Wma8hjMldna9LWIf1f/8SZlU50FdHlvnLNSnI9jFKHt+3u6GyWUthTns08 4c/YPuozi2uMJCXv1cXfTRnJWYS1oBhWYkdntRThby8gPsegbfraywtahC93pdOBEfDP 5yhA== X-Gm-Message-State: AJcUukefhnDG29QWf1jX6jX6now2db45JPfmLGHFNYJslgy6Mw7VxXma lBF4CM9srlv/QN93izGpZ/U1durxyf4= X-Received: by 2002:adf:d1d2:: with SMTP id m18mr2040455wri.138.1546964517276; Tue, 08 Jan 2019 08:21:57 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id j3sm11424373wmb.39.2019.01.08.08.21.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 08:21:55 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 91DE83E10A4; Tue, 8 Jan 2019 16:21:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 16:21:50 +0000 Message-Id: <20190108162154.22259-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190108162154.22259-1-alex.bennee@linaro.org> References: <20190108162154.22259-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v1 2/6] fp-bench: remove wrong exponent raise in fill_random X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , cota@braap.org, =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" At this point random_ops[] only contains normals, so there's no need to do anything to them. In fact, raising the exponent here can make the output !normal, which is precisely what the comment says we want to avoid. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index 546bac9c9c..4ba5e1d2d4 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -176,8 +176,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float32_is_neg(ops[i].f32)) { ops[i].f32 = float32_chs(ops[i].f32); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f32 |= 0x40000000; break; case PREC_DOUBLE: case PREC_FLOAT64: @@ -185,8 +183,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float64_is_neg(ops[i].f64)) { ops[i].f64 = float64_chs(ops[i].f64); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f64 |= LIT64(0x4000000000000000); break; default: g_assert_not_reached();