From patchwork Tue Dec 18 06:38:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 154103 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3357520ljp; Mon, 17 Dec 2018 22:58:49 -0800 (PST) X-Google-Smtp-Source: AFSGD/VR080TnZ9voKVqVBe7HQ8twSBmlvvknWM8hkIXAzfAGYPUMtjy4El4B8NiHLn79IqRoo/z X-Received: by 2002:ac8:4709:: with SMTP id f9mr15905621qtp.58.1545116329656; Mon, 17 Dec 2018 22:58:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545116329; cv=none; d=google.com; s=arc-20160816; b=nPK8E/yJYAi/H568Jl4qkv9Ub95AY9gw5kdC6uTAruzeKV78/V3Y8E7jfV5xdAjc2y 6UvffPuvZ7Cr7MKIQN3Rn5YjTMHrJFocNXVB4iaZXoK8+dVCgRo+0GzMJfwzfIsRhGZY nn7qndCwf+Tek8cc3rLl1lC4anBPGjcwNpNKYW9MtKdzMz2iZVduxGslzBEuNXfiGi/V JUtjZeOk7W6swN9K6Tp7bfQLDhZdccx7L14yRCGY6C+GGkxuxGPyYRBmjqKz7Xs91Kab au84Zk+8BOFSEhI1HfT6PZ0BzoFLQ1zRlC75v6TqduET4z+uHPU4vgGrK5H7MwcVq02d tQfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=NBIM0mIrycdtqlXSzpKN+VgcBQ4YRzFxTXw+YZBnlKY=; b=LxhQ70DPT8fmr+u/orGMuwy5ptg02O5YqLbXostlQBes53VRcATgxDuYq7WxDnD1my QUHIkeZH2W0Z9Wo2UTB8ZbE07wWvaLUuNIvPgjdR4sQMuDss1B/cfzm/VJMYvMA3xQNe B42upO1IwulXxJHfgWzX+4M5lMiZ9Myuv8HJ25dMN10PESkWrLVNY7O8LkBVepP7oL8l XL7HG5OfBrMxTrWzbaA1sNjBSRacANBxyzyNEFsCqhYcGycIa3LtmYkAMjd5XVmUb00X eE0mNMDrOUC83YDZJg5oJ01xQ3ex8MbozdecHlcPQL3mevgbO77795yzxwKo3EKvUJQg /0kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HZ+OOz1J; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c185si4806309qkg.75.2018.12.17.22.58.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 17 Dec 2018 22:58:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HZ+OOz1J; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZ9L7-00081L-3i for patch@linaro.org; Tue, 18 Dec 2018 01:58:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZ92y-0001iW-Ap for qemu-devel@nongnu.org; Tue, 18 Dec 2018 01:40:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZ92s-0002t9-Gh for qemu-devel@nongnu.org; Tue, 18 Dec 2018 01:40:04 -0500 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:42085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZ92r-0001tb-Pe for qemu-devel@nongnu.org; Tue, 18 Dec 2018 01:39:57 -0500 Received: by mail-pg1-x52b.google.com with SMTP id d72so7337892pga.9 for ; Mon, 17 Dec 2018 22:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NBIM0mIrycdtqlXSzpKN+VgcBQ4YRzFxTXw+YZBnlKY=; b=HZ+OOz1JKGhs1iOFCAka0Rv7QLicbHM2RQGb5or8IH/0tWPuFxhByY3WQ5v27eu1dK Pl2iJscCLqraJeXqDTE/fdG2+4xTYdJ87hTtNSseeWU/TiuRy6ncCtnB+EFHX2+7OeNj pQhEzkGhwcccQfdM3jN+T1fOl8G+ubuGjxTO8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NBIM0mIrycdtqlXSzpKN+VgcBQ4YRzFxTXw+YZBnlKY=; b=NM9EMG8816W40nWDENbYv9XPvgtw1ixXxkNPScECTAyBWNYE3PwqXT1gHpinTDaoFr ivfe6shtyVqOxkobOtuqE/sROL0c/r7dlXoRtBgcnUIRCl7oga/ydiDvn2a6elrt+kFP e+6pMdbAGUJupLGqFEWMbeISBL7YdHaKINxbqEnW+htNPWhJroryM1fAfZrxud86EufU 0HX5b2cFn8Gx6ymNc+CKeKSBAsQKu5/t9CORXQCXbJebL/4+1aVX6ekPXNU6715Mby2Z itCKwt3A4GvilsbiHFJttYTzJexY7R6bdt2UAd9502WN7vpwBmbgGIkpNZIKhA6nzUuV efyw== X-Gm-Message-State: AA+aEWaBstuBDoD7zxy5hBu53VAZw28f6ys43aEeFbuPSb4PBS3wY3tu QliX1EUIlhSpIqhGe3vzA/kIjKnSME8= X-Received: by 2002:a63:4456:: with SMTP id t22mr15140191pgk.0.1545115156263; Mon, 17 Dec 2018 22:39:16 -0800 (PST) Received: from cloudburst.twiddle.net (97-126-115-157.tukw.qwest.net. [97.126.115.157]) by smtp.gmail.com with ESMTPSA id c7sm27072509pfh.18.2018.12.17.22.39.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 22:39:15 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 17 Dec 2018 22:38:39 -0800 Message-Id: <20181218063911.2112-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181218063911.2112-1-richard.henderson@linaro.org> References: <20181218063911.2112-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52b Subject: [Qemu-devel] [PATCH 02/34] target/arm: Rely on optimization within tcg_gen_gvec_or X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, mark.cave-ayland@ilande.co.uk, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since we're now handling a == b generically, we no longer need to do it by hand within target/arm/. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +----- target/arm/translate-sve.c | 6 +----- target/arm/translate.c | 12 +++--------- 3 files changed, 5 insertions(+), 19 deletions(-) -- 2.17.2 Reviewed-by: David Gibson diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e1da1e4d6f..2d6f8c1b4f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10152,11 +10152,7 @@ static void disas_simd_3same_logic(DisasContext *s, uint32_t insn) gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_andc, 0); return; case 2: /* ORR */ - if (rn == rm) { /* MOV */ - gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_mov, 0); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); - } + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); return; case 3: /* ORN */ gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_orc, 0); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index b15b615ceb..3a2eb51566 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -280,11 +280,7 @@ static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) { - if (a->rn == a->rm) { /* MOV */ - return do_mov_z(s, a->rd, a->rn); - } else { - return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); - } + return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); } static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c4675ffd8..33b1860148 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6294,15 +6294,9 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) tcg_gen_gvec_andc(0, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); break; - case 2: - if (rn == rm) { - /* VMOV */ - tcg_gen_gvec_mov(0, rd_ofs, rn_ofs, vec_size, vec_size); - } else { - /* VORR */ - tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, - vec_size, vec_size); - } + case 2: /* VORR */ + tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); break; case 3: /* VORN */ tcg_gen_gvec_orc(0, rd_ofs, rn_ofs, rm_ofs,