From patchwork Fri Dec 14 03:19:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 153707 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1594848ljp; Thu, 13 Dec 2018 19:20:12 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xznp2Fyep94KrOl6JhNb+Ku3rYizD/zNN6/A/KNWSFfrMORxH1ZKoFfTR2RfFpVV1zSkLp X-Received: by 2002:aed:2b01:: with SMTP id p1mr1224343qtd.101.1544757611901; Thu, 13 Dec 2018 19:20:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544757611; cv=none; d=google.com; s=arc-20160816; b=BaCGOi8f3zcn6bVD41lTTNBtXlmGtox4NWX5qEoKcvswKPODRzwruNTLBhO5DdFtBE A68DroGJNRAiBq1TTW3d7Md6t3kktjN6Ro9W9Q2bRC60MKxEiInL0+cJOPS/O1BFVSBF neuIrSdgkOY5fxtvUUnNf/yWMlktp6AAxPXM5CyE819E1GL6cxRom7Avb/Z3mMLbuOm8 5d3DyovpYqCS/RV9f1uf5woYoJW9wLpVOlptnb/d9lih8rad9yjw/uSKCVyXUD0BzPDK QRI08kEDrrG4wv70QxCYNSrePx7duhpNBNcocGm7Pqq8rFy43QD8skH24ECXgNLKNviT xKGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=I/odWjCOJHIQsNZnTEkgZki8MpiCHZCtHfZCeJ69w/I=; b=SRh4A7lKK2diK6uX/H9GbzcjRVcPXB1Xkp6/WbZLAANHfml1txuPNaOsr0t/qWDGWd yCbaZLb/5aHGC5Rn4PnHLZkl6wWr9X1+/KfZaAUg87RRJ2F5sY+0P5mjuu07KxfscAz3 gE8IF+sKDDYEX3tmaWnClHL8ciT0QhAdyoi4cHdVFruDwDAp9XLRJntwI0zsFaNEhsmO 0llFsTvJIX1SL4kP2e/k+cnAL7QHD5xe7Kfxrit5HVhN0KaVX333l4JtMUrGhM7Zr2VF hyOPT8NoCs3MZPpoM73VCCfh3oEuWslRoF6ZoK9dtIit7ZToSVMq/qWZ47mzLYzcfags O5Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=i1rOeiD+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id k35si1633513qtc.318.2018.12.13.19.20.11 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 13 Dec 2018 19:20:11 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=i1rOeiD+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXe1L-0005xE-Ab for patch@linaro.org; Thu, 13 Dec 2018 22:20:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXe0r-0005vx-1J for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:19:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXe0o-0006iA-Oe for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:19:40 -0500 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:34180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXe0o-0006gw-JX for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:19:38 -0500 Received: by mail-oi1-x233.google.com with SMTP id h25so3490855oig.1 for ; Thu, 13 Dec 2018 19:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I/odWjCOJHIQsNZnTEkgZki8MpiCHZCtHfZCeJ69w/I=; b=i1rOeiD+Uoo7gjrCo9ObzWz1yLI5BqY9KHdHNK2VTREdc/mijzEwdsqMMWslZZ4QF8 MVQYP+fHi9yRNxIb5YH3pQnKVh9WCeB9BdAGJlDGVId6b6HwFg1jr+EGb85yaoaX4BkT I4ymG9gVD9pN/C4OK5MReRWyqyxyY7SedL5Iw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I/odWjCOJHIQsNZnTEkgZki8MpiCHZCtHfZCeJ69w/I=; b=nqK0zRCSW3dQkcMonjaohpzcxSEC+QQuzz7LyBlPFOo/Ws4KDkbUBVx8s5BtK9qlem rss66RJIryh9kX76nqsKFtq4UkR+wCp4Ofqzj+RXt32KeVXT97TNl88oDLzhtViUULIT kyc36NCeU1VPfm420x0OltszKVWg7/zZTxVSoMfGQ1WvF1cMW46VD55VbHSguCGFkRYl /hGFM8Z5TS43DRPQM3eeP9LOKU9SwZ6ssMWnfihinNABEW3QR7/ZrJw2nR/DAWQqsSsL Bne+ff60EWC8pnUrnIlDOtXmfeOKVsVfp6jz2Ko4ztpzmVJiXJlSzx3/ToeD+U/c2IhJ 5jwA== X-Gm-Message-State: AA+aEWa824ZIoKW6pnlp+aw6rNupEaZmji51ZB7rSYUmNG0pLztm6Jcx VWNr433nAyJzkw99jRB8xB+zE6XPnibyew== X-Received: by 2002:aca:b102:: with SMTP id a2mr862715oif.180.1544757577593; Thu, 13 Dec 2018 19:19:37 -0800 (PST) Received: from cloudburst.twiddle.net ([187.217.227.243]) by smtp.gmail.com with ESMTPSA id g138sm2367537oib.26.2018.12.13.19.19.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Dec 2018 19:19:37 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 13 Dec 2018 21:19:01 -0600 Message-Id: <20181214031923.29527-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181214031923.29527-1-richard.henderson@linaro.org> References: <20181214031923.29527-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::233 Subject: [Qemu-devel] [PULL 10/32] tcg/mips: Remove retranslation code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There is no longer a need for preserving branch offset operands, as we no longer re-translate. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.inc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.17.2 diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index cff525373b..e21cb1ae28 100644 --- a/tcg/mips/tcg-target.inc.c +++ b/tcg/mips/tcg-target.inc.c @@ -483,12 +483,7 @@ static inline void tcg_out_opc_bf64(TCGContext *s, MIPSInsn opc, MIPSInsn opm, static inline void tcg_out_opc_br(TCGContext *s, MIPSInsn opc, TCGReg rt, TCGReg rs) { - /* We pay attention here to not modify the branch target by reading - the existing value and using it again. This ensure that caches and - memory are kept coherent during retranslation. */ - uint16_t offset = (uint16_t)*s->code_ptr; - - tcg_out_opc_imm(s, opc, rt, rs, offset); + tcg_out_opc_imm(s, opc, rt, rs, 0); } /*