From patchwork Mon Nov 5 18:14:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 150222 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2936042ljp; Mon, 5 Nov 2018 10:22:19 -0800 (PST) X-Google-Smtp-Source: AJdET5fbsxhbQgS6cXFatMNndv0h6nYapFlWtKLvfXmDKJsbZJAAL+nw4PT3Q0mWes+P7lESinei X-Received: by 2002:ac8:3e91:: with SMTP id y17-v6mr21739863qtf.314.1541442139269; Mon, 05 Nov 2018 10:22:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541442139; cv=none; d=google.com; s=arc-20160816; b=e9apOiCSiP1QHvad+VhH+kvR9Cc7YEq9TeYPHv6rAP7ePCsyiEBgI4jP9ynXQT5wkC xS7alvAWNOmT+yGN/EkUc+A4SJwttEzIufgWyNOqMDeyrUGE3Wr4FyrS4GSc57KJCP5J cJJrlIgYzYAdywoADvp7bRtW4w32N2/NGqeG8qeju8Lsd0xEtNKt/B2QPuglOKxak93E exq5UyxQVdug1Racgm5FQpu7KQ5vXH+5rMt0N9e6T/a+jTh725fXcIfyFOYsUEdvFZda AqJKfPswIgv4q1O1AA3vjwicaVQz6PqXphaVrysbnmoCMEHCDcnKPX3ygMisLONASGOP 4GVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date; bh=8NEMDiw8zjChuX0CnA9mpWlIruX5h5iv1PGX5fL/mcg=; b=KHUOh6YL2JuwG62G3UHagZIzl7zM3mWAK5xCnPHqpKI1AYGM9D6RL3OJB8QlioVoI0 GSC3D7b69sgS40jdkVrJl59D10VKcEQd/ud29E8cHIWAJ8GaDKRP65l9kAskeW5EDQL/ TqaK1p1Kih8VO0IsJZrRmcYSJDuLvLwFDqQOokhnGpsmVrz68FRvbJC70JHjsRU5HTgj Y+nF2YzSn3Kl9AlI5v6imu/nQDmOLa/LBQZGIq/VjTKC1nIP6gDRGPofgHnMul6XaL2d vqyucQtOSHGlvtm7NZgyIQLHUgHBaMlZpi30hECX8PEjodHB/W+WJmR/q1vnRPOpXmn4 uK1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id s31si3771282qvj.140.2018.11.05.10.22.19 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 05 Nov 2018 10:22:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:36910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJjVy-0007tB-Kp for patch@linaro.org; Mon, 05 Nov 2018 13:22:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJjOz-0006P3-VX for qemu-devel@nongnu.org; Mon, 05 Nov 2018 13:15:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJjOx-0001GK-72 for qemu-devel@nongnu.org; Mon, 05 Nov 2018 13:15:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3104) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gJjOw-0001Fz-W7 for qemu-devel@nongnu.org; Mon, 05 Nov 2018 13:15:03 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35F713084022; Mon, 5 Nov 2018 18:15:02 +0000 (UTC) Received: from redhat.com (ovpn-121-251.rdu2.redhat.com [10.10.121.251]) by smtp.corp.redhat.com (Postfix) with SMTP id BA73860BF2; Mon, 5 Nov 2018 18:14:47 +0000 (UTC) Date: Mon, 5 Nov 2018 13:14:42 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20181105181353.39804-5-mst@redhat.com> References: <20181105181353.39804-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181105181353.39804-1-mst@redhat.com> X-Mutt-Fcc: =sent X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 05 Nov 2018 18:15:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 04/33] configure: Use LINKS loop for all build tree symlinks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , Gerd Hoffmann , Paolo Bonzini , =?utf-8?q?Marc-Andr=C3=A9?= Lureau Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell A few places in configure were doing ad-hoc calls to the symlink function to set up symlinks from the build tree back to the source tree. We have a loop that does this already for all files and directories listed in the LINKS environment variable; use that instead. Signed-off-by: Peter Maydell --- configure | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) -- MST diff --git a/configure b/configure index 52408ed307..74e313a810 100755 --- a/configure +++ b/configure @@ -7417,6 +7417,8 @@ LINKS="$LINKS pc-bios/s390-ccw/Makefile" LINKS="$LINKS roms/seabios/Makefile roms/vgabios/Makefile" LINKS="$LINKS pc-bios/qemu-icon.bmp" LINKS="$LINKS .gdbinit scripts" # scripts needed by relative path in .gdbinit +LINKS="$LINKS tests/acceptance tests/data" +LINKS="$LINKS tests/qemu-iotests/check" for bios_file in \ $source_path/pc-bios/*.bin \ $source_path/pc-bios/*.lid \ @@ -7453,25 +7455,13 @@ for rom in seabios vgabios ; do echo "RANLIB=$ranlib" >> $config_mak done -# set up tests data directory -for tests_subdir in acceptance data; do - if [ ! -e tests/$tests_subdir ]; then - symlink "$source_path/tests/$tests_subdir" tests/$tests_subdir - fi -done - # set up qemu-iotests in this build directory iotests_common_env="tests/qemu-iotests/common.env" -iotests_check="tests/qemu-iotests/check" echo "# Automatically generated by configure - do not modify" > "$iotests_common_env" echo >> "$iotests_common_env" echo "export PYTHON='$python'" >> "$iotests_common_env" -if [ ! -e "$iotests_check" ]; then - symlink "$source_path/$iotests_check" "$iotests_check" -fi - # Save the configure command line for later reuse. cat <config.status #!/bin/sh