From patchwork Fri Oct 5 15:48:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 148194 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp611975lji; Fri, 5 Oct 2018 08:50:08 -0700 (PDT) X-Google-Smtp-Source: ACcGV62cT5Tz2CJ0GB92CqNWgNMyleyYjlk9w76lBsQmcrK/7dlHEe65RsI1gzM6IVpy7ZMf3g5j X-Received: by 2002:a0c:ab4f:: with SMTP id i15-v6mr6198159qvb.190.1538754607998; Fri, 05 Oct 2018 08:50:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538754607; cv=none; d=google.com; s=arc-20160816; b=flAbxAhAgCykEp3oaU6zIuz3qhRuGHh+EpC3gFydPKVY0hG6sZtZQgHz/flX0Y9L8T GS7YSgrfpXbm9SM8TyF61oJ5L6BRfJqvdmVCiqTzR9OaNGwmOuUCf0654E2K5s64+Iw6 gdk15dfPzV12ueqF3RflbXIqiVgkEA9+OsbLYry/XepLbYXp4feZyJqgZKxZ1Klj1hKH J3ecb0R4ZTlkSizbMQT0MIoz+ACgLdGBxeEiAf0hBeZ7Nz6DEOZySew1q/VbLGqDUFPj XgpUpHoHE01MfcdHTdn+V6CSsBH8klTorBhN1BRoKFejKt0ZlSiVpiR4yl/Bur0diXEs pXCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=x/pfIyq+zKnBKvaDMmwFphUlcVq1DV3Vl6QOikvINow=; b=hGYKGy2STabAGU0B1mgca39WMoGtB5rzSJFQ4J++5HFmKiMg7jtO4PHbRRoquSboiM TLpuCmeuxIPVGsgaZstwPO3XPnpUTAMv69M6iaSxnwleoVDHtOF+dOsxyBceBV0Kd3e3 l9LkDCjJHbfDDnmLDQIuWdKXa2dDL6z1/bFoITETwom8eh2Iy6axPvda05rYWvfy3ygZ Vkezb7S6lnrg4snPwoAlCGyLsjdrZJ9PmZG+FDT+lxVyurb3kwX9c7jdSvxbWyCxrPWt POw5Ch8qK6Wl7dP6J+hw5Spaa9UpeUcoKcMsw5fa98Bn4WFpwa74bW3ha+3BBiRjxLev b8Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KIdbz9EH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v190-v6si1661094qkd.287.2018.10.05.08.50.07 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 05 Oct 2018 08:50:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KIdbz9EH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8SMh-0006Zy-EE for patch@linaro.org; Fri, 05 Oct 2018 11:50:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8SM7-0006XZ-5K for qemu-devel@nongnu.org; Fri, 05 Oct 2018 11:49:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g8SM5-00068t-0g for qemu-devel@nongnu.org; Fri, 05 Oct 2018 11:49:31 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:33760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g8SM1-00060k-DK for qemu-devel@nongnu.org; Fri, 05 Oct 2018 11:49:25 -0400 Received: by mail-wr1-x436.google.com with SMTP id e4-v6so14082237wrs.0 for ; Fri, 05 Oct 2018 08:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x/pfIyq+zKnBKvaDMmwFphUlcVq1DV3Vl6QOikvINow=; b=KIdbz9EHfziSO1zKCZy8ozcrqeA8i6Gpx82vNDmV5SW9gBcGdHR3LTWR0wXzrKCtFO 5psLw1k8Y8auNIQmKIZ39x67ziank6BW2FU7J3CGRO+0hpvbq8ReplVHB/nCZ1mqKBhR 2ADlJ7590i+3BoCfEzEYKD6uzGTAT2wQCxPm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x/pfIyq+zKnBKvaDMmwFphUlcVq1DV3Vl6QOikvINow=; b=gXkoz3zQqoCRW4UcMCH7cNO3Bsz7BAt18BxOsK6wMarS2YbLiIExc32AXXsdFaejqm H7oqD0BP4KyHqjBuRKaoFO51fZbUvPAkYQJX49dfowOkofYPU/9VSYuEZ0+RF6+jpKUu wjUcL94vT1mDic2s2NEaSsergRx8Ln0kpWdVNa/EFwH7L+Jt/UfZI0V1ilzM0hi8ZuLw NMepCtxJ/LeQhBkqLCo31snWEF1usC/KXtlBQ/k4gQHcOU1FdHWqA09szLSVM3+4/aDB U4jjNcEdGVu6IdYb7nM+YG8WuXqSlWLGeZ6a8yGSyJcrSxRrCIU4qroUZMznmZhMtl5i 5cyg== X-Gm-Message-State: ABuFfoi4lBwUKVWfLKluKx92c8Nr0Dimg5at6rESK2Tw+plK7UwwEj/t 3p5OmZlRKoea2S/KSMPMiPGk7Q== X-Received: by 2002:adf:92e6:: with SMTP id 93-v6mr9253451wrn.124.1538754554525; Fri, 05 Oct 2018 08:49:14 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id b5-v6sm6910802wrr.94.2018.10.05.08.49.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Oct 2018 08:49:12 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 0A69A3E05DE; Fri, 5 Oct 2018 16:49:11 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 5 Oct 2018 16:48:53 +0100 Message-Id: <20181005154910.3099-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181005154910.3099-1-alex.bennee@linaro.org> References: <20181005154910.3099-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 Subject: [Qemu-devel] [RFC PATCH 04/21] trace: enable the exec_tb trace events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Crosthwaite , cota@braap.org, Pavel.Dovgaluk@ispras.ru, Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , vilanova@ac.upc.edu, Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Our performance isn't so critical that we can't spare a simple flag check when we exec a TB considering everything else we check in the outer loop. Signed-off-by: Alex Bennée --- accel/tcg/trace-events | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.17.1 Reviewed-by: Richard Henderson diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events index c22ad60af7..618cc07738 100644 --- a/accel/tcg/trace-events +++ b/accel/tcg/trace-events @@ -1,10 +1,11 @@ # Trace events for debugging and performance instrumentation -# TCG related tracing (mostly disabled by default) +# TCG related tracing (you still need -d nochain to get a full picture +# as otherwise you'll only see the first TB executed in a chain) # cpu-exec.c -disable exec_tb(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR -disable exec_tb_nocache(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR -disable exec_tb_exit(void *last_tb, unsigned int flags) "tb:%p flags=0x%x" +exec_tb(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR +exec_tb_nocache(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR +exec_tb_exit(void *last_tb, unsigned int flags) "tb:%p flags=0x%x" # translate-all.c translate_block(void *tb, uintptr_t pc, uint8_t *tb_code) "tb:%p, pc:0x%"PRIxPTR", tb_code:%p"