From patchwork Fri Aug 10 19:31:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 143963 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp329860ljj; Fri, 10 Aug 2018 12:35:13 -0700 (PDT) X-Google-Smtp-Source: AA+uWPz0xwrQsYFcr+3XyZqhSuyg1OSXd+4YZ7sPlfU2SSJOXrGfbQZMUcwBqY3ute6HIpOXtLPa X-Received: by 2002:a37:8c46:: with SMTP id o67-v6mr7217497qkd.162.1533929713039; Fri, 10 Aug 2018 12:35:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533929713; cv=none; d=google.com; s=arc-20160816; b=xx4QFU0pWCR4X0/520sE7iV35Cz8JYr2w6wz7KMCgH1mtQaf7A+jn/bgO5qNoFC30U 4A914qELQhIee15iK4bp+bT98jkHbOeH4eNxFPOMgrU/dAGKtnjJOoRoqYGxmz9XPB+f j/n0GSo77R6hzAyoNM6+HvKPY9tJJNpC55vpgb9SXzGK7qxdu0YFW9nAPavV2FXgTVPC 0idb/Aqk7deinxNWCfvYPdxHcyXrXTE7yQI1NqCJOeW1qqbK5DQVpq2uXSC9S6jtbRNc 7Hq3o012qaeu6JmnTmRu4o0NDDpPdetSOepvkUZ+KQIR95EFd4hgM5gs4uMoruuNHi/l zRRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=tf0EXkqA/UE/bR2UWszaBaMTE99+BwbEbsa7o98ekHk=; b=Ac/loJJSclJ183HZcQ+RkK0xrDBdnytc/JRN1T9vw/En9aYNjm/sFmcmUmc7qbsR70 6a6CK+vhnRTAouhthnpsTqJdHMCjNhKO9VbS0JlJYkDbk8nIqMrXAEr50ou0eBC756Vc KPSUYlcmaLVhEInJURnp/rnWMsQQdzL4/MbizRG/E/k1Leopm7/g9XKMoLYnqq6aezs7 3ypsfeNUZmoORl4RSS0TgZNXMzGRQ6GkVxiRUAxHmhODD1w/fJPqCkt9KqTNRNOv4rJ4 fA37OsK6YsfR3JQyFJ3AASd33MQxJccxhRqVUbfnSr5UQaj75SMf0TRaYPBy6DkM8P8c tgGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dwropqyV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y36-v6si4695456qtd.59.2018.08.10.12.35.12 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 10 Aug 2018 12:35:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dwropqyV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foDBo-0003wl-FS for patch@linaro.org; Fri, 10 Aug 2018 15:35:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foD8P-0002SZ-1q for qemu-devel@nongnu.org; Fri, 10 Aug 2018 15:31:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foD8O-0005eh-9D for qemu-devel@nongnu.org; Fri, 10 Aug 2018 15:31:41 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:38760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foD8O-0005dy-2U for qemu-devel@nongnu.org; Fri, 10 Aug 2018 15:31:40 -0400 Received: by mail-pf1-x441.google.com with SMTP id x17-v6so4974310pfh.5 for ; Fri, 10 Aug 2018 12:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tf0EXkqA/UE/bR2UWszaBaMTE99+BwbEbsa7o98ekHk=; b=dwropqyVMCX0NTRHRCM9yxUYjyg3uJT9fdB8LatPt2vevLZzC81fOmlyrAX/EbZDFI bk2XQ8SUwBoIpSRtvgrPx8XUBPR08vIYsM9NmMfldfyCHtt+IyS8LHa6Frq3yyUBUnGD 9T6IXlzUS3jNqfOw0cXXG8GO6BfldbWB6uc44= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tf0EXkqA/UE/bR2UWszaBaMTE99+BwbEbsa7o98ekHk=; b=bXWeg10LOfJ6sEMMyj7SVo9nu+o48VgiO478zRH+N9WvI6PLlwgOOFptHPXJV1n50d mNmcBLhl18B9evYedB3xTCkxsCh7lQ/t/3ntTlNY7otaX5guZhQ1LMI8E+P5DsgigxOw KEZChRFFpODudxghUebA0u36pjchaOugG8d6CU7GH0TySaZswCWgmdTQPZNHImKswg1f rhpaI1SKnXR+HLe1DU8mebgGFGf0VxC0mpBn9ESdEYwXrvj3V1JAxNN7J7ciH3pJu2SV XS6nOvxxzMasu11bGIz6RkKnCnbSSGUeY6c27xW7aHaH2HSGQ6bdWlskGQ6q1yYF/uI7 0bXg== X-Gm-Message-State: AOUpUlHZviZdcYhi6a83Lb7t7MqxT9S/Hjx85LZCqORh7c/fIa+UgMaN KSV+BUcBff8WXkn01j3tNUtFCG/P1ro= X-Received: by 2002:a63:4811:: with SMTP id v17-v6mr7454892pga.379.1533929498783; Fri, 10 Aug 2018 12:31:38 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-8-179.tukw.qwest.net. [97.113.8.179]) by smtp.gmail.com with ESMTPSA id g28-v6sm20500949pfe.41.2018.08.10.12.31.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Aug 2018 12:31:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 12:31:28 -0700 Message-Id: <20180810193129.1556-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810193129.1556-1-richard.henderson@linaro.org> References: <20180810193129.1556-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::441 Subject: [Qemu-devel] [PATCH 5/6] target/arm: Fix aa64 FCADD and FCMLA decode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.desnogues@gmail.com, peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These insns require u=1; failed to include that in the switch cases. This probably happened during one of the rebases just before final commit. Fixes: d17b7cdcf4e Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.17.1 Reviewed-by: Laurent Desnogues diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 4a0ca8c906..8a24278d79 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11427,12 +11427,12 @@ static void disas_simd_three_reg_same_extra(DisasContext *s, uint32_t insn) } feature = ARM_FEATURE_V8_DOTPROD; break; - case 0x8: /* FCMLA, #0 */ - case 0x9: /* FCMLA, #90 */ - case 0xa: /* FCMLA, #180 */ - case 0xb: /* FCMLA, #270 */ - case 0xc: /* FCADD, #90 */ - case 0xe: /* FCADD, #270 */ + case 0x18: /* FCMLA, #0 */ + case 0x19: /* FCMLA, #90 */ + case 0x1a: /* FCMLA, #180 */ + case 0x1b: /* FCMLA, #270 */ + case 0x1c: /* FCADD, #90 */ + case 0x1e: /* FCADD, #270 */ if (size == 0 || (size == 1 && !arm_dc_feature(s, ARM_FEATURE_V8_FP16)) || (size == 3 && !is_q)) {