From patchwork Mon Jul 23 20:17:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 142649 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp6511878ljj; Mon, 23 Jul 2018 14:25:37 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfd/RlDcv7SPououW8/BEEdPFNhvM31D6hPsaYfXhYpyZxh5oA24tmZzcPbv8tvyQCQ8sLY X-Received: by 2002:a0c:86f3:: with SMTP id 48-v6mr12714414qvg.165.1532381136954; Mon, 23 Jul 2018 14:25:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532381136; cv=none; d=google.com; s=arc-20160816; b=FSK5tbAMQTY5jtvIL7zvefOqXPAzapg0B1IqMlwL06x/9eAYEVJx0UY9Gzabg5Km8E 1eVbRKoFWbE4tB5SHoARdtGTzG+iVdJaBdKi+SJGeibtZu0RxeF/TNUT+Wks6hGoo/QO uYgozllbjym16q4vA3Mk9GqBB5nT45YlhvvH44w/UPhncAUubNYhww50dZtxrH3LXvCD cZYDZBJb15QFELZQl1pP53vhWU3/qn+3/nCDJr91jJa4PF1P+wGcYv/G7GMlY7ZQO1rp /vKTXdFIWexcfiHQwPisXQq6Phai6u5yi3oMUYM5Xr+vP/6nG78REciH82OfzN+ll+fO zsKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=eNFiUdYrtj6V8YdcdUftq0s+w+8iqj79jT1PgkeIBzw=; b=ogucCJ/EDBVacpY7PlzU7Vz6PB7s3ZF0FsQNTUkvmSZ+KX2jq9OK1fzuhhYGlK5pvf nk3GIrHen94y/9TDNmsq7fZ7b665jYRqpnTn73GxUqR/q/Zq8PpxGxTmjftdqT1FydfP /CMZmN7aHOuwybAv6sm1D/+tLkOKFwJOOZfA5dNpRqgdqscNxlcI9LCcjIllffy3NvXw uQ2LyphS/gP+XmkHwd4IPYq+laZwBOWW1wiZ7kia5EiHf20IQY5XIECac1Lqdpz21+5o qzknGJpebnVhSfdFGYy4TAnz2qpwpTPzNho7FmMkkjkFR3WwVQFMiXbmUfY4a4xcAtGj Qy9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jPwfsqR2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id h2-v6si3904545qke.77.2018.07.23.14.25.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 23 Jul 2018 14:25:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jPwfsqR2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1]:36753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiKm-00022y-AD for patch@linaro.org; Mon, 23 Jul 2018 17:25:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhKT-0003hn-CJ for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhKQ-0005Fg-6G for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:13 -0400 Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:45714) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhKQ-0005FN-0J; Mon, 23 Jul 2018 16:21:10 -0400 Received: by mail-oi0-x231.google.com with SMTP id q11-v6so3454191oic.12; Mon, 23 Jul 2018 13:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=eNFiUdYrtj6V8YdcdUftq0s+w+8iqj79jT1PgkeIBzw=; b=jPwfsqR2RhqgOiwa/IqqzXUwVDrNDHr5O0ZqqAy0Ilxj9Sornnoq8iQq7xIsDci+JK Ti8V4xrJTwacFUy/eTTcrKKeDdRmsJSivhZgYBWFUmUd7MOT41JDxoln6nfMfxHEcaLc iXUVCzJcgvwqcpvULwC2ajXHehUC8VkSgN3iW3JL6LINo+3stsIZldWL2enen1YF84I+ ImXmDGzA7Hc5ZaOFfPdr5850gjRni97PLSCDb6ghyyGIl05Gnf8LfLj7DP3DSOqifpVM aOcFcPoyr7br3H65f0exV78ZTnLWgpKYNM2TPUxoEF26gUNQwM/zt0kuQ/gfaItudimk v20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=eNFiUdYrtj6V8YdcdUftq0s+w+8iqj79jT1PgkeIBzw=; b=eM8Ux6PWKh193DSUmrgJXv0oLeFZZ7vmpXdvNXsfzhpSeXQ4fHrFJFpTd9sfwOT/w3 HPLT/Kgxs11gG0LA7MNa5p5EsEgpaFZXS22NJd9DNLOoaEPWJvYNhwgClI3KAEvA3HZk a3ktLU8jwrV3J4eM7PTw5PNpaSULLTIWqFP7SI8j4IepR3jIsFudvDDhxFhbcd6yh+7t 48S14HUm/nuA/npFKKndpapUB7M9CoQAuXTWL4mtMcktW0/5mKsjr0E712cx3Wu0YtPv uzjevum2dbbWEH1o1CG+oMDYyZbdB6WJOi5yU8qyxiL16qeVFuWPDJrm1/6GRYxOQxk8 N/hQ== X-Gm-Message-State: AOUpUlHQ4jvXqwsMk6U+YiLGa4YvxkWBjUnSg7uv3QaEJ0YXxF2FjZA1 OCD5I1FGe6G3/TTpc+AwzqhMPvrV6nF99Q== X-Received: by 2002:aca:f401:: with SMTP id s1-v6mr292189oih.269.1532377268908; Mon, 23 Jul 2018 13:21:08 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id l204-v6sm6939364oia.45.2018.07.23.13.21.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:21:07 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:20 -0500 Message-Id: <20180723201748.25573-72-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::231 Subject: [Qemu-devel] [PATCH 71/99] target/arm: Implement vector shifted SCVF/UCVF for fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson While we have some of the scalar paths for *CVF for fp16, we failed to decode the fp16 version of these instructions. Cc: qemu-stable@nongnu.org Signed-off-by: Richard Henderson Message-id: 20180502221552.3873-2-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell (cherry picked from commit a6117fae4576edfe7a5a5b802a742c33112c0993) Signed-off-by: Michael Roth --- target/arm/translate-a64.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) -- 2.17.1 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c91329249d..f0fa6045e4 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -7159,13 +7159,26 @@ static void handle_simd_shift_intfp_conv(DisasContext *s, bool is_scalar, int immh, int immb, int opcode, int rn, int rd) { - bool is_double = extract32(immh, 3, 1); - int size = is_double ? MO_64 : MO_32; - int elements; + int size, elements, fracbits; int immhb = immh << 3 | immb; - int fracbits = (is_double ? 128 : 64) - immhb; - if (!extract32(immh, 2, 2)) { + if (immh & 8) { + size = MO_64; + if (!is_scalar && !is_q) { + unallocated_encoding(s); + return; + } + } else if (immh & 4) { + size = MO_32; + } else if (immh & 2) { + size = MO_16; + if (!arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { + unallocated_encoding(s); + return; + } + } else { + /* immh == 0 would be a failure of the decode logic */ + g_assert(immh == 1); unallocated_encoding(s); return; } @@ -7173,20 +7186,14 @@ static void handle_simd_shift_intfp_conv(DisasContext *s, bool is_scalar, if (is_scalar) { elements = 1; } else { - elements = is_double ? 2 : is_q ? 4 : 2; - if (is_double && !is_q) { - unallocated_encoding(s); - return; - } + elements = (8 << is_q) >> size; } + fracbits = (16 << size) - immhb; if (!fp_access_check(s)) { return; } - /* immh == 0 would be a failure of the decode logic */ - g_assert(immh); - handle_simd_intfp_conv(s, rd, rn, elements, !is_u, fracbits, size); }