From patchwork Thu Jul 5 16:03:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 141196 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2133615ljj; Thu, 5 Jul 2018 09:20:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd1nXdWgr1aOsj5Cg1mZ7JmYt5nSb8ELd9EP/g8qL23Ihs3gl7BCegk4QAOL3qM83ixx89s X-Received: by 2002:a37:5c01:: with SMTP id q1-v6mr5316136qkb.361.1530807606337; Thu, 05 Jul 2018 09:20:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530807606; cv=none; d=google.com; s=arc-20160816; b=Cu6gYnbWd6UkIGXyAH0R74F/PIjRX/nKk8rg32bwroHTXftFCVVU988jCmRMTNetfm rx6D04E09Ma7Bpfjz3a1LL0vDeOTTLrb/zmCVPwRbYc1+slrhHc5fmOKx0HFwNiEXTDN YkFm5GFZBdo2g2Ns1UOPJ4qLvqn6ZEowMUT8zXVLoAhmUFWcO8TuwXZHlb8aHjRrzKu0 AzX2asr2TX2cfnzHfit15Fc2AkPWl2zkAFSgM6ljxRwueZasU9gcrwG45+H5OeIDuqhb avRK2ombq0IrEfvReD3HJ73EMo4uL1rTjc+UDMqqw/0pSO0iBGV/EugAQyhP8/fD2MUW cPPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=LfGnZuECrY3r6xxBgyILM045lCBDz+C6BvDqvvVhXK0=; b=W0NhRJZHck6HNoXS+zSS53jqp1bwV76Gw6i2GA+rDM1Hh8qEgX2clpLV+GtXuYojz8 13NIU3qd6HhlRztjZRsyiJSJJg2bKuc5cl+kJKUXdnvM+8roA13NzDj9yNVY2zND07xH i+5jfVVcKUc0J4ltt8MR6cpf3dKDb3vcX6j3JvwiIeoBMQXXJr0BkCkVav9a7Ep/MiJ8 l5MIFSXt3ikPJw3k400JtcwiKExVbeZNYAEsex+pix0dVSFNoM9T1/iVsaStoKQxGRhw 6ZL5l+fi/aNcLkbeffi1hClI4cvALc+chamCwE2RKNh9gqUnsQNpK3x6IgCsMWxssrZP KXzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=M55+j2wg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r32-v6si1061553qtr.41.2018.07.05.09.20.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 05 Jul 2018 09:20:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=M55+j2wg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53628 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb6zF-0004B6-KY for patch@linaro.org; Thu, 05 Jul 2018 12:20:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb6jI-0008LV-HC for qemu-devel@nongnu.org; Thu, 05 Jul 2018 12:03:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fb6jH-0007xP-2K for qemu-devel@nongnu.org; Thu, 05 Jul 2018 12:03:36 -0400 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:52415) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fb6jG-0007x2-Rs for qemu-devel@nongnu.org; Thu, 05 Jul 2018 12:03:34 -0400 Received: by mail-wm0-x22c.google.com with SMTP id w16-v6so12070329wmc.2 for ; Thu, 05 Jul 2018 09:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LfGnZuECrY3r6xxBgyILM045lCBDz+C6BvDqvvVhXK0=; b=M55+j2wgBpRgVJf/RtsO56BfVbvz1qVwLUXNzIYEXQ8yrplkGtWfWvVVxRnMtqc2Za PjIsebQ1yvrhANL9I4ziXvHc2BoaH6dXzVleLyeafSRlqeYiSDFGo4uUqJN1XrWR+pgy bOa8xMJu7nmuaVUJYbm+xf1QkDqNo9PXNmD+4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LfGnZuECrY3r6xxBgyILM045lCBDz+C6BvDqvvVhXK0=; b=cfCG2SjW5h/ZmTZhP1c5HEEsnuRfZjwBrpmsQ9O4jrYgYz6wOIcjCmywT9L9LuntzC m/LRelEKKfwwK9N0y6EQwGslHvgzK//Z+iDanKlORPJVzNbNNGlS/GMHPdAZajTe50bS L/BW7sH/DzpSK+Ppi+Jd9MXSUqQzt8n1AqBhn6o5/4JurXD8DDE/eOHihxZTRgx2j96O 4oOe1wKelvtZ7R1HyM4ju7iVVjmB9tn84TJVpsAznmrjxIo21JoXfDO5lyrIJu60zbz5 VPDrxuF1cCKbYIJ26KgarmyHsG046DzRIWraroJdHh5+ZiOeyDgvOZ67sAV/F5eoAEIL yysQ== X-Gm-Message-State: APt69E2v4GnGOyrmG5cVzr/E0gF/VhJTpYMdUplrYuVfOkKsoyLQ8Bju 2cU5ugwKZmE8vSrGgDRHgTjatw== X-Received: by 2002:a1c:6902:: with SMTP id e2-v6mr4897442wmc.95.1530806613693; Thu, 05 Jul 2018 09:03:33 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id j131-v6sm9367820wmb.25.2018.07.05.09.03.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jul 2018 09:03:31 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A61163E06DE; Thu, 5 Jul 2018 17:03:29 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Thu, 5 Jul 2018 17:03:13 +0100 Message-Id: <20180705160329.30386-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180705160329.30386-1-alex.bennee@linaro.org> References: <20180705160329.30386-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [PULL v3 04/20] build-system: remove per-test GCOV reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé -- 2.17.1 diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index f33e5a8423..66ef219f69 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for more information. GCC gcov support ---------------- -``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the -tested code. To use it, configure QEMU with ``--enable-gcov`` option and build. -Then run ``make check`` as usual. There will be additional ``gcov`` output as -the testing goes on, showing the test coverage percentage numbers per analyzed -source file. More detailed reports can be obtained by running ``gcov`` command -on the output files under ``$build_dir/tests/``, please read the ``gcov`` +``gcov`` is a GCC tool to analyze the testing coverage by +instrumenting the tested code. To use it, configure QEMU with +``--enable-gcov`` option and build. Then run ``make check`` as usual. +Reports can be obtained by running ``gcov`` command on the output +files under ``$build_dir/tests/``, please read the ``gcov`` documentation for more information. QEMU iotests diff --git a/tests/Makefile.include b/tests/Makefile.include index 0c0f9509f5..a49282704e 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -897,26 +897,16 @@ GCOV_OPTIONS = -n $(if $(V),-f,) .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF) \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y) $(check-qtest-generic-y),"GTESTER","$@") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) .PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)) $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command, \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER","$*") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) # gtester tests with XML output