From patchwork Tue Jul 3 10:14:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 140932 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp974850ljj; Tue, 3 Jul 2018 03:15:19 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe3S+r1wvCkvFIPYXTgmqHkALTFai4hyHLF/GRliAqBC2Yy1tgFP8jUTGW6E2Piv3RzrDET X-Received: by 2002:a37:2aa6:: with SMTP id q38-v6mr25619058qkq.270.1530612919061; Tue, 03 Jul 2018 03:15:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530612919; cv=none; d=google.com; s=arc-20160816; b=AXOCGKyPv5pyIEtSS6G9Z0Ve8p9bbylEBBj0KfMeGUUQmy4ir+oaW7cCRI8JYaB68U PJytaH0mEzdhgX3yVGYG9Y8vcC2G16Chqp4m7BqiQbvFuTtysh5zwvtAVso3+jIp0s6g D/cFvfs5U0BMjZCMD1ryn9+l1UrCBUq+rcfxaGFriiOlmYV5+dkOXaEiYsIlhCJ4ifxE cS89xLD7bD37G638V0Hru2A6ZlzL+/B73aQmWvtFGgYxpCzekvlF3iIBExvFcqNxyj0U IBG6vz9TahSE5OrkEfWlhs1oGRReqg4WnF9E+Q+JkDv+fsc5uoHIYQ2Oy7RJGfmZv90K AzPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=TExIbWBuPMbpYS2pp5+s5Fy8dg4pQC7MP480dwwVofo=; b=ZbxsAsLYGh68RpETZlxGHjiqHlrwhbl420w+ZWgI/EaE9D0FAtgIp1/ePKUP+4org9 skrPxJdLw4ARkq0mVC3Ata0sRoE7wE126JDfQXErBfEyI+yqrB2XoTlIcGZ8t1ZM/o5c sqVe/TCnCJueh53PAXXuFn7kEC7tN7UtihvrHwu2ZhlRbVkAkB8bgQLBELWVOjB8ZU1A iGY0N8V2jKJ/raxbZ3vLwGRsIwhfEHPO/RDXKICxBknRnNyx33Ifdz1ZkbIypUuljUzK QN+5zSf4ZGJf+4GnMlvZ790yeSKxlNospvI6byQg9rCGSZeqUmzzVw0d306LVmm3QvU5 xYjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=D74jbAFK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id i65-v6si706775qkf.384.2018.07.03.03.15.18 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 03 Jul 2018 03:15:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=D74jbAFK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faIL8-0006mz-DM for patch@linaro.org; Tue, 03 Jul 2018 06:15:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faIKg-0006lH-Sn for qemu-devel@nongnu.org; Tue, 03 Jul 2018 06:14:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faIKf-0008PN-PR for qemu-devel@nongnu.org; Tue, 03 Jul 2018 06:14:50 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:52035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1faIKf-0008OZ-Iq for qemu-devel@nongnu.org; Tue, 03 Jul 2018 06:14:49 -0400 Received: by mail-wm0-x235.google.com with SMTP id s12-v6so1713134wmc.1 for ; Tue, 03 Jul 2018 03:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TExIbWBuPMbpYS2pp5+s5Fy8dg4pQC7MP480dwwVofo=; b=D74jbAFKMDfTYSG5x/XHMM8OP7KBrc59zObIDkwPKAzAn/bC+x3RtZDZ29VKSIAH8V WavnXuA+TnooJMiz2BzO/KQUZt5qS9MSbdb8PRJWBEGxEH1wwOV1pddvx+22RU0OWLtV GF+79cYaZp//0tiv5SnkeMkCnt8JYClpN/h8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TExIbWBuPMbpYS2pp5+s5Fy8dg4pQC7MP480dwwVofo=; b=cusr6IkM51i1cb17IkEfE729RprwG75YklY4VTKYaMC/UGN4S4jBfMZX9EEh9XEMQt I/NB4hFTjDrFpEd6BCkwq76ZRbvZZFdPfnDCcZRYlwJPwQvkNUiQg7LAbrHYMsSVwe11 XguUeaT2uiiMJ519Eji+ZysUhuUxSxuNSWZGn3OQTlCF1U8kvWEBn0KQgZ+gGpU8Yat3 f100xnjLsmzKBzaIk5CzBG4Q+yjqHQ+k3nvm9x6s+jlEOowK+H1gvYxBn7BfMclEO+Dq xOUUKzf3Nc4+KireuXhjeUzM4gN8DfOByQnuAxB7zfYvtJMrC2fV/AuZRTJibQwXePnB 1AUg== X-Gm-Message-State: APt69E3MXix+n9stNKlNxb/Cbzo1wzBDjeJRGzbl6hy7p41Cp9civGvq v5y9kG6bLAW9EL5oViXkuyiZ0g== X-Received: by 2002:a1c:6b51:: with SMTP id g78-v6mr11008283wmc.149.1530612888507; Tue, 03 Jul 2018 03:14:48 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 189-v6sm1670683wmd.17.2018.07.03.03.14.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jul 2018 03:14:46 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id BF0133E0625; Tue, 3 Jul 2018 11:14:44 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Tue, 3 Jul 2018 11:14:27 +0100 Message-Id: <20180703101444.23778-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180703101444.23778-1-alex.bennee@linaro.org> References: <20180703101444.23778-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::235 Subject: [Qemu-devel] [PULL 03/20] build-system: remove per-test GCOV reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: agraf@suse.de, =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, qemu-devel@nongnu.org, f4bug@amsat.org, cota@braap.org, famz@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé -- 2.17.1 diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index f33e5a8423..66ef219f69 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for more information. GCC gcov support ---------------- -``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the -tested code. To use it, configure QEMU with ``--enable-gcov`` option and build. -Then run ``make check`` as usual. There will be additional ``gcov`` output as -the testing goes on, showing the test coverage percentage numbers per analyzed -source file. More detailed reports can be obtained by running ``gcov`` command -on the output files under ``$build_dir/tests/``, please read the ``gcov`` +``gcov`` is a GCC tool to analyze the testing coverage by +instrumenting the tested code. To use it, configure QEMU with +``--enable-gcov`` option and build. Then run ``make check`` as usual. +Reports can be obtained by running ``gcov`` command on the output +files under ``$build_dir/tests/``, please read the ``gcov`` documentation for more information. QEMU iotests diff --git a/tests/Makefile.include b/tests/Makefile.include index e8bb2d8f66..756474814a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -891,26 +891,16 @@ GCOV_OPTIONS = -n $(if $(V),-f,) .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF) \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y) $(check-qtest-generic-y),"GTESTER","$@") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) .PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)) $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command, \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER","$*") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) # gtester tests with XML output