From patchwork Fri Jun 29 20:52:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 140640 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1298440ljj; Fri, 29 Jun 2018 13:55:53 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfaBnWbd3qf11htaLDCSZoyU+cmZXtz3at5L/hlQ54ggnCBUMp50Tw1JowohXAJR/YQ9lbh X-Received: by 2002:ac8:2f31:: with SMTP id j46-v6mr7936709qta.93.1530305753763; Fri, 29 Jun 2018 13:55:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530305753; cv=none; d=google.com; s=arc-20160816; b=ZM9YRF1/jkcsmsrDAxr9+mrsdHwSeRmS3siBu3ekkThqiRwz8j1mQIxudeDU85eXPP gYzLck5MLihjvk+P4Au9LNqPHj2WCMi8md7pzkSrJpv5o34eDASG0yR6uEgbJi09V8w3 XvrxmAWlsgvVxP0l0eM6kHCyE2j884SwePWnza5t0kzGBadl0f3zjWXmfhyZX1CauLyG tLgRKH7dtcONOY9Bkf2ekjlEcSS9+04nyCpbmpugFtpsn0U8b2D78jry3ZJOh+pLWX7B f3KXJUpb1IfF4iIV52Jo4MEur0P2nlCJSWs4x8QSda+PQyVbWfSg8nsbkQurY94xb3vW EM5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=SaqBJE9JwWAeYUlCpH8Vpsa203EW/cTJCIXOIXx65KmCaKogWQNK9AdCzhFctgMeKa X7laYvHJg9ETq9nH8YEdULLPuTj5wTniaoSFqAi+AyuaOCSeROVsec2PMyLHZ1IYC3X7 FelQxydiU8L8WdC0mqfsfYNkEKkgPGu3tMceAes5ctVGCPBuSsG1vBacOhNmTFxlzD92 50zccy+RCFFslNHYlsLUYuGCnQXbDPuxIn7Ss6sOPGrgxc0DOxniQzQFcaJMDbjnYZWM /rfvAHsSLi90PfAsHMVYADQ95CF3eR/jFEtyu/BlNVluSQeaZxuj2M+Gz5zIU8hsDYpe mA5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OxWYGuwF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id a18-v6si1340773qtm.396.2018.06.29.13.55.53 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 29 Jun 2018 13:55:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OxWYGuwF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ0Qr-0002DB-6A for patch@linaro.org; Fri, 29 Jun 2018 16:55:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ0Nk-00083m-Ig for qemu-devel@nongnu.org; Fri, 29 Jun 2018 16:52:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZ0Ni-0006LT-6u for qemu-devel@nongnu.org; Fri, 29 Jun 2018 16:52:40 -0400 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:51028) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZ0Ni-0006KS-00 for qemu-devel@nongnu.org; Fri, 29 Jun 2018 16:52:38 -0400 Received: by mail-wm0-x231.google.com with SMTP id v25-v6so2438475wmc.0 for ; Fri, 29 Jun 2018 13:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=OxWYGuwFPBELCoMU1pnOVNKETE0UgPy4uUe2atw+DBbhOA0pIYaVeRa5edk/yCj0NI //l/8gtSpJPdDxJQ+74Qa4KSM9D53XfsfpmgN5mcvf9l5bvqZL5NzkOtlvCn/uFcFjMd 9CB5nb2WAYRtSrrRgka6C5Hx95OzfxpGqK8j4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=FPXD79xmPJ3RqIqgK17TWrPZHtfBVg+XwEJreMPs2pUFC/WSU0/CsB/CYF6FAIDgis bnYFvMfv5tXSSLJ3lddnYmZlb3DzdSEukeD4HIznsw/kr9Q0EZlWJpbIjVhscFJyP7Tw FOY0ovnQ4bzKVRutp/uTeOWtneuTZqeXCQNZ9ZM1eNE8fU0pTfwqnrdOFCyS0EuI3tKE TpmpXP2lP6j7qABsBarint46Wkw9gr57XX9OQWHg9XS46edSrXYN2DURlMZw+XS02pdO x2IN69NZGL7xeVOukRq5RiyvyJhp/cYJeBDIJfBBQ0JJeOghqOwxx/rzlyeoaGp72nov fKCA== X-Gm-Message-State: APt69E1r0RuRJQDwSnoMqLVe6bzZU9+uCqakC0Wh/bVwD/ZDMI6hIfJh lDzPMnLAmTzbP6oDVsOiwo/5NA== X-Received: by 2002:a1c:5752:: with SMTP id l79-v6mr2596311wmb.103.1530305556741; Fri, 29 Jun 2018 13:52:36 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id y18-v6sm12793200wrn.68.2018.06.29.13.52.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 13:52:34 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 09A2C3E01AC; Fri, 29 Jun 2018 21:52:33 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Fri, 29 Jun 2018 21:52:14 +0100 Message-Id: <20180629205232.27190-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180629205232.27190-1-alex.bennee@linaro.org> References: <20180629205232.27190-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::231 Subject: [Qemu-devel] [PATCH v2 03/21] build-system: remove per-test GCOV reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- docs/devel/testing.rst | 11 +++++------ tests/Makefile.include | 10 ---------- 2 files changed, 5 insertions(+), 16 deletions(-) -- 2.17.1 diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index f33e5a8423..66ef219f69 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for more information. GCC gcov support ---------------- -``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the -tested code. To use it, configure QEMU with ``--enable-gcov`` option and build. -Then run ``make check`` as usual. There will be additional ``gcov`` output as -the testing goes on, showing the test coverage percentage numbers per analyzed -source file. More detailed reports can be obtained by running ``gcov`` command -on the output files under ``$build_dir/tests/``, please read the ``gcov`` +``gcov`` is a GCC tool to analyze the testing coverage by +instrumenting the tested code. To use it, configure QEMU with +``--enable-gcov`` option and build. Then run ``make check`` as usual. +Reports can be obtained by running ``gcov`` command on the output +files under ``$build_dir/tests/``, please read the ``gcov`` documentation for more information. QEMU iotests diff --git a/tests/Makefile.include b/tests/Makefile.include index e8bb2d8f66..756474814a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -891,26 +891,16 @@ GCOV_OPTIONS = -n $(if $(V),-f,) .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF) \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y) $(check-qtest-generic-y),"GTESTER","$@") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) .PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)) $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command, \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER","$*") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) # gtester tests with XML output