From patchwork Wed Jun 20 13:20:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 139338 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp792005lji; Wed, 20 Jun 2018 06:26:53 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIfTE3dcUW+a2Sx8OcGimkYsXN3Ro3hfi5PzjE6iy6duwVyErjLG0FnL30sVY/IdrZpUbMB X-Received: by 2002:a37:5e46:: with SMTP id s67-v6mr17258894qkb.202.1529501213882; Wed, 20 Jun 2018 06:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529501213; cv=none; d=google.com; s=arc-20160816; b=Z8nqbN7Ax9QZnbWfvRqtbV8mtbAJDP0GKRg6f2eKL0FFuLccAPyrnvn1v0at6Tq8cu KTevPHyUPDvJziA3LI9jeT7trWVMh78K5C8tnk9qmP9PDmsrhRghFSCJBVGYXBZ3Nl6i N1dULSyix9NqTTZ+s8Fa3xnnsnJLNdw5/7bqPyQLYIDT1ms6ArNS4dL9OuUIjgRaakqF KyeNc2kcnnp9oTbnTx/FbN+Zwvq6qPjmlqvRxvXAKT8Z08SGHfNBSpqCK9ppMwtHdBa9 m/gSDlvVaUWqbkGXPB/CjtVcXOR+DbvraXGzx4iQk3wymtjOHAjIx4OniR9zsUj1yQjK x+jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=wN6XNRgedUtJrvEhyG6whnN3+CYpPICCDRGCe6ZVR1A=; b=T7X4xeJPygX/H+BMeRyLbiErK233eRcxWc30Ia8iD0HF0vCD6pqcMlAqbkD4+uddvc 2xenFHOrFeN4ftpeqaf082L2V9YZ8oM3Ebnq6QJJ4f6S7RZW+koPj/2FWbymZbaW71HX 02Mtvu61HrBf0cehcAvARvCc8SerARCeaGnELiPA2+QdF0oZexaHUuxQKYjYXKWlQByJ M1Df/L9Ih+ZNQGQMTtcCTNS+3JW9GJk353foI90XMMSjoMNN9W4QRhXjfeRuqlYwmQYk 9lluzJ3gOSUynGaGUe5UlASpyjEPEraqXdOB1afmzHrjpJgYgH4l3Aq2PZuCeP2EqsCU YmCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="KjVd/1Cm"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y48-v6si2407430qta.177.2018.06.20.06.26.53 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 20 Jun 2018 06:26:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="KjVd/1Cm"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVd8P-0004Tm-AH for patch@linaro.org; Wed, 20 Jun 2018 09:26:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVd2N-0007yA-Dy for qemu-devel@nongnu.org; Wed, 20 Jun 2018 09:20:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVd2K-0002kD-1s for qemu-devel@nongnu.org; Wed, 20 Jun 2018 09:20:39 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:50499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVd2J-0002jy-Pz for qemu-devel@nongnu.org; Wed, 20 Jun 2018 09:20:35 -0400 Received: by mail-wm0-x244.google.com with SMTP id e16-v6so5981715wmd.0 for ; Wed, 20 Jun 2018 06:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wN6XNRgedUtJrvEhyG6whnN3+CYpPICCDRGCe6ZVR1A=; b=KjVd/1CmetSEHqdlwRg4woAfBqUMlaoTFbp8h8iQFxs90J7qCizN2TPq5SrsDkuy8U NvcdvBg7D4NmkTTFMVNhrLXzKzPDW/X+2cGcaCD2mNJ9EGhUgQuBnL8OVoTb9Zoq3ts6 2XZ0exQ4D9GkvKQTNxXM+XX/gh9na1h4UNrTo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wN6XNRgedUtJrvEhyG6whnN3+CYpPICCDRGCe6ZVR1A=; b=CPwDNqkFsJ3ngoPbi9K2GZfLwFz5A+Dj23D4PMTJ4ag19zS/eZ3ZSJALrNJ0+KbxKK CQUDClA64Gzkr500PpgChoCRVYFGcQKQSBu+OdzjGgKAG10Jjg7Sp4tpJBI3bjyvvxFC nSmPmD0JxSZpXBwl/PBUjLeQP6PqKspDc4flZEqhufX95MCW82c79PjMIUJs8psLoOsN 32ARZI0ybHEPwF2qByQV7lZ3NWwbbbld8PNLF4STKqD1ZfGhlRgtyJCEARPJExdmjgyw KxMZE7y1kXTsQBGn8monZ/75Mpe6HT2pkP79UCDfLfW2TgSbvKLKRl7wviLCtVV+v4Ao mxSg== X-Gm-Message-State: APt69E3dJ3Nmfw6hVa2fg+pisWVLV/NrcUZCr0pAGLqky5M+4DnraiCm os12SPZd/zzazlsKheGprYtheg== X-Received: by 2002:a1c:9bd0:: with SMTP id d199-v6mr1780948wme.16.1529500834754; Wed, 20 Jun 2018 06:20:34 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id b8-v6sm3103443wrp.50.2018.06.20.06.20.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jun 2018 06:20:34 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id F0DF63E00A7; Wed, 20 Jun 2018 14:20:32 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Wed, 20 Jun 2018 14:20:28 +0100 Message-Id: <20180620132032.12952-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180620132032.12952-1-alex.bennee@linaro.org> References: <20180620132032.12952-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [RFC PATCH 1/5] build-system: remove per-test GCOV reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 11 +++++------ tests/Makefile.include | 10 ---------- 2 files changed, 5 insertions(+), 16 deletions(-) -- 2.17.1 Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index f33e5a8423..66ef219f69 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for more information. GCC gcov support ---------------- -``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the -tested code. To use it, configure QEMU with ``--enable-gcov`` option and build. -Then run ``make check`` as usual. There will be additional ``gcov`` output as -the testing goes on, showing the test coverage percentage numbers per analyzed -source file. More detailed reports can be obtained by running ``gcov`` command -on the output files under ``$build_dir/tests/``, please read the ``gcov`` +``gcov`` is a GCC tool to analyze the testing coverage by +instrumenting the tested code. To use it, configure QEMU with +``--enable-gcov`` option and build. Then run ``make check`` as usual. +Reports can be obtained by running ``gcov`` command on the output +files under ``$build_dir/tests/``, please read the ``gcov`` documentation for more information. QEMU iotests diff --git a/tests/Makefile.include b/tests/Makefile.include index ca91da26cb..55d54bd180 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -891,26 +891,16 @@ GCOV_OPTIONS = -n $(if $(V),-f,) .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF) \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y) $(check-qtest-generic-y),"GTESTER","$@") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) .PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)) $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command, \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER","$*") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) # gtester tests with XML output