From patchwork Thu Jun 14 19:31:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 138614 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp2525562lji; Thu, 14 Jun 2018 12:37:35 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI/Q8RxI0frS7gucz+80aqMjzEuRkWV70ZY1Gyrdth88ClV5aLPywo2OwnReOXu/Bx2dhyq X-Received: by 2002:a37:444c:: with SMTP id r73-v6mr3352671qka.351.1529005055150; Thu, 14 Jun 2018 12:37:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529005055; cv=none; d=google.com; s=arc-20160816; b=P1BiZd/icuhBXAQkoNFiS1S4HgVgToo2X3CLCBivdE/c9I2DXaLCi1kjYpOA/+2PmU AdaPR8ONgqFVj/+PvKqwmEUO4y/qtYK9WC/fO5axq73QowtR5sAzC88dBOsNWP83Nz4v caZJhiNj2+PoW2XF5SUtX58eAoU88qhQcWFwYcBHcn+SzrjGLwWN0FDDlwNkL9Qh34X1 wodS+reJM8BQz0dq8i2c0ucR1/5sztrib3IjeaE8TEi5CzKTJpeKLagVLHp2X/A5yPn0 ZSwbgigKAJklZbVOWl6bg+Uy2uhd0kLizFflPABduT7wx2EZWiTBMG3sA5voJdCaAeDG jO2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=8yfaMikkCfKbwAVcUNBZHbpP9x83/6cBIZm5WMmsiqk=; b=VOQ80Vl+lukfCSER6y8FW284/IOgtncPrBFi7pZPL4n0O61eFj13b8uQLu8vvs5FBZ 9hc75UGW8uNl8dCFS7h8jUOdrtlvwXIdet3S6ZFlI/r28GzfS40tHrkQkvat9En/2K0C VsYk1LHk+1kNzd4IyNs1YwkK5yCtOvVlEIRD667K2fBLtvM40foyyEMc4X/1WGdBMYhp pYIdSjhi6JJfdZJB9dfZOCZDIicLzwRfzrvRGzi73TZ9pzfLk5Z8kiYigRTjmkUft9MY pDgZw1D06/dnlE2wRzZT5aqPR5lWSGvdzKwDNVPslla32YRdw28Uz/QVTXcNF81X4Q9E 221w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hGwOTovT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id d10-v6si5832765qvd.227.2018.06.14.12.37.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 14 Jun 2018 12:37:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hGwOTovT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42356 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTY3q-0002Qg-IE for patch@linaro.org; Thu, 14 Jun 2018 15:37:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTXyP-0006pu-OJ for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:32:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTXyN-0005fI-3u for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:31:57 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:39031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTXyM-0005ex-Tw for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:31:55 -0400 Received: by mail-pg0-x241.google.com with SMTP id w12-v6so3362539pgc.6 for ; Thu, 14 Jun 2018 12:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8yfaMikkCfKbwAVcUNBZHbpP9x83/6cBIZm5WMmsiqk=; b=hGwOTovT4Eb1DSoEb7j/efiKsucQ9bEghPC6qxH0FRRrp6qwy248GGhv/svvXDUqEL OBWG0H+kPzmOHWUNf7FJ1kg7GYhRdxuKI2J1xJZLu8miMhrJI5ocvsbuGu/K28vrOGef 3Z3b5so5qhI3JEgkVcE/DyOy6y1SFbR12A21Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8yfaMikkCfKbwAVcUNBZHbpP9x83/6cBIZm5WMmsiqk=; b=nqLaeIEBR2C02HbDW5C1A0unX6RdIDHf358wlK322MfId3yF+rPndBpCjUDJ/Al/zo 1twVyJgNj31B4WpiKWtE6J9NCbekdneq3En/lBzOI5oG5RPhlUu+X2+ANt5+N2Hs2NT3 hWb7hotG4Cq34pkDuyluE9R7BtANk8/w8766YDG8iwXKXU3diZl5MRAgjpHSmabKNcTm ULRipgVCbn1Qspx27xYLY4rDinJQ60NoDGDxtman7X0iRyKsI+m11LMdIRXh93Blgt1+ +O2bexWv4SAnC6f+Qp/qGP8SHqIwV85H5J9NkaT0XIlbvgggOGN/jn6cxS4MZd3Iv11K Ydlg== X-Gm-Message-State: APt69E3FHD300Ay5FOzM1LXBqk3vMkj2esiig3+xJqfCSYMHxfKZpEq6 ZeNeneK+6wgz84Y4AtArdBirhmO/Wbg= X-Received: by 2002:a62:1747:: with SMTP id 68-v6mr10672774pfx.69.1529004713687; Thu, 14 Jun 2018 12:31:53 -0700 (PDT) Received: from cloudburst.twiddle.net (rrcs-173-198-77-219.west.biz.rr.com. [173.198.77.219]) by smtp.gmail.com with ESMTPSA id x24-v6sm11532184pfj.104.2018.06.14.12.31.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Jun 2018 12:31:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 14 Jun 2018 09:31:30 -1000 Message-Id: <20180614193147.29680-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180614193147.29680-1-richard.henderson@linaro.org> References: <20180614193147.29680-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PULL 01/18] tcg/i386: Use byte form of xgetbv instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, John Arbuckle Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: John Arbuckle The assembler in most versions of Mac OS X is pretty old and does not support the xgetbv instruction. To go around this problem, the raw encoding of the instruction is used instead. Signed-off-by: John Arbuckle Message-Id: <20180604215102.11002-1-programmingkidx@gmail.com> Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 5357909fff..0d0ff524b7 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -3501,7 +3501,10 @@ static void tcg_target_init(TCGContext *s) sure of not hitting invalid opcode. */ if (c & bit_OSXSAVE) { unsigned xcrl, xcrh; - asm ("xgetbv" : "=a" (xcrl), "=d" (xcrh) : "c" (0)); + /* The xgetbv instruction is not available to older versions of + * the assembler, so we encode the instruction manually. + */ + asm(".byte 0x0f, 0x01, 0xd0" : "=a" (xcrl), "=d" (xcrh) : "c" (0)); if ((xcrl & 6) == 6) { have_avx1 = (c & bit_AVX) != 0; have_avx2 = (b7 & bit_AVX2) != 0;