From patchwork Thu Jun 14 19:31:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 138625 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp2533252lji; Thu, 14 Jun 2018 12:45:52 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLBMP6+9OcxNNsjItdg6d5sqyEaK3xZXeDrGD5xGKRD83vkpkNKxYu0T6qeHXgUR7Q4b5P4 X-Received: by 2002:a37:6e83:: with SMTP id j125-v6mr3394096qkc.237.1529005552164; Thu, 14 Jun 2018 12:45:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529005552; cv=none; d=google.com; s=arc-20160816; b=is3kgGMSdECf+gfDtMGKPILPwg1gjQBwXyED0iwTRtmLkDLMnN7TVwMvKom+VaBHUq YZBgERPx1vp0bfVQob7Dhd97put6yX1v6zcygFv1AfKUrhiKbhAqFDpWYdWCbt39DxlJ +XkLgwBidl2/e04TKWVjKyOWwaBOKca7k2dFEBIbi0zzFH6X+dxEKwJUm7h9OhkNZB4Q qTKQscPn3PtnMT196ai9+SgVgxf0RB+tVUerPPOY/dcOXEU8oxYqBV4Z6RTzCa8D3vYc EhVHvzDq7zU6o6meuLMHJmU5Ptd3a9Naueo7iMWUEOfrc5akKOeCk9J0EBv7RgT+LNIV yh/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=JoshgcfdaBoqxlZIOPmVeCLy50LoSRMC+doKT4JGKHw=; b=yUG4QEEx1JyhhiPr0yG/uLsM2eK2DY+pn/m2zoFlc4J67kaoLxe1LL4dJ1kIqFpNd8 N1y9/ZlRGMXKCPaasTfIBbUzbvAP4BzNEuX0gGpY4y9i8vg9Aj7Z8vTOpzs+uQHGGidX 7tOZIzlfJTSUjJ6w3RsHJGEwfgHtl3a9/jL9HTOGiXNyxQNd8CemEQMDeyDrVqYN79Vw oM1lecUhNVvvhQEQsbZmEHqcmbGgjddmquiLcaq3+GYq4w55t+kvg1bm3O1DDLNTJjF1 HQRPN2o7U+BWxteib5fTCrDStP+2fqrHgLcK3kHPLqvQJJSdwVwEQx993xxGEViAGuRs V7qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=iAp7QIBE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id l20-v6si2649646qta.87.2018.06.14.12.45.51 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 14 Jun 2018 12:45:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=iAp7QIBE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTYBr-0001Ih-IF for patch@linaro.org; Thu, 14 Jun 2018 15:45:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTXyt-0007EL-CI for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:32:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTXyr-00063P-4u for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:32:27 -0400 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:35331) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTXyq-000632-V4 for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:32:25 -0400 Received: by mail-pl0-x243.google.com with SMTP id k1-v6so4083772plt.2 for ; Thu, 14 Jun 2018 12:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JoshgcfdaBoqxlZIOPmVeCLy50LoSRMC+doKT4JGKHw=; b=iAp7QIBE+m89xfSn3ObHBb3af3p6IeSknm8PyWzITN8V8PaN7bui/XtOWWEG9abQiR 1c8gjVOVKXqiArS5Mqe1yIEwpPGYZgGabHhRmZ+S/rTM83pF0CdnPBbj8OmGalpG4YeG 6Eh8FN1C7q13WqIx32HA37NGZtyjrW0UJDreg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JoshgcfdaBoqxlZIOPmVeCLy50LoSRMC+doKT4JGKHw=; b=t1JeEap+E2oIVbqbP98iRCTb9raSUWd2UhG04sXhghErFP1ZRG+r7ccuqYf+JyU1Fl ggoYj+wh2qUBDpDWspT4VnYjyX00UzF9tefmZSzgxerJGcWO6hKwGNfRMbXAa5VvntUh MB2HjkTGf8S9cWz1ONZ7Qra38z/wqVeH0RG1QrCm/1uevmGXcOBmCRcWkrBOt9b7n5ar FaVvaihY25YJNNkp2ZYLBR28dK06pM23d8ESp7ezojqd3ppM0oBa26Wt8qTAyuqYbXMP MI2fuzz8ExgrLGKcxW4zbACvaq6N7Ijs47hWwbzN1IAW5XFhpKClwdHKBnwPF4LvdFod kXWA== X-Gm-Message-State: APt69E0tV639E1Jvg2Q9PaJ06A6v2dJgaD4OLFuo94SoX9wXtPRwmI9x 2cJ9emzamw6UmCQUMt+CbX9VtBN+EpU= X-Received: by 2002:a17:902:b488:: with SMTP id y8-v6mr4373354plr.157.1529004743808; Thu, 14 Jun 2018 12:32:23 -0700 (PDT) Received: from cloudburst.twiddle.net (rrcs-173-198-77-219.west.biz.rr.com. [173.198.77.219]) by smtp.gmail.com with ESMTPSA id x24-v6sm11532184pfj.104.2018.06.14.12.32.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Jun 2018 12:32:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 14 Jun 2018 09:31:46 -1000 Message-Id: <20180614193147.29680-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180614193147.29680-1-richard.henderson@linaro.org> References: <20180614193147.29680-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::243 Subject: [Qemu-devel] [PULL 17/18] translate-all: remove tb_lock mention from cpu_restore_state_from_tb X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, "Emilio G. Cota" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" tb_lock was needed when the function did retranslation. However, since fca8a500d519 ("tcg: Save insn data and use it in cpu_restore_state_from_tb") we don't do retranslation. Get rid of the comment. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 1 - 1 file changed, 1 deletion(-) -- 2.17.1 diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 41fbf1055a..dc36349fc7 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -355,7 +355,6 @@ static int encode_search(TranslationBlock *tb, uint8_t *block) } /* The cpu state corresponding to 'searched_pc' is restored. - * Called with tb_lock held. * When reset_icount is true, current TB will be interrupted and * icount should be recalculated. */