From patchwork Fri May 25 13:38:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 136898 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3622827lji; Fri, 25 May 2018 06:56:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIgnkI1CKN7eVuu6Ud3mH/TTbFZi/mYCcI4kHaS8MoXp+o/Y1aOC8U8+Y1TvZ6fcl6YySxU X-Received: by 2002:ac8:3347:: with SMTP id u7-v6mr2241522qta.195.1527256576490; Fri, 25 May 2018 06:56:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527256576; cv=none; d=google.com; s=arc-20160816; b=msWxFYapTJ1bufL8P2LF5YMGmeIc94DNAeEjBrgf94tkOw25tu5koW54y4p2aICOcv xSN15R6nT3ddqz8Q7HhLj+1V8eAvuSXvq5wnu3JYGkO7qNWJVvHxs6P+4BUnGLyjlr3C tO7xgWYT9vDJmtQq0Imyeky/fs/VDs+9NxoUOAYnlaaQrgaAE6T35RU25Jh1J9s/2dpM HuOlR0VUHFtdtlaNjMpcKeYjrfynx8YTziV7niQ/ZIKKc60rpRn5AXIxl9epKGkFjSQg 3nCjUl2SSmexo5ZzIDMxATRNhYOizbIKjWlRtQ00oeMlKas5baud+di+jonr5Aw2z75b TjNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=1KjlQhzDqIP23Us+7ZOKNHKx7NRYOZPWBkrgX5jLsjE=; b=mp1IQCJcJ7enhb5K4F4UVNtd22ONr7lrrvxCaz61dcObhw2Q8od1T4Z/cFWqUhq+BW HgR8L165Prgo6KIoPWnZSZrIuRy9zmkb+DTrFoKZ6u6eyfEP3OSBct5XVwRiSvo9aeDe DrrL1RPnypFaQ7nGCI88/4h9OIDorJwX/8GAJd57nTK6+4D3YIGnzkhRYxjsAF4TrzOc UrESzOge7zu6kKNFRmF+nS2We1G/tBRkkt6jcDOQMz6L9zOk6tGyqn8n+cAwpM0hV48B fSbyAeaUqRGHgdi8ADeKJSCMTsTsGtxObwSRwr0aqbRRKZEOZS/QqQSw5Pw/lhD7UyJt I0Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=AXaAiw2E; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id g11-v6si2744773qtg.81.2018.05.25.06.56.16 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 25 May 2018 06:56:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=AXaAiw2E; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMDCa-0002di-0W for patch@linaro.org; Fri, 25 May 2018 09:56:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMD1b-00023s-1J for qemu-devel@nongnu.org; Fri, 25 May 2018 09:44:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMD1Z-0008SI-Ik for qemu-devel@nongnu.org; Fri, 25 May 2018 09:44:55 -0400 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:50759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMD1Z-0008S5-91 for qemu-devel@nongnu.org; Fri, 25 May 2018 09:44:53 -0400 Received: by mail-wm0-x22a.google.com with SMTP id t11-v6so14616878wmt.0 for ; Fri, 25 May 2018 06:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1KjlQhzDqIP23Us+7ZOKNHKx7NRYOZPWBkrgX5jLsjE=; b=AXaAiw2EbjdgLmZtdgW1MvJ+/XTu9EWxJYpBUVY3HH8hRcy3dyWZFZBlqPFPDn84h9 kvQOaeKiwJLU9bbgngj3741uQrOJ4m9kXDZ5pJKeej7GR2d3TDvioHKM/dEFwar1Mll/ KXYMTzOdEPLPtEXb7PNdUS1u/v9kgm4PiFfLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1KjlQhzDqIP23Us+7ZOKNHKx7NRYOZPWBkrgX5jLsjE=; b=OqjANDLVjRCrI0Wkz3BnT68TkrWJCxeLU/u+7FxEN8proEZiB1UKIInt7dmoGkLO8o cYYWgOROYmv/oluID/MLIv/4YNilek5afEj73wt+FGzFMq0o54E3sLp2ryyeqxa2QfbW 4WCPmzyIXXHmD5piFNahLgwzFqRzkfnyl1zIPXDvaWrjnkW7G1hS9mmPBxgO+WJTJvrF Nh3vaFMDKd3oxnEpKiLoN/6fyMQqbf9soay3nr2rTx2ph30XbHCDvmESbIvWGR/U1ssK f2auPhNXCBtg48562KUpZZEoz3VtLfnKm8Zj7qnZQqnLHehd5XB0n153mAAmyHQjTW3h OprQ== X-Gm-Message-State: ALKqPweuk4CDNFEAeEn0gMWFAnbk+8CTHE3hc8t6FZV9qWF6z9/oDQJU C6r0Mt3KMy55D2bqnqvLnNF9QQ== X-Received: by 2002:a1c:1047:: with SMTP id 68-v6mr1823956wmq.132.1527255892060; Fri, 25 May 2018 06:44:52 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 5-v6sm12364088wre.41.2018.05.25.06.44.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 May 2018 06:44:49 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 634213E08BB; Fri, 25 May 2018 14:38:52 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Fri, 25 May 2018 14:38:16 +0100 Message-Id: <20180525133851.27161-15-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180525133851.27161-1-alex.bennee@linaro.org> References: <20180525133851.27161-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22a Subject: [Qemu-devel] [PATCH v5 14/49] tests/tcg/multiarch: enable additional linux-test tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Un-comment the remaining tests. I removed the itimer value tests because I'm fairly sure a re-arming timer will always have a different value in it when you grab it. I've also fixed up the clone thread flags as QEMU will only allow a clone to use flags which match glibc. However the test is still racey so it remains disabled by default - it can be run by passing any additional parameters on the command line. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v3 - make clone flags match CLONE_THREAD_FLAGS v4 - disable test_clone for default case --- tests/tcg/multiarch/linux-test.c | 51 +++++++++++++++++++++----------- 1 file changed, 33 insertions(+), 18 deletions(-) -- 2.17.0 diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index 4457bd04ba..6f2c531474 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -16,6 +16,7 @@ * You should have received a copy of the GNU General Public License * along with this program; if not, see . */ +#define _GNU_SOURCE #include #include #include @@ -58,8 +59,8 @@ static void error1(const char *filename, int line, const char *fmt, ...) static int __chk_error(const char *filename, int line, int ret) { if (ret < 0) { - error1(filename, line, "%m (ret=%d, errno=%d)", - ret, errno); + error1(filename, line, "%m (ret=%d, errno=%d/%s)", + ret, errno, strerror(errno)); } return ret; } @@ -216,6 +217,7 @@ static void test_fork(void) pid = chk_error(fork()); if (pid == 0) { /* child */ + sleep(2); exit(2); } chk_error(waitpid(pid, &status, 0)); @@ -320,7 +322,6 @@ static void test_socket(void) chk_error(close(server_fd)); } -#if 0 #define WCOUNT_MAX 512 static void test_pipe(void) @@ -355,7 +356,7 @@ static void test_pipe(void) } if (FD_ISSET(fds[1], &wfds)) { ch = 'a'; - chk_error(write(fds[0], &ch, 1)); + chk_error(write(fds[1], &ch, 1)); wcount++; } } @@ -387,28 +388,41 @@ static int thread2_func(void *arg) return 0; } -void test_clone(void) +static void wait_for_child(pid_t pid) +{ + int status; + chk_error(waitpid(pid, &status, 0)); +} + +/* For test_clone we must match the clone flags used by glibc, see + * CLONE_THREAD_FLAGS in the QEMU source code. + */ +static void test_clone(void) { uint8_t *stack1, *stack2; - int pid1, pid2, status1, status2; + pid_t pid1, pid2; stack1 = malloc(STACK_SIZE); pid1 = chk_error(clone(thread1_func, stack1 + STACK_SIZE, - CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, "hello1")); + CLONE_VM | CLONE_FS | CLONE_FILES | + CLONE_SIGHAND | CLONE_THREAD | CLONE_SYSVSEM, + "hello1")); stack2 = malloc(STACK_SIZE); pid2 = chk_error(clone(thread2_func, stack2 + STACK_SIZE, - CLONE_VM | CLONE_FS | CLONE_FILES | SIGCHLD, "hello2")); + CLONE_VM | CLONE_FS | CLONE_FILES | + CLONE_SIGHAND | CLONE_THREAD | CLONE_SYSVSEM, + "hello2")); - while (waitpid(pid1, &status1, 0) != pid1); + wait_for_child(pid1); free(stack1); - while (waitpid(pid2, &status2, 0) != pid2); + wait_for_child(pid2); free(stack2); + if (thread1_res != 5 || thread2_res != 6) error("clone"); } -#endif /***********************************/ @@ -449,12 +463,10 @@ static void test_signal(void) it.it_value.tv_usec = 10 * 1000; chk_error(setitimer(ITIMER_REAL, &it, NULL)); chk_error(getitimer(ITIMER_REAL, &oit)); - if (oit.it_value.tv_sec != it.it_value.tv_sec || - oit.it_value.tv_usec != it.it_value.tv_usec) - error("itimer"); while (alarm_count < 5) { usleep(10 * 1000); + getitimer(ITIMER_REAL, &oit); } it.it_interval.tv_sec = 0; @@ -463,9 +475,6 @@ static void test_signal(void) it.it_value.tv_usec = 0; memset(&oit, 0xff, sizeof(oit)); chk_error(setitimer(ITIMER_REAL, &it, &oit)); - if (oit.it_value.tv_sec != 0 || - oit.it_value.tv_usec != 10 * 1000) - error("setitimer"); /* SIGSEGV test */ act.sa_sigaction = sig_segv; @@ -503,10 +512,16 @@ static void test_shm(void) int main(int argc, char **argv) { test_file(); + test_pipe(); test_fork(); test_time(); test_socket(); - // test_clone(); + + if (argc > 1) { + printf("test_clone still considered buggy\n"); + test_clone(); + } + test_signal(); test_shm(); return 0;