From patchwork Fri May 4 18:30:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135021 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp381140lji; Fri, 4 May 2018 11:34:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZruFtBMVXOoCXdGA41JDFKyhr0JJ/iVcOKZHTkGPvU73b0wq+c0xvyke65N5LeIQ1sM6dUy X-Received: by 2002:ac8:2ff6:: with SMTP id m51-v6mr24823635qta.265.1525458855262; Fri, 04 May 2018 11:34:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525458855; cv=none; d=google.com; s=arc-20160816; b=O6oERX7jxIBEI4wIkAGK9Zf3DxkesspatJ6jwhd/8YzkeBEUEVV9gVuh8zUq4axEfN GIsvQNiZXA7ixSiw5lwD3/g4Zdg4TfjJ6u6vFmW5md6Z6/y7o6YpwOMYJiRMx3qAVAyg vGNWZ+5MzN93sOHq+VR3KwT5hStgnm7lkKhC9MI3cY/3kT0D22e2g/It/NY9uBuWBavE VNf++62cTOCOAspTb/ROcIOxAoV2TQPNaJN72cwXFFP/SnH18KooU1zOGeXDRL6NpTLe AScW4wsBy1YNNMYPjEf2sM8JAtOG1dhKwcvic2BNHl6CNMrlJJvOdR9EJvpl8xZCs4oS dumg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=8liVC1EvOhXEjQqPTbUiUiso0NQryYqSK+kZmW2XosI=; b=FuuMivByENKDBmQK4HmgD7TlH7+JOQ9PgFIUqvk4attEJgLX7evu2hZcWweOBV1XU+ w1FXHVnMmuQFZSHOBEXuT2Fk4K9GvkrBptNJAQuKvXT2UX+tW+BLdB5kgUGlT8avdhHG btsfVIVEC9YkLy6o8OBD0hX5nphGvcayNv9Dk4f5PDenWqXJCnl1V5Uoqdj7DDAIIjoJ gZURS4Zj4PpJQtWx9a3hGX0a919F8kQIdMMnMNLRkS+Kop6qwO/ouS/oKTPtBVW3mC0D CsTtuh/jrq3IUTQNTwYbaTMpCTiPfUps7ryPumBUFSlS3JdxyL2ztusxzaefLNAzbpCP 2MRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=auTPZvxO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id o62si6086263qke.305.2018.05.04.11.34.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 04 May 2018 11:34:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=auTPZvxO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35993 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEfX4-000253-K6 for patch@linaro.org; Fri, 04 May 2018 14:34:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEfTR-0007Sk-K7 for qemu-devel@nongnu.org; Fri, 04 May 2018 14:30:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEfTQ-00014h-De for qemu-devel@nongnu.org; Fri, 04 May 2018 14:30:29 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:40582) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEfTQ-00014J-5n for qemu-devel@nongnu.org; Fri, 04 May 2018 14:30:28 -0400 Received: by mail-pg0-x241.google.com with SMTP id l2-v6so15967712pgc.7 for ; Fri, 04 May 2018 11:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8liVC1EvOhXEjQqPTbUiUiso0NQryYqSK+kZmW2XosI=; b=auTPZvxOL43cPk1dHmLGtoavykFo4zabs/busrfaqJA9CjiIIPvXbcsnQ5zh9s6p9o 3zkNeGOpxsLrzsejsckcj4frw62YLwWTgQmbcdDD9orA4UN0RAMoHJpt0jFooI8NX2oq JjxHRKbojPIlaiLTIokkks9XXUlUxggcQ/wbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8liVC1EvOhXEjQqPTbUiUiso0NQryYqSK+kZmW2XosI=; b=IRTH6mExWD3voyWgG4u2ALloU0x4YehfcWvTfr5bgcBORvpvg2M4z5ZMxHnR96hiBJ jF5J+oTbDUNRngx+3aSL1CpMowEolF55uhAjoAquH5m1MZWjLXV9GZ9VOfIsXooOKBBT l1qIuM+RjJOTQdZSAVArATGHSyGZVPTSsBeQvK6VqXHUu58ZCRIbw9os2w43z23stKdO rbeP2JjPobXkRi61oA9RE1vC9nht+LN0a59+4NB3d0Z/mfmpIZ5jKinsSuYudOFx2aP8 rb1OW530YVGdG7qgsDToQSwtfgvokVYmwjTd3Yt5r+w5s7VGAuy1JoMdxy/pV435QdHt SWUQ== X-Gm-Message-State: ALQs6tDJwTBpPCU2qpL0nilObqUBc/14fbpc6hiBHAfVP/a5GkDGF7wW +54rekzKvoVqJwcf+r6pok2qUClW24A= X-Received: by 2002:a65:5d0f:: with SMTP id e15-v6mr23701692pgr.119.1525458626756; Fri, 04 May 2018 11:30:26 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id r8-v6sm16987413pgn.2.2018.05.04.11.30.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 May 2018 11:30:25 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 4 May 2018 11:30:13 -0700 Message-Id: <20180504183021.19318-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180504183021.19318-1-richard.henderson@linaro.org> References: <20180504183021.19318-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PATCH v2 02/10] target/arm: Use new min/max expanders X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The generic expanders replace nearly identical code in the translator. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 46 ++++++++++++++-------------------------------- 1 file changed, 14 insertions(+), 32 deletions(-) -- 2.14.3 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index bff4e13bf6..d916fea3a3 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -6021,15 +6021,18 @@ static void disas_simd_across_lanes(DisasContext *s, uint32_t insn) tcg_gen_add_i64(tcg_res, tcg_res, tcg_elt); break; case 0x0a: /* SMAXV / UMAXV */ - tcg_gen_movcond_i64(is_u ? TCG_COND_GEU : TCG_COND_GE, - tcg_res, - tcg_res, tcg_elt, tcg_res, tcg_elt); + if (is_u) { + tcg_gen_umax_i64(tcg_res, tcg_res, tcg_elt); + } else { + tcg_gen_smax_i64(tcg_res, tcg_res, tcg_elt); + } break; case 0x1a: /* SMINV / UMINV */ - tcg_gen_movcond_i64(is_u ? TCG_COND_LEU : TCG_COND_LE, - tcg_res, - tcg_res, tcg_elt, tcg_res, tcg_elt); - break; + if (is_u) { + tcg_gen_umin_i64(tcg_res, tcg_res, tcg_elt); + } else { + tcg_gen_smin_i64(tcg_res, tcg_res, tcg_elt); + } break; default: g_assert_not_reached(); @@ -9931,27 +9934,6 @@ static void disas_simd_3same_logic(DisasContext *s, uint32_t insn) } } -/* Helper functions for 32 bit comparisons */ -static void gen_max_s32(TCGv_i32 res, TCGv_i32 op1, TCGv_i32 op2) -{ - tcg_gen_movcond_i32(TCG_COND_GE, res, op1, op2, op1, op2); -} - -static void gen_max_u32(TCGv_i32 res, TCGv_i32 op1, TCGv_i32 op2) -{ - tcg_gen_movcond_i32(TCG_COND_GEU, res, op1, op2, op1, op2); -} - -static void gen_min_s32(TCGv_i32 res, TCGv_i32 op1, TCGv_i32 op2) -{ - tcg_gen_movcond_i32(TCG_COND_LE, res, op1, op2, op1, op2); -} - -static void gen_min_u32(TCGv_i32 res, TCGv_i32 op1, TCGv_i32 op2) -{ - tcg_gen_movcond_i32(TCG_COND_LEU, res, op1, op2, op1, op2); -} - /* Pairwise op subgroup of C3.6.16. * * This is called directly or via the handle_3same_float for float pairwise @@ -10051,7 +10033,7 @@ static void handle_simd_3same_pair(DisasContext *s, int is_q, int u, int opcode, static NeonGenTwoOpFn * const fns[3][2] = { { gen_helper_neon_pmax_s8, gen_helper_neon_pmax_u8 }, { gen_helper_neon_pmax_s16, gen_helper_neon_pmax_u16 }, - { gen_max_s32, gen_max_u32 }, + { tcg_gen_smax_i32, tcg_gen_umax_i32 }, }; genfn = fns[size][u]; break; @@ -10061,7 +10043,7 @@ static void handle_simd_3same_pair(DisasContext *s, int is_q, int u, int opcode, static NeonGenTwoOpFn * const fns[3][2] = { { gen_helper_neon_pmin_s8, gen_helper_neon_pmin_u8 }, { gen_helper_neon_pmin_s16, gen_helper_neon_pmin_u16 }, - { gen_min_s32, gen_min_u32 }, + { tcg_gen_smin_i32, tcg_gen_umin_i32 }, }; genfn = fns[size][u]; break; @@ -10516,7 +10498,7 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) static NeonGenTwoOpFn * const fns[3][2] = { { gen_helper_neon_max_s8, gen_helper_neon_max_u8 }, { gen_helper_neon_max_s16, gen_helper_neon_max_u16 }, - { gen_max_s32, gen_max_u32 }, + { tcg_gen_smax_i32, tcg_gen_umax_i32 }, }; genfn = fns[size][u]; break; @@ -10527,7 +10509,7 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) static NeonGenTwoOpFn * const fns[3][2] = { { gen_helper_neon_min_s8, gen_helper_neon_min_u8 }, { gen_helper_neon_min_s16, gen_helper_neon_min_u16 }, - { gen_min_s32, gen_min_u32 }, + { tcg_gen_smin_i32, tcg_gen_umin_i32 }, }; genfn = fns[size][u]; break;