From patchwork Fri Apr 6 13:14:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 132912 Delivered-To: patch@linaro.org Received: by 10.80.173.174 with SMTP id a43csp652447edd; Fri, 6 Apr 2018 06:15:07 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/hiqUkdBK+efiHGBT8ndqkADD7/ypMNpI07ZMm9fP+7NpKLe6ufpLaq/nQJ7GaQSSydqsy X-Received: by 10.55.33.2 with SMTP id h2mr33747118qkh.310.1523020507050; Fri, 06 Apr 2018 06:15:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523020507; cv=none; d=google.com; s=arc-20160816; b=vuhZ1fIhNcz4g5E4Z3kQN9NR/Fzmsw/C+oyPmuUSSUO/ULMYuS8ZatoU5awmVI3Zw9 Ku3NlZkz2/TovU0jtOR66cmgo74fvOULQ6nC+XubLC06AD6/TSaX/qAJTTjLduC2ZJ38 8S72NXa4JjAzX4rqKxrTlJdDcnKUv15pxken1zIVizX3OqFSD5xoeloARm9fN2R4kSy7 e2udI1K51tdbJd2cLejj1vORKrcM3V6tkAT3K+cRs/unsq7p+WbYWaMnk6bcZKgaa9TV li+gdYuE4mYGoZGk0q+5S+9dcjH4VpaP/x9TtWMrLe+UKfW+B74ektaDVoLhxCjzNsgu N3Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=7PSLwJZytKSYQ+XQ4hHI9WZ5obc4c71XhcS4eIWc3TU=; b=F0CBs3pZlTuVbPKUy0XeLsr4ZmvvEajU7j2IdwraQ0Pu8siIWhxO1ZiK+0JTnbWep1 QNLpDXisiLKVD2UfLC11EswZLGeKLqU48Z/5tqHRbiZ24DAq7co/FkFjJKeE233wiKSO rc1EcneNgjNZ+Foxjcrv0YH7NBbKrO3uqtndXAydUDQORdEUGiVefRukKFE/hyowE/V4 cWyXdDtDrddehkYrbyWa32Befkm+yOWUAEeg2W20LBbU885vOFy2UniYjzul25cBOSJ9 PFTmQj8Njc/h44vrKCOBcX2HoDemtp6H7GfmgpEMmQQ3LvzrHh5EM80lTfg9jm0Tn82a OziQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VViosHxa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r68si11194755qkf.465.2018.04.06.06.15.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 06 Apr 2018 06:15:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VViosHxa; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4RCs-0005pJ-Ge for patch@linaro.org; Fri, 06 Apr 2018 09:15:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4RCU-0005nG-AB for qemu-devel@nongnu.org; Fri, 06 Apr 2018 09:14:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4RCT-0001qU-Ei for qemu-devel@nongnu.org; Fri, 06 Apr 2018 09:14:42 -0400 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:40605) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4RCT-0001qD-A5 for qemu-devel@nongnu.org; Fri, 06 Apr 2018 09:14:41 -0400 Received: by mail-pf0-x242.google.com with SMTP id y66so701118pfi.7 for ; Fri, 06 Apr 2018 06:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7PSLwJZytKSYQ+XQ4hHI9WZ5obc4c71XhcS4eIWc3TU=; b=VViosHxaNgEGtuy/4qCr8y7GXI9a5YUw5OltbHt4oGkmCr4QGVYBXEWmfLiaqfo306 yXwC+eRibXJWvk+aNqS2LZM1xrBL4acCJsm7F0cAA2R2sNph2xslowLChCJm9iuYB/le W5iQEAyissh0dnsGvONOEtwucrmWBdx//jC2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7PSLwJZytKSYQ+XQ4hHI9WZ5obc4c71XhcS4eIWc3TU=; b=qNP/X69JPpucsOHTdmsg+9ZpuECYKV9yneaIofALq4juxF0HXvKOFCVklYHmoy1iFj TxoeJvn/TdxhcX6doM4iV/X5VfJJrAWkgX4pJoXZpzVhx6mQ2m8Q49KGPQul+hXE53XX 15AjMsx9qtm7uxC8LeKyjkyJxJoTnpl20PPE9FnOD1LE+1konAYpFfB4tR2hACZbGpBb /RI9m5TcxMuge0B8x0JkkSQ2Hl+I+K13rMX65hnxLANq+QWIc/ODE8wF3TRi21PonT5/ YSlJTelNuYu4akH+FD9DDAqmGelzVC5aH0OC3v7nECWiMeU7C1c/nKgQVMIHWPc6OH52 8nqA== X-Gm-Message-State: AElRT7EFSB6opyXUPpnNRHn++Axnu60ZXa5B/4WSuaqi5L8vKhrVW4EV iL944Ftx+0ClS+ifYgpWKRdDEGj8Qac= X-Received: by 10.99.114.27 with SMTP id n27mr17360556pgc.177.1523020480104; Fri, 06 Apr 2018 06:14:40 -0700 (PDT) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id w10sm7346993pfk.26.2018.04.06.06.14.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Apr 2018 06:14:39 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 6 Apr 2018 23:14:30 +1000 Message-Id: <20180406131430.23432-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180406131430.23432-1-richard.henderson@linaro.org> References: <20180406131430.23432-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PULL for-2.12 1/1] tcg: Fix out-of-line generic vector compares X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" A mistake in the type passed to sizeof, that happens to work when the out-of-line fallback itself is using host vectors, but fails when using only the base types. Tested-by: Emilio G. Cota Reported-by: Emilio G. Cota Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime-gvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3 diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c index 8bf8d63912..90340e56e0 100644 --- a/accel/tcg/tcg-runtime-gvec.c +++ b/accel/tcg/tcg-runtime-gvec.c @@ -705,7 +705,7 @@ void HELPER(NAME)(void *d, void *a, void *b, uint32_t desc) \ { \ intptr_t oprsz = simd_oprsz(desc); \ intptr_t i; \ - for (i = 0; i < oprsz; i += sizeof(vec64)) { \ + for (i = 0; i < oprsz; i += sizeof(TYPE)) { \ *(TYPE *)(d + i) = DO_CMP0(*(TYPE *)(a + i) OP *(TYPE *)(b + i)); \ } \ clear_high(d, oprsz, desc); \