From patchwork Thu Mar 15 17:38:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 131836 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp1409932ljb; Thu, 15 Mar 2018 10:42:31 -0700 (PDT) X-Google-Smtp-Source: AG47ELuYawcetV55259+Wo2wNS2GDSNg4go3ASl0KNVJ67KNBMiFTH0quA/oFeau8+NHT+VXKlyx X-Received: by 10.200.28.90 with SMTP id j26mr14256411qtk.188.1521135751869; Thu, 15 Mar 2018 10:42:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521135751; cv=none; d=google.com; s=arc-20160816; b=tk8gbdaiSkLNRk+zh3PnDyMKDSIQI7ioh726lmmekcZxZZ7LZmoqN5AJB617uRWeD6 q1wVnWPZL9ANiSjDgNlz/pUf+JdYZUqnepbWhCwyUTtD2Fl+FUEAHS1Og5E+pjnEai6d yziSHAID+oOkLkPzn9+AXLCE4yXn05vtwFUOvMmSRGfdvgTVie2rqEuRSJIOmATlnq1R KS5Igosbh7cvAuDmtcf4orbK7DlLJNLMuvn7+KA+EYIlPo/NzO+RAb+7s2FRn+yglx3R 0qhHLPpmZLom7Tu0TBfoEpnMKajXizaLy0/eYvb0kMxTcX3gc82Oq3cLuxWEI9x7fBNK wtNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=dDDlrROqkaZQZi5Yc/LAlOF0DHxsXVz9otaL0UYlmQE=; b=IulWmAZYeh+3g5tThEZ2g5TSEKD1T/Yg3wOq9TlWIm4fD5L73LA5RqwzUGBe999bSt SNNx1l13WdTIFQL60gcZ7xYBHhDiUVhOSetwSXuSYTqPeDgGkC4gnYWAeF9Bu4jCUrG+ yz16LlhsgrJbGvGCBulCamg/2c3DvkKkNBa7TwLUNLIwnUhGKB1O1QTr9x6ukbACCgA9 3TGduyvzvfoyO3Unm75nhh4FJI3VAsgYASBpiNzlpc9cuPGKWDuVgnLPjCl2Go1za66k IcO9s1IYgRdZb3SdwhQZmYjhIFKoD2PkMeObeLusfkZLy4/OZnoYg1YoCnu5BYSFC9Eu mHJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VLge01cr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 82si5192162qko.238.2018.03.15.10.42.31 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 15 Mar 2018 10:42:31 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VLge01cr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewWtb-0005Jc-BA for patch@linaro.org; Thu, 15 Mar 2018 13:42:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewWqM-0003QV-CY for qemu-devel@nongnu.org; Thu, 15 Mar 2018 13:39:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewWqL-000535-CM for qemu-devel@nongnu.org; Thu, 15 Mar 2018 13:39:10 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:37452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewWqL-00052a-6H for qemu-devel@nongnu.org; Thu, 15 Mar 2018 13:39:09 -0400 Received: by mail-pf0-x241.google.com with SMTP id h11so3095123pfn.4 for ; Thu, 15 Mar 2018 10:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dDDlrROqkaZQZi5Yc/LAlOF0DHxsXVz9otaL0UYlmQE=; b=VLge01crjOn9yhpsYpxiw8dMPzcnf+05ew8M4EcvWaW9ktju69KETiC18KO0DAZjrY RhMLo7lRST4Ge2afuDDT76pqgfkPWM2MigMOZTdFj8bduX3uLvsUKRPtccDzIebIrSUW bn3b4AqZs7yfMs10j3tgq95d+DR96NxYScAqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dDDlrROqkaZQZi5Yc/LAlOF0DHxsXVz9otaL0UYlmQE=; b=dZa8XEpmSmLpfUNwePidwrNAwy7TGesRFjs3k2AD0Ugu1UkRejqD14gRj8om3BHbYD j3YqVbNZoA7xSUIUy1Sw0PFkx8/DovLgDb9ulctg6Irq8Zxg2pKgKGiiMNWWNKEiY8KB Jwybxfzja29pWcrsoZwuZJEpQsotcylOuhbUgMz02VK5hzuZghVQSH/mGrf9AAzgOe2J jX3KhOblFNp/nZRqvpqPXQtaj6oUfdP9aLYpQmZmZ31TQlDvV+J+utM3AcGBcnH0VnSj exI8KLSdleQJqvOinh9pgTp8IWXVNIClmQCvqcBMRpHCxz3WELhirUdfQNDZeCrYFRnN sXTw== X-Gm-Message-State: AElRT7GNqUH0UnA3DHY+V/yfrw6rpppjRCBPSUI+hj3EKeSmEp6uKZ6p f4ZuqKjDVpXn5qUK6q1FKECheKaxwCA= X-Received: by 10.101.97.139 with SMTP id c11mr7309179pgv.435.1521135547788; Thu, 15 Mar 2018 10:39:07 -0700 (PDT) Received: from cloudburst.twiddle.net ([182.239.119.25]) by smtp.gmail.com with ESMTPSA id f6sm9684571pgo.58.2018.03.15.10.39.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 10:39:06 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 16 Mar 2018 01:38:54 +0800 Message-Id: <20180315173855.22456-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180315173855.22456-1-richard.henderson@linaro.org> References: <20180315173855.22456-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PULL v2 2/3] tcg/i386: Support INDEX_op_dup2_vec for -m32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Unknown why -m32 was passing with gcc but not clang; it should have failed for both. This would be used for tcg_gen_dup_i64_vec, and visible with the right TB and an aarch64 guest. Reported-by: Max Reitz Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.14.3 diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index fc05909d1d..d7e59e79c5 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -2696,6 +2696,12 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, case INDEX_op_x86_packus_vec: insn = packus_insn[vece]; goto gen_simd; +#if TCG_TARGET_REG_BITS == 32 + case INDEX_op_dup2_vec: + /* Constraints have already placed both 32-bit inputs in xmm regs. */ + insn = OPC_PUNPCKLDQ; + goto gen_simd; +#endif gen_simd: tcg_debug_assert(insn != OPC_UD2); if (type == TCG_TYPE_V256) { @@ -3045,6 +3051,9 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpcode op) case INDEX_op_x86_vperm2i128_vec: case INDEX_op_x86_punpckl_vec: case INDEX_op_x86_punpckh_vec: +#if TCG_TARGET_REG_BITS == 32 + case INDEX_op_dup2_vec: +#endif return &x_x_x; case INDEX_op_dup_vec: case INDEX_op_shli_vec: