From patchwork Fri Mar 2 18:56:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 130580 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp1628920lja; Fri, 2 Mar 2018 11:28:19 -0800 (PST) X-Google-Smtp-Source: AG47ELurVGvYhpSJpIBRuTfXsMKvTddOIkk0aDdb6TmMb5uWK0tjyL1K252r/fk7wHTsvUV8tbwj X-Received: by 10.129.154.10 with SMTP id r10mr4469051ywg.163.1520018899102; Fri, 02 Mar 2018 11:28:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520018899; cv=none; d=google.com; s=arc-20160816; b=gwAyNcCs6O3AhCCEx9xX/QVess+T2I4xiKAdv6Vy8mxGT9zAZ8tqZ6ESZDTS8pQ7XN h4kXeoUH9jkIKWqFG13ygWZxpRlA1LeQt8y5XqjjW+6JskVo705YlklO+5EnTcCZDmsR R6TForecHCDz+Z4Cfrtr20msFZL5NfHqWJTf52+YkBlwhYl50OkVWmknykRMqJ+ttV1f R4ncJ30H1ZUw4DkncIdCfV1XqSGaiQ5sG9gmfCyrpmenNRI7+KvxBtEZ1r0o0JgQkj6w XKSNUS6+lWefSVEt7z81FER1x7ZvraQkWyYQXwE/5y71OGEP56x+shJOI+YsTD5Hy756 88Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=dDDlrROqkaZQZi5Yc/LAlOF0DHxsXVz9otaL0UYlmQE=; b=u+9Dloi2SqYP0nqMI10moh9sKIrnTYlQNxQBZ4pe4Ug15VCdTzrbJifPE+IeMcRXwv zYI/ErJ2ZiG9XK6yZMyntb4ULVMRVwcCNEAohlvHYDbniv+8mqY223iph6/FeRU1oK/s Dlq7iBdct39Hx2nsaXLpuKxsuVJsQefURQYXrq4urepcYHZQXKJBXPtcPdOzjhJ1NYJw uPjmbnvEbdktrvz2L/xt0TRrEJLk3bMAJQDsja6IjhODQYTxDwRHgK3KxzcjroKtnJnn URmcm5Q+DZShpad180CBSJKwxoUXd4I9IgR8PZL4YK2vDZS7UzYbZDhybTlRXeTFOAct jDdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=N1NmFM7j; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id u124si1158535ywc.386.2018.03.02.11.28.18 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 02 Mar 2018 11:28:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=N1NmFM7j; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erqLp-0005yo-Nv for patch@linaro.org; Fri, 02 Mar 2018 14:28:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erpr5-0002DN-Mt for qemu-devel@nongnu.org; Fri, 02 Mar 2018 13:56:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erpr5-0003Zs-0Y for qemu-devel@nongnu.org; Fri, 02 Mar 2018 13:56:31 -0500 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]:46694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1erpr4-0003Z5-R6 for qemu-devel@nongnu.org; Fri, 02 Mar 2018 13:56:30 -0500 Received: by mail-pl0-x241.google.com with SMTP id y8-v6so6186057pll.13 for ; Fri, 02 Mar 2018 10:56:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dDDlrROqkaZQZi5Yc/LAlOF0DHxsXVz9otaL0UYlmQE=; b=N1NmFM7j+LQsJTeyZf770wwz5VSUhCXszYzhy+iOz+NxCn8iVSGp8aySBuxyULSgLn dUiRLyoGorjciMzxWeTGuBD+2qNbifXk4zqE/d5tU75Wu1CmU+PhVbUuoYTvbr9RroYn iT/Reqbh4EgbLp52bpnvsASy7te0kFF6wJkCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dDDlrROqkaZQZi5Yc/LAlOF0DHxsXVz9otaL0UYlmQE=; b=DP6M4UH+EF5UvWkw+NRFL516b3CO0q7fTVLdfvoY9N3aICthpva77ROPA9+JAQ9adP I51DdfS7cNS5LIKlgEWwV8no73Qz89FxPTjPLv0iEiY2xcaM6ZxZN/7CW6lPyqw4JTWD rB5G7vnSh2xyukkWuy5j3pdXu/M5tV2VTvrguSDMkUyJz3+CNpbPCrRu56VMu4TDn/GR 1QVQ6ee9y7i+14mA7NApg+0QKhVrH7eCKzSGleYPWEzgaNrc1onFlEJfPKsAzXtYr7ur 6JjQg9BbaB6QqAm1M7Y9ZOdX34kFRGmDcQauFXa/K2VoUVDQLTVMqc9/B7mxDr8UAwkK wx0g== X-Gm-Message-State: APf1xPC/U1nhuwIWIeQZRCJN4hZbe6mWjS2yOokZTZHNwN0WK7k5gWYm Igo8AWVLXZ3g3WvfSjFD764hvKDjpdw= X-Received: by 2002:a17:902:149:: with SMTP id 67-v6mr6023307plb.73.1520016989207; Fri, 02 Mar 2018 10:56:29 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-169-147.tukw.qwest.net. [97.113.169.147]) by smtp.gmail.com with ESMTPSA id o2sm10070338pgq.54.2018.03.02.10.56.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Mar 2018 10:56:28 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 2 Mar 2018 10:56:21 -0800 Message-Id: <20180302185622.27780-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180302185622.27780-1-richard.henderson@linaro.org> References: <20180302185622.27780-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::241 Subject: [Qemu-devel] [PULL 2/3] tcg/i386: Support INDEX_op_dup2_vec for -m32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Unknown why -m32 was passing with gcc but not clang; it should have failed for both. This would be used for tcg_gen_dup_i64_vec, and visible with the right TB and an aarch64 guest. Reported-by: Max Reitz Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.14.3 diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index fc05909d1d..d7e59e79c5 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -2696,6 +2696,12 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, case INDEX_op_x86_packus_vec: insn = packus_insn[vece]; goto gen_simd; +#if TCG_TARGET_REG_BITS == 32 + case INDEX_op_dup2_vec: + /* Constraints have already placed both 32-bit inputs in xmm regs. */ + insn = OPC_PUNPCKLDQ; + goto gen_simd; +#endif gen_simd: tcg_debug_assert(insn != OPC_UD2); if (type == TCG_TYPE_V256) { @@ -3045,6 +3051,9 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpcode op) case INDEX_op_x86_vperm2i128_vec: case INDEX_op_x86_punpckl_vec: case INDEX_op_x86_punpckh_vec: +#if TCG_TARGET_REG_BITS == 32 + case INDEX_op_dup2_vec: +#endif return &x_x_x; case INDEX_op_dup_vec: case INDEX_op_shli_vec: