From patchwork Fri Feb 23 15:36:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 129418 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp760340lja; Fri, 23 Feb 2018 07:57:58 -0800 (PST) X-Google-Smtp-Source: AG47ELsgV4+0jbFUXK8jnH0m4r1XkyU6t1RAziI7lHK0+az2pe6wuudMJZJJNeI/yQ1OejJmEd+d X-Received: by 2002:a25:688:: with SMTP id 130-v6mr1362810ybg.387.1519401478080; Fri, 23 Feb 2018 07:57:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519401478; cv=none; d=google.com; s=arc-20160816; b=aGDi+y4cY4PNbBFJvo/lnN+EfNxIg8WSlN7q+2nWs9wGSJ4pywVdCQmjzLPMt17v8Q FvCu2StD1zSXsSwPXJicWxqu9D+VDKyX+YeWZjGsM8m2tiaVc9/1StGhu/HJ/v951d7t Ch4EpPoGbwnknBk3yOGuZsQB/ePodkXPfaHqGHA2KMvPv724D2Nj3QduZZpREIknSvZH dLoLZifHDBfATDyaT4PzkAcE8DgpAHeJoRu+bw1zk0g4XOGx8nTtFhqb/htQ1uInJUFf ZH3b3sPHtxU+Nub6Ra0qCxVfvjwzYAkFNHVrUj80Lqu162f1zFHfAkhYkVYD/IPuoVFv SQhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=Y+SevaV0I8K52At9O9YUAdbtnZ7m/wazFGCi+POXB38=; b=fZFIRRp7ZnsfNUNCc0jSyo4uoqPwGpcx5YUX0QlrGYjyvSNJCKq7FoLHRge190+qYO 9mcEnjWxO9cds36YR2QVSJWllLCc1j7AHDEppt8hB9+OEZLHts2jYgmp1VJibdR/Tsy5 VYLstC5BjJxKCxd0o790/jOAVzeRD0FXFLxwRlVsJXZPp+/K7lV5vXRGIZRMEty3E3VX M+tOtDKUsfuBYBeE2BD+toYrL0URTlu6pCgxH/2Z0KtrJn/+EVoGEFoIhEdIQ3aNGje8 Ma/PrYCYCiKmYxOb3stTa9du0nGZHqX6SRY5td7sKwlGQS/CTcw8kvgRYPezcXWEyXwR MUfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YP86D0or; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id q16-v6si451501ybd.610.2018.02.23.07.57.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Feb 2018 07:57:58 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YP86D0or; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45382 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFjR-0005aN-CO for patch@linaro.org; Fri, 23 Feb 2018 10:57:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFUc-0008L7-4T for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epFUb-0005X1-7v for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:38 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:45954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epFUa-0005VI-V9 for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:37 -0500 Received: by mail-wr0-x242.google.com with SMTP id p104so14512483wrc.12 for ; Fri, 23 Feb 2018 07:42:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y+SevaV0I8K52At9O9YUAdbtnZ7m/wazFGCi+POXB38=; b=YP86D0or7Ss+Ir6eBZhtJZImjnlPEvXdPpmvutDWSArzoRFQMPqYzmA9kKGEGJ4pqB +TDvn7V5BqH7jxnbUhyy2v/d/E+VBEE/J3mBPGs+JnpEqsehf+b+MNwO1pThUHn39YjU Ns0WPYPMYbJGI6fxhjT+0TIGI8FS2Z4jxCLuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y+SevaV0I8K52At9O9YUAdbtnZ7m/wazFGCi+POXB38=; b=bYt9GiETH2aW1jxeDx/Fmne/evtDUP7LTh1KcP9yj+tkBY1L/GkVvjgPkQejb7xl8B OSYoWyAxRFEBuQy2Qh0bKPlY6CBpNwU09tXl214eV2nVILnuQGUlDAsSlH58W2Wc/hS2 1Ect8LWQYRIT7QfGU15rtqMIclEukqsmvqR7s31YmY4XoONoKfBU0OijKPX/A26RwnE/ A1qy34ZoL8HqMEWqRjkyUgOaVCB630r0IxklknRNgBLj6Yu6IBPINbqB0BomkQybYy9/ vKXfhJ/RHGXf6LNA3BJONIjuEQzeUW4DUM796z5OrXFDJEZA3QEUGpZYsoOLOTwwNgaa mP3w== X-Gm-Message-State: APf1xPCvMfT31sIO1QzwlFJHPtWNWR4mOEgALWbCQe5OjZm6rlGggUyL D82N1whRH3DuECV9YRpEyToq5w== X-Received: by 10.223.138.251 with SMTP id z56mr2041100wrz.196.1519400555788; Fri, 23 Feb 2018 07:42:35 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id u136sm2064838wmf.5.2018.02.23.07.42.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 07:42:32 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A30D23E0368; Fri, 23 Feb 2018 15:36:38 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-arm@nongnu.org Date: Fri, 23 Feb 2018 15:36:33 +0000 Message-Id: <20180223153636.29809-29-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180223153636.29809-1-alex.bennee@linaro.org> References: <20180223153636.29809-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PATCH v3 28/31] arm/translate-a64: add FP16 FMOV to simd_mod_imm X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, qemu-devel@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Only one half-precision instruction has been added to this group. Signed-off-by: Alex Bennée --- v2 - checkpatch fixes v3 - use vfp_expand_imm --- target/arm/translate-a64.c | 35 +++++++++++++++++++++++++---------- 1 file changed, 25 insertions(+), 10 deletions(-) -- 2.15.1 Reviewed-by: Richard Henderson diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index faec8084fa..806f2eb34a 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -6234,6 +6234,8 @@ static void disas_simd_copy(DisasContext *s, uint32_t insn) * MVNI - move inverted (shifted) imm into register * ORR - bitwise OR of (shifted) imm with register * BIC - bitwise clear of (shifted) imm with register + * With ARMv8.2 we also have: + * FMOV half-precision */ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) { @@ -6248,8 +6250,11 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) uint64_t imm = 0; if (o2 != 0 || ((cmode == 0xf) && is_neg && !is_q)) { - unallocated_encoding(s); - return; + /* Check for FMOV (vector, immediate) - half-precision */ + if (!(arm_dc_feature(s, ARM_FEATURE_V8_FP16) && o2 && cmode == 0xf)) { + unallocated_encoding(s); + return; + } } if (!fp_access_check(s)) { @@ -6307,19 +6312,29 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) imm |= 0x4000000000000000ULL; } } else { - imm = (abcdefgh & 0x3f) << 19; - if (abcdefgh & 0x80) { - imm |= 0x80000000; - } - if (abcdefgh & 0x40) { - imm |= 0x3e000000; + if (o2) { + /* FMOV (vector, immediate) - half-precision */ + imm = vfp_expand_imm(MO_16, abcdefgh); + /* now duplicate across the lanes */ + imm = bitfield_replicate(imm, 16); } else { - imm |= 0x40000000; + imm = (abcdefgh & 0x3f) << 19; + if (abcdefgh & 0x80) { + imm |= 0x80000000; + } + if (abcdefgh & 0x40) { + imm |= 0x3e000000; + } else { + imm |= 0x40000000; + } + imm |= (imm << 32); } - imm |= (imm << 32); } } break; + default: + fprintf(stderr, "%s: cmode_3_1: %x\n", __func__, cmode_3_1); + g_assert_not_reached(); } if (cmode_3_1 != 7 && is_neg) {