From patchwork Fri Feb 23 15:36:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 129403 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp749314lja; Fri, 23 Feb 2018 07:45:46 -0800 (PST) X-Google-Smtp-Source: AG47ELvS+lcuO/5KldXXZHLgzq46+kZt1UrvUd2y+Llu9U9a0UE0o5goQNsPWVFJrpWf3+R6NQDj X-Received: by 2002:a25:e808:: with SMTP id k8-v6mr1348614ybd.49.1519400746634; Fri, 23 Feb 2018 07:45:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519400746; cv=none; d=google.com; s=arc-20160816; b=W0btOdvN/i5Vl+ayCTX/0YXr4EhVCIgENlZgWn0IXm33bdbM1ZYg6kePeSVFoy9SjI ZcWMIneYnCe2vQVwiypMHd4qsHpuxcTP5fchlgDi7oWlA4+s4/kqO2vJS57oNJnsHUHx Q69p2x7W/pPB4x23Y3ylxGlixBFbjlMH44rgjO9/1u9iGcX9e9brTacOVPIYl2CNJkkj U3byiwcnwRjBfqXbme4ShMPBzmFUrrihh2P0hJI4Ha20YpeOR7ppSDo8jXyTL5oPw3qc ds78MTLjfO4ltMiOkghRjdg2m1kadz+uWdCTRkOGl/sazbY9yWGTtMxQ3NxZ7lRwgkJV s3wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=liruGczDscf+xwX8NQVPCNn322BdQEfwljw776ud/Y4=; b=mNiRre8J8DJcd9f0kwc/ZNr4xbrdhbi8xgG/kPPsH54EcQb08kP+0yhwGzsZiNJN0I ui8zg2TBRy2Ga0H1MVJMIFWYb4A/oXSUtkxCZZjANxi0aZhPHzIjc1zDYGfbxLcze4z+ 4errmbZMRX1WlrSaHi5t3VU+GxixCIVvKFv1yVcU07lvXCpagaCg/wxf+6I/0Uq2pKKf aajCMWmmoicdXJt7ch7LtxmRPHhKB0UMpm6GFwKhoOxBFH/FqEqSqlZpUWV8W9uR9xUk ddwG7tgewCvqtOBxbiv7EQ5K6rQyZ1cFHRr+nSu0nJ6ccaSC8sxp6Tcqj/U8uVIaZTHz uxtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Rc9FENPy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x11-v6si192364ybx.804.2018.02.23.07.45.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Feb 2018 07:45:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Rc9FENPy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFXd-0002gl-Sn for patch@linaro.org; Fri, 23 Feb 2018 10:45:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFP5-0002vs-3Y for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:36:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epFP3-0007QM-Kv for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:36:55 -0500 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:39676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epFP3-0007Ni-Bc for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:36:53 -0500 Received: by mail-wr0-x244.google.com with SMTP id w77so14496522wrc.6 for ; Fri, 23 Feb 2018 07:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=liruGczDscf+xwX8NQVPCNn322BdQEfwljw776ud/Y4=; b=Rc9FENPy39HkBHlzufqDO71iH1ytD9PV4bKa5jUmhzAWgIVYpJ8we4TJKeZaYedAJD +U37iNAqPNsvxZzURaKZr6l8eqODSkNN+3YQKMm9978q1wBMpZkbjAoGo26G0jhjcrf5 6asgfmmbGbwMPDWST7aCkW+HpCiMtqUdsy/vY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=liruGczDscf+xwX8NQVPCNn322BdQEfwljw776ud/Y4=; b=KChlyzKSqvm4aCxQHKnCk2r6cg5zJmIZpLxUIrihwxYcXCdWqmoSDv1BUrmklDZ+u9 8bwEtvozq+ptRC4K7kzk5hF3DyKt/AehNxypoE2/hQKWjh2Jh17zVKrI0B71XmZW2dX1 ITfwkBde/ARQzPN1oPkexlaYSlgZASeztrwTAvuKGuXv3k/tBxw47riiRBkeD79dEPf+ wVTqsCijjbmyFCuWcwNHchfmI7mOzvRgGCY9RreOp7pIR1q2VTWkyR/ABPLa1ZojAm+k dL4Sk9HTWKVITs6OE6ILwW8OmDFcfP8Z7xJsBnq2X2aDLUOu7Ns63WVO3ZaNyk+W20CZ XFMg== X-Gm-Message-State: APf1xPCj9UjmPcqi9DlSqf4G3X9HA1J68bk/qCoKhp8uXtoa1kDqOsjP KXXpCWzXIpMrKIb2fNXvDkOdfA== X-Received: by 10.223.169.161 with SMTP id b30mr2241912wrd.232.1519400212191; Fri, 23 Feb 2018 07:36:52 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id k2sm4986134wrc.30.2018.02.23.07.36.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 07:36:46 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id DE27F3E0C29; Fri, 23 Feb 2018 15:36:37 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-arm@nongnu.org Date: Fri, 23 Feb 2018 15:36:23 +0000 Message-Id: <20180223153636.29809-19-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180223153636.29809-1-alex.bennee@linaro.org> References: <20180223153636.29809-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PATCH v3 18/31] arm/translate-a64: add FCVTxx to simd_two_reg_misc_fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, qemu-devel@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This covers all the floating point convert operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/helper-a64.c | 32 +++++++++++++++++ target/arm/helper-a64.h | 2 ++ target/arm/translate-a64.c | 85 +++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 118 insertions(+), 1 deletion(-) -- 2.15.1 diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c index 4fd28fdf48..722fff2349 100644 --- a/target/arm/helper-a64.c +++ b/target/arm/helper-a64.c @@ -767,3 +767,35 @@ float16 HELPER(advsimd_rinth)(float16 x, void *fp_status) return ret; } + +/* + * Half-precision floating point conversion functions + * + * There are a multitude of conversion functions with various + * different rounding modes. This is dealt with by the calling code + * setting the mode appropriately before calling the helper. + */ + +uint32_t HELPER(advsimd_f16tosinth)(float16 a, void *fpstp) +{ + float_status *fpst = fpstp; + + /* Invalid if we are passed a NaN */ + if (float16_is_any_nan(a)) { + float_raise(float_flag_invalid, fpst); + return 0; + } + return float16_to_int16(a, fpst); +} + +uint32_t HELPER(advsimd_f16touinth)(float16 a, void *fpstp) +{ + float_status *fpst = fpstp; + + /* Invalid if we are passed a NaN */ + if (float16_is_any_nan(a)) { + float_raise(float_flag_invalid, fpst); + return 0; + } + return float16_to_uint16(a, fpst); +} diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index bc8d5b105b..32931b17c6 100644 --- a/target/arm/helper-a64.h +++ b/target/arm/helper-a64.h @@ -77,3 +77,5 @@ DEF_HELPER_3(advsimd_mulx2h, i32, i32, i32, ptr) DEF_HELPER_4(advsimd_muladd2h, i32, i32, i32, i32, ptr) DEF_HELPER_2(advsimd_rinth_exact, f16, f16, ptr) DEF_HELPER_2(advsimd_rinth, f16, f16, ptr) +DEF_HELPER_2(advsimd_f16tosinth, i32, f16, ptr) +DEF_HELPER_2(advsimd_f16touinth, i32, f16, ptr) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 6f33663c7b..e3318837c9 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11240,6 +11240,46 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) only_in_vector = true; /* current rounding mode */ break; + case 0x1a: /* FCVTNS */ + need_rmode = true; + rmode = FPROUNDING_TIEEVEN; + break; + case 0x1b: /* FCVTMS */ + need_rmode = true; + rmode = FPROUNDING_NEGINF; + break; + case 0x1c: /* FCVTAS */ + need_rmode = true; + rmode = FPROUNDING_TIEAWAY; + break; + case 0x3a: /* FCVTPS */ + need_rmode = true; + rmode = FPROUNDING_POSINF; + break; + case 0x3b: /* FCVTZS */ + need_rmode = true; + rmode = FPROUNDING_ZERO; + break; + case 0x5a: /* FCVTNU */ + need_rmode = true; + rmode = FPROUNDING_TIEEVEN; + break; + case 0x5b: /* FCVTMU */ + need_rmode = true; + rmode = FPROUNDING_NEGINF; + break; + case 0x5c: /* FCVTAU */ + need_rmode = true; + rmode = FPROUNDING_TIEAWAY; + break; + case 0x7a: /* FCVTPU */ + need_rmode = true; + rmode = FPROUNDING_POSINF; + break; + case 0x7b: /* FCVTZU */ + need_rmode = true; + rmode = FPROUNDING_ZERO; + break; default: fprintf(stderr, "%s: insn %#04x fpop %#2x\n", __func__, insn, fpop); g_assert_not_reached(); @@ -11273,7 +11313,36 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) } if (is_scalar) { - /* no operations yet */ + TCGv_i32 tcg_op = tcg_temp_new_i32(); + TCGv_i32 tcg_res = tcg_temp_new_i32(); + + read_vec_element_i32(s, tcg_op, rn, 0, MO_16); + + switch (fpop) { + case 0x1a: /* FCVTNS */ + case 0x1b: /* FCVTMS */ + case 0x1c: /* FCVTAS */ + case 0x3a: /* FCVTPS */ + case 0x3b: /* FCVTZS */ + gen_helper_advsimd_f16tosinth(tcg_res, tcg_op, tcg_fpstatus); + break; + case 0x5a: /* FCVTNU */ + case 0x5b: /* FCVTMU */ + case 0x5c: /* FCVTAU */ + case 0x7a: /* FCVTPU */ + case 0x7b: /* FCVTZU */ + gen_helper_advsimd_f16touinth(tcg_res, tcg_op, tcg_fpstatus); + break; + default: + g_assert_not_reached(); + } + + /* limit any sign extension going on */ + tcg_gen_andi_i32(tcg_res, tcg_res, 0xffff); + write_fp_sreg(s, rd, tcg_res); + + tcg_temp_free_i32(tcg_res); + tcg_temp_free_i32(tcg_op); } else { for (pass = 0; pass < (is_q ? 8 : 4); pass++) { TCGv_i32 tcg_op = tcg_temp_new_i32(); @@ -11282,6 +11351,20 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) read_vec_element_i32(s, tcg_op, rn, pass, MO_16); switch (fpop) { + case 0x1a: /* FCVTNS */ + case 0x1b: /* FCVTMS */ + case 0x1c: /* FCVTAS */ + case 0x3a: /* FCVTPS */ + case 0x3b: /* FCVTZS */ + gen_helper_advsimd_f16tosinth(tcg_res, tcg_op, tcg_fpstatus); + break; + case 0x5a: /* FCVTNU */ + case 0x5b: /* FCVTMU */ + case 0x5c: /* FCVTAU */ + case 0x7a: /* FCVTPU */ + case 0x7b: /* FCVTZU */ + gen_helper_advsimd_f16touinth(tcg_res, tcg_op, tcg_fpstatus); + break; case 0x18: /* FRINTN */ case 0x19: /* FRINTM */ case 0x38: /* FRINTP */