From patchwork Fri Feb 23 15:36:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 129408 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp753119lja; Fri, 23 Feb 2018 07:49:49 -0800 (PST) X-Google-Smtp-Source: AH8x225Dwej3UTsPaQkCSK/cp1jo7EpTEKGDMP+4Wwr3ebKSZW5+SYYfAnZzHx50/FSVWAIUDhc8 X-Received: by 10.129.175.73 with SMTP id x9mr1337759ywj.35.1519400989309; Fri, 23 Feb 2018 07:49:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519400989; cv=none; d=google.com; s=arc-20160816; b=jOv2HYYgJXWp27FmPeTXcjrjO82EYjTMni3sYcgj80csREWjv5l3sYOn40iMxYRhGk AksgEDBk7gl2E1RAqoYoevI9Fv+9Lejqd0byhyt48wnDSC58Ixsrb6mCXkF4udQcpq1T MXwTAeJ74i8kurSXaQwWLYwdXd7BXE9j7EV3BZyZ+ukeWX+RKglXUy5B3WkeZWBhJEks pzGan0u+QKKv1eGekngc7mi58FpsyVfgUqCWviXOD4xgl7aw+2O4lIMUcNuI7ZSeeXDL P7erOXKzmJI0IspTRNOiIGRsZAr7Zvh1hNYn3AjJO5SumVMPZh7iROvEwmoJdu50K208 VFhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=WJduKqLIuBTHq6WFzmTmo4jkE6BcZz/VbT4+ImZgbsk=; b=V3d7zSrNu1BkTQnD7+4JDCQO1849gc18YHY4AXVg3zTnpMjrhViWtXXgYbKd7aOGU3 lXHCC6YMa1z/swIJ9pYXEv/CLcSbVl3uys28Aptm6e07tTQ6N0Bm2LUH+okElzpZEXj8 eYLnWzqgPNodRjTIVsMtftBWBVNHrttjAJwsu1A1tEBFk1WITD3vr/j5ui3umcJEaOB2 BxFWKQzgdTSSwDSFGa9XhAt9uDAnoG7lOCOg0dAGPVXys+hOFMmJwEOMbemxVSiii8iI twCTE1WF2enwDT4J7DNAYgfWJGnFuSSXQfeO8+BjfkQ3Ec5TiqsdRTgMYgi6fnaziOIZ 2eRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=EOqOaFUR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id f188si446311ywc.215.2018.02.23.07.49.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Feb 2018 07:49:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=EOqOaFUR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFbY-0006S6-Ih for patch@linaro.org; Fri, 23 Feb 2018 10:49:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epFUh-0008Qt-3U for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epFUd-0005by-JQ for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:43 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:53242) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epFUd-0005Zu-8k for qemu-devel@nongnu.org; Fri, 23 Feb 2018 10:42:39 -0500 Received: by mail-wm0-x242.google.com with SMTP id t3so5438512wmc.2 for ; Fri, 23 Feb 2018 07:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WJduKqLIuBTHq6WFzmTmo4jkE6BcZz/VbT4+ImZgbsk=; b=EOqOaFURzsHG/KQw7Wyipgp82mnEW8qT627SEIvL1x1sPeHw06ytJ+IGZItx0MZerK +KdaRDbLQYwGR0Pcd4IE3nNSXx+xQkYt9jyKk+2f62YRrg37NsD87RCieY5+zM0CjyU3 wS8VXvAcEla2j1iFSI6TH8nU8LlhcwryfXdws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WJduKqLIuBTHq6WFzmTmo4jkE6BcZz/VbT4+ImZgbsk=; b=cDZN7eXbuZfp0veGRRTz1i/xLHRYI8raixb98VAH4ATJQf6ILUCcdQtbukyumgnwfE +y8glJsuimqrE+KytzLb62L0ZpT6PFdmsjhET1TsALAYqpHdqInum1OmesQdCkooeK2y jCLDk2xji3y7q/CdvtGRMaP/Y9EEPl/vaBSQw6izNCkeC7Y7BlUUnydEQc1M8Bv77/os 1mdO3hHh//8AdfoRU8F4g4XJLZ4gPUM+nclcDC6Rk4Op1EVwvZMVe9eoS4cCA3E2BGl8 FmlrVyDxg4a3jv+aTjtFpoQtKIyu+XPzmkynE0iVgz1j63xxz4P3N09096+gu359jn+q bowQ== X-Gm-Message-State: APf1xPDpn0hG1fhxOZXBoMJLafgS9E8+869UFBiIaN3sJgPGmhLMAwYr V9aSaXqW+fJ7QFJ7oIXGEH0cpNlXJxg= X-Received: by 10.28.237.19 with SMTP id l19mr1965325wmh.157.1519400558133; Fri, 23 Feb 2018 07:42:38 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id i33sm2673188wri.70.2018.02.23.07.42.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 07:42:32 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A44553E0BDF; Fri, 23 Feb 2018 15:36:37 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-arm@nongnu.org Date: Fri, 23 Feb 2018 15:36:20 +0000 Message-Id: <20180223153636.29809-16-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180223153636.29809-1-alex.bennee@linaro.org> References: <20180223153636.29809-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PATCH v3 15/31] arm/translate-a64: add FP16 x2 ops for simd_indexed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, qemu-devel@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" A bunch of the vectorised bitwise operations just operate on larger chunks at a time. We can do the same for the new half-precision operations by introducing some TWOHALFOP helpers which work on each half of a pair of half-precision operations at once. Hopefully all this hoop jumping will get simpler once we have generically vectorised helpers here. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - checkpatch fixes --- target/arm/helper-a64.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- target/arm/helper-a64.h | 10 ++++++++++ target/arm/translate-a64.c | 26 +++++++++++++++++++++----- 3 files changed, 76 insertions(+), 6 deletions(-) -- 2.15.1 diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c index 8fdbe034f3..4d5ae96d8f 100644 --- a/target/arm/helper-a64.c +++ b/target/arm/helper-a64.c @@ -629,8 +629,32 @@ ADVSIMD_HALFOP(max) ADVSIMD_HALFOP(minnum) ADVSIMD_HALFOP(maxnum) +#define ADVSIMD_TWOHALFOP(name) \ +uint32_t ADVSIMD_HELPER(name, 2h)(uint32_t two_a, uint32_t two_b, void *fpstp) \ +{ \ + float16 a1, a2, b1, b2; \ + uint32_t r1, r2; \ + float_status *fpst = fpstp; \ + a1 = extract32(two_a, 0, 16); \ + a2 = extract32(two_a, 16, 16); \ + b1 = extract32(two_b, 0, 16); \ + b2 = extract32(two_b, 16, 16); \ + r1 = float16_ ## name(a1, b1, fpst); \ + r2 = float16_ ## name(a2, b2, fpst); \ + return deposit32(r1, 16, 16, r2); \ +} + +ADVSIMD_TWOHALFOP(add) +ADVSIMD_TWOHALFOP(sub) +ADVSIMD_TWOHALFOP(mul) +ADVSIMD_TWOHALFOP(div) +ADVSIMD_TWOHALFOP(min) +ADVSIMD_TWOHALFOP(max) +ADVSIMD_TWOHALFOP(minnum) +ADVSIMD_TWOHALFOP(maxnum) + /* Data processing - scalar floating-point and advanced SIMD */ -float16 HELPER(advsimd_mulxh)(float16 a, float16 b, void *fpstp) +static float16 float16_mulx(float16 a, float16 b, void *fpstp) { float_status *fpst = fpstp; @@ -646,6 +670,9 @@ float16 HELPER(advsimd_mulxh)(float16 a, float16 b, void *fpstp) return float16_mul(a, b, fpst); } +ADVSIMD_HALFOP(mulx) +ADVSIMD_TWOHALFOP(mulx) + /* fused multiply-accumulate */ float16 HELPER(advsimd_muladdh)(float16 a, float16 b, float16 c, void *fpstp) { @@ -653,6 +680,23 @@ float16 HELPER(advsimd_muladdh)(float16 a, float16 b, float16 c, void *fpstp) return float16_muladd(a, b, c, 0, fpst); } +uint32_t HELPER(advsimd_muladd2h)(uint32_t two_a, uint32_t two_b, + uint32_t two_c, void *fpstp) +{ + float_status *fpst = fpstp; + float16 a1, a2, b1, b2, c1, c2; + uint32_t r1, r2; + a1 = extract32(two_a, 0, 16); + a2 = extract32(two_a, 16, 16); + b1 = extract32(two_b, 0, 16); + b2 = extract32(two_b, 16, 16); + c1 = extract32(two_c, 0, 16); + c2 = extract32(two_c, 16, 16); + r1 = float16_muladd(a1, b1, c1, 0, fpst); + r2 = float16_muladd(a2, b2, c2, 0, fpst); + return deposit32(r1, 16, 16, r2); +} + /* * Floating point comparisons produce an integer result. Softfloat * routines return float_relation types which we convert to the 0/-1 diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index 79012eee9d..003ffa582f 100644 --- a/target/arm/helper-a64.h +++ b/target/arm/helper-a64.h @@ -65,3 +65,13 @@ DEF_HELPER_3(advsimd_acge_f16, i32, f16, f16, ptr) DEF_HELPER_3(advsimd_acgt_f16, i32, f16, f16, ptr) DEF_HELPER_3(advsimd_mulxh, f16, f16, f16, ptr) DEF_HELPER_4(advsimd_muladdh, f16, f16, f16, f16, ptr) +DEF_HELPER_3(advsimd_add2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_sub2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_mul2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_div2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_max2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_min2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_maxnum2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_minnum2h, i32, i32, i32, ptr) +DEF_HELPER_3(advsimd_mulx2h, i32, i32, i32, ptr) +DEF_HELPER_4(advsimd_muladd2h, i32, i32, i32, i32, ptr) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 43bff5cd09..081619a389 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11418,8 +11418,13 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) * multiply-add */ tcg_gen_xori_i32(tcg_op, tcg_op, 0x80008000); } - gen_helper_advsimd_muladdh(tcg_res, tcg_op, tcg_idx, - tcg_res, fpst); + if (is_scalar) { + gen_helper_advsimd_muladdh(tcg_res, tcg_op, tcg_idx, + tcg_res, fpst); + } else { + gen_helper_advsimd_muladd2h(tcg_res, tcg_op, tcg_idx, + tcg_res, fpst); + } break; case 2: if (opcode == 0x5) { @@ -11438,10 +11443,21 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) switch (size) { case 1: if (u) { - gen_helper_advsimd_mulxh(tcg_res, tcg_op, tcg_idx, - fpst); + if (is_scalar) { + gen_helper_advsimd_mulxh(tcg_res, tcg_op, + tcg_idx, fpst); + } else { + gen_helper_advsimd_mulx2h(tcg_res, tcg_op, + tcg_idx, fpst); + } } else { - g_assert_not_reached(); + if (is_scalar) { + gen_helper_advsimd_mulh(tcg_res, tcg_op, + tcg_idx, fpst); + } else { + gen_helper_advsimd_mul2h(tcg_res, tcg_op, + tcg_idx, fpst); + } } break; case 2: