From patchwork Wed Feb 7 22:55:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 127229 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp937533ljc; Wed, 7 Feb 2018 15:12:36 -0800 (PST) X-Google-Smtp-Source: AH8x225PciB+kObyOtbMcho0POB94UGSdXWaceoP3s4b8i4cgAVP3YyluyAkDJMoSXd4HOC8sHw+ X-Received: by 10.37.37.87 with SMTP id l84mr5255098ybl.386.1518045156109; Wed, 07 Feb 2018 15:12:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518045156; cv=none; d=google.com; s=arc-20160816; b=QC1y9QoE9ny7pXZerLcGWdjrl3okwhZzc85bjB9uBwZB8a9+YYZkoFPT742L5acFbB tdQirUeY6SxR8TtidAApolwt20r32fTIiOWdSf/jwrS3LA0GqE3emDuMzJ7c8Ef6v99h kBBNy+oKLSKXxQDpbJ5chlMrPAx09fF1Fs+DeKlB2pRpf4krTd8Xswwzpvsj79lI6hCh YzEWjGM3rvpzO9MYRBoS20b2+KwTRnmi3B3dn0+vk317QMfvmOGKm/3l29x3FEfYP50y yu+VbwMfQa2ysAuDmsb/5ts09PpL7eb6wPQUIO7CZF0Jy3/KUpuDI+jkUf/nscMCNpWF ym8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=HJK64mNgLzlSYnVOgQ2RzJey8lyHI/76Z/azOJqzIcg=; b=kTU6iKfD2Bh4PNmmQmX860sEvmx9HI4k9HtG+HlFZzUQbTe1D0TuoIRLw0rrAFYK6x bx5iecJgTrAvz2ReztUwRFfqnn14LMvfIJYWBSNNGdLZVfP9gwx7hou3jLP1TXssjoxw CEUDXSGIK5SYw4gPVQveaGnAW9WOl+Q/CNgL/+rTSl9onH3svwuw7O3OJfHEK/W/bA+i v7mIXsXwEo4REUq8cPBQ2KFFnX1zpb44LkCgG+7xP9zF5WJ4l/c8yVgnE4QYKboKhU9m 98uRUZmvJQAZtvirNAPCwhUKiB6mn7aYIUQEw8ohmi+427YLIILQxapOb+O+F7M7lX+j 5FAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TsShWTk+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id p132si421328ywb.45.2018.02.07.15.12.35 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 07 Feb 2018 15:12:36 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TsShWTk+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejYtH-0004Jw-E3 for patch@linaro.org; Wed, 07 Feb 2018 18:12:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejYdK-0007PF-AH for qemu-devel@nongnu.org; Wed, 07 Feb 2018 17:56:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejYdJ-00053w-9D for qemu-devel@nongnu.org; Wed, 07 Feb 2018 17:56:06 -0500 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:35100) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejYdI-000534-W1 for qemu-devel@nongnu.org; Wed, 07 Feb 2018 17:56:05 -0500 Received: by mail-pf0-x241.google.com with SMTP id y9so982885pfl.2 for ; Wed, 07 Feb 2018 14:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HJK64mNgLzlSYnVOgQ2RzJey8lyHI/76Z/azOJqzIcg=; b=TsShWTk+W60ym+VN4RYZuzfLS91IyV6GE/sDCVChsRwISZLE3p4oeM6r3IMnUC/0D3 Pv7Z7qx43cKEmAIF1nhMnhEcx5w1o3m6YyXgJKGkPV5jVsTfWlpX1e64QPDCl8WHU8AK KzMQSbgglBIJauBPp0d7gEn7vVZM/hbfYFrYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HJK64mNgLzlSYnVOgQ2RzJey8lyHI/76Z/azOJqzIcg=; b=JfZ7CqOyz8ZLg5h3jYWxw4QD7XmfJRCpn16fONkfLYnn3m774JdvelYK3OkyPXZhR5 dLm+WxO94fZSLPSAzLPBhQHuoCQrf1sFIvxEJbllOiEG/IWyh/fjoMOir5bq4YQB/DJK hlV4LW2YezfCNEBQ1LH0F/sBpNhK+ejK74uNnjj828s/DaAa9PYhaA55XNq/lU9AWADD 9pPlOPP1Go2J1hOwqOHoDH2ftYMZ2Z7NNNnBk2/Qkc6T65Fc+hJrsVGcjF4AorAD/kBQ DTzVJ5RJoqn3GmySLw2A3PyjNjjF6K6yqYg34/M/nhGoFVhUkz6kH1UqeJFCCw1pQ6ar Pacg== X-Gm-Message-State: APf1xPD6glmIDcnq+9cDPgRYOXzJaHSu+a96dZb6Lvthmz/V8lzLg7ok byUZXxLnDeVjTIJQ9wSi4jxSWTLjyYg= X-Received: by 10.98.89.28 with SMTP id n28mr6272474pfb.164.1518044163584; Wed, 07 Feb 2018 14:56:03 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id v73sm5874836pfk.84.2018.02.07.14.56.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 14:56:02 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 7 Feb 2018 14:55:34 -0800 Message-Id: <20180207225540.31698-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180207225540.31698-1-richard.henderson@linaro.org> References: <20180207225540.31698-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PULL 14/20] target/arm: Use vector infrastructure for aa64 dup/movi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 81 +++++++++++++++++++--------------------------- 1 file changed, 33 insertions(+), 48 deletions(-) -- 2.14.3 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 11310f1a7a..48088dbb29 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5890,10 +5890,7 @@ static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64) / esize; - int index, i; - TCGv_i64 tmp; + int index = imm5 >> (size + 1); if (size > 3 || (size == 3 && !is_q)) { unallocated_encoding(s); @@ -5904,20 +5901,9 @@ static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, return; } - index = imm5 >> (size + 1); - - tmp = tcg_temp_new_i64(); - read_vec_element(s, tmp, rn, index, size); - - for (i = 0; i < elements; i++) { - write_vec_element(s, tmp, rd, i, size); - } - - if (!is_q) { - clear_vec_high(s, rd); - } - - tcg_temp_free_i64(tmp); + tcg_gen_gvec_dup_mem(size, vec_full_reg_offset(s, rd), + vec_reg_offset(s, rn, index, size), + is_q ? 16 : 8, vec_full_reg_size(s)); } /* DUP (element, scalar) @@ -5966,9 +5952,7 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64)/esize; - int i = 0; + uint32_t dofs, oprsz, maxsz; if (size > 3 || ((size == 3) && !is_q)) { unallocated_encoding(s); @@ -5979,12 +5963,11 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, return; } - for (i = 0; i < elements; i++) { - write_vec_element(s, cpu_reg(s, rn), rd, i, size); - } - if (!is_q) { - clear_vec_high(s, rd); - } + dofs = vec_full_reg_offset(s, rd); + oprsz = is_q ? 16 : 8; + maxsz = vec_full_reg_size(s); + + tcg_gen_gvec_dup_i64(size, dofs, oprsz, maxsz, cpu_reg(s, rn)); } /* INS (Element) @@ -6175,7 +6158,6 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) bool is_neg = extract32(insn, 29, 1); bool is_q = extract32(insn, 30, 1); uint64_t imm = 0; - TCGv_i64 tcg_rd, tcg_imm; int i; if (o2 != 0 || ((cmode == 0xf) && is_neg && !is_q)) { @@ -6257,32 +6239,35 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) imm = ~imm; } - tcg_imm = tcg_const_i64(imm); - tcg_rd = new_tmp_a64(s); + if (!((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9)) { + /* MOVI or MVNI, with MVNI negation handled above. */ + tcg_gen_gvec_dup64i(vec_full_reg_offset(s, rd), is_q ? 16 : 8, + vec_full_reg_size(s), imm); + } else { + TCGv_i64 tcg_imm = tcg_const_i64(imm); + TCGv_i64 tcg_rd = new_tmp_a64(s); - for (i = 0; i < 2; i++) { - int foffs = i ? fp_reg_hi_offset(s, rd) : fp_reg_offset(s, rd, MO_64); + for (i = 0; i < 2; i++) { + int foffs = vec_reg_offset(s, rd, i, MO_64); - if (i == 1 && !is_q) { - /* non-quad ops clear high half of vector */ - tcg_gen_movi_i64(tcg_rd, 0); - } else if ((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9) { - tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); - if (is_neg) { - /* AND (BIC) */ - tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + if (i == 1 && !is_q) { + /* non-quad ops clear high half of vector */ + tcg_gen_movi_i64(tcg_rd, 0); } else { - /* ORR */ - tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); + if (is_neg) { + /* AND (BIC) */ + tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + } else { + /* ORR */ + tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + } } - } else { - /* MOVI */ - tcg_gen_mov_i64(tcg_rd, tcg_imm); + tcg_gen_st_i64(tcg_rd, cpu_env, foffs); } - tcg_gen_st_i64(tcg_rd, cpu_env, foffs); - } - tcg_temp_free_i64(tcg_imm); + tcg_temp_free_i64(tcg_imm); + } } /* AdvSIMD scalar copy