From patchwork Fri Jan 26 04:57:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 125900 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp81867ljd; Thu, 25 Jan 2018 21:21:28 -0800 (PST) X-Google-Smtp-Source: AH8x2271ALs9UcoB7BgVWm2QOqVTPcK7BbnxXmE4Lg+RJw0vQ39qg2L+7S+mx4itOHCdneP9x6Vs X-Received: by 10.13.223.13 with SMTP id i13mr10090993ywe.285.1516944088827; Thu, 25 Jan 2018 21:21:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516944088; cv=none; d=google.com; s=arc-20160816; b=fQ4WL1L84cMTXbMOEqCJ5BsBtKEDO1xtJnCf4hWDhnc+2Wid1/cUSM/+24cyPMFODz y8RbyIafI0zEd+jMuMt/R9QSBANGOreZwvxV6GnYBmRMrOHFASFAEmTA2UaTmY34eWBI 5mPLqEDcNisZlDKwr6gEtIMQNeUt/HnKQpxM7zemJ2Ht4LNSGZqVGqSlOLrhVUXiEsWQ sxn8tU1vsgPeqqkS0ieOO6nNhuDWL++hFjFo+ahCvZE2fuRW6b2yPYIovtHUWcQBOfre e7QI3F/wigPlOvGki4tj0H6bWVfrv8pAyVGDVOKlZ/qmjfdgpwD104xm9boVhwXyMKnP aPYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=6biGdgdwuSel/3sanWaEoMjM3L1JXykWfnw0KyHFJiw=; b=L/w+eDXvEIG9SccO25GMBraaG1GsYdee4KrR9su0blZREEsStO/o/7sTZ4qu3F//wJ 5+wXH9EBHzlsKn1ryrcdGwCScDypZCwrXm5qZwgKIQcdQnWOdoqdqBcdy5DtD8HgRT6B Ot5beE/tcPrVNS2pv/OwhCLyUkpQzaXNWQ3NixfbGG2m01cQ/uVE4ITAxOX73y0UKA1K Y1E0r8PMPUzzXKIeFoAhz5Wj2gBVfNNIOfnrHg4fUkC8Jzc0t70yieVqO95rt7KDdv05 tLBGe6vm01VzPbdWtZ/cUawAo2Zw+R2chbPsKsPOq0qN3KiFtZzTkigWaFXq71VU37Hs qNNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LmrZROtR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 130si1337665ybm.671.2018.01.25.21.21.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 25 Jan 2018 21:21:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LmrZROtR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59837 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eewS8-0002mu-7U for patch@linaro.org; Fri, 26 Jan 2018 00:21:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eewQY-0002Hz-U3 for qemu-devel@nongnu.org; Fri, 26 Jan 2018 00:19:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eewQV-0001lx-PQ for qemu-devel@nongnu.org; Fri, 26 Jan 2018 00:19:50 -0500 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:39359) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eewQV-0001kx-Hx for qemu-devel@nongnu.org; Fri, 26 Jan 2018 00:19:47 -0500 Received: by mail-pg0-x242.google.com with SMTP id w17so6563263pgv.6 for ; Thu, 25 Jan 2018 21:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6biGdgdwuSel/3sanWaEoMjM3L1JXykWfnw0KyHFJiw=; b=LmrZROtRABNx+eETq5wP7eF6h7kQHUWD/nHLzXD8ld4pZt4oy06WFp5Wp70I5WIfeV s1hARw+P20WmkA6qFK9m6xoNoVy3+PHkwp4VFy2MxqyQLS2fYC2Hv7aKM1W58Wy94f5+ 4TTHPqKfF0hf4bTRCXuJyyAwbTxGWAlyEwJNw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6biGdgdwuSel/3sanWaEoMjM3L1JXykWfnw0KyHFJiw=; b=C9H9H4R9XnfYur62IslWNKywhe/S6+/rLe4HLBprIWKbwBFeoiZeQjqHMltOw9y8GO dZWncYRu0yRNeIPPcQRt7k0DIs2l8qShXUuhhx5OiTk/AbaFHphu0K56MN3339Tu3agG K2CkiFRUHdNrDCiBRN/on16GicVxzyqDJvGKUSMhUoSUipfgnmyiHwjyH9M9EoQzYlGA Vu7eLZrk99UugT5CAuqUtLMaWuCQOlec7jvJfdqPVOnUC6dCxqyHPyPooccrwH/+BTKY jcJk6RiMVZbnGyWQXKSomot6UJOCCCXh2HZBFrPk3yZwWhtFEjsT2RiB3PcmYt4qkj+Z 2KBA== X-Gm-Message-State: AKwxytdk004/WSC28XwEkkL73REQH+hirND1KoghZZtmMWJh9wS/S4oo oeC0WudLaOI3I9J9oFIJyEDmUa8wJfo= X-Received: by 10.99.173.65 with SMTP id y1mr14642143pgo.160.1516942697638; Thu, 25 Jan 2018 20:58:17 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id q67sm20460313pfi.164.2018.01.25.20.58.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 20:58:16 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 25 Jan 2018 20:57:36 -0800 Message-Id: <20180126045742.5487-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180126045742.5487-1-richard.henderson@linaro.org> References: <20180126045742.5487-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH v11 14/20] target/arm: Use vector infrastructure for aa64 dup/movi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 81 +++++++++++++++++++--------------------------- 1 file changed, 33 insertions(+), 48 deletions(-) -- 2.14.3 Reviewed-by: Alex Bennée diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 11310f1a7a..48088dbb29 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5890,10 +5890,7 @@ static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64) / esize; - int index, i; - TCGv_i64 tmp; + int index = imm5 >> (size + 1); if (size > 3 || (size == 3 && !is_q)) { unallocated_encoding(s); @@ -5904,20 +5901,9 @@ static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, return; } - index = imm5 >> (size + 1); - - tmp = tcg_temp_new_i64(); - read_vec_element(s, tmp, rn, index, size); - - for (i = 0; i < elements; i++) { - write_vec_element(s, tmp, rd, i, size); - } - - if (!is_q) { - clear_vec_high(s, rd); - } - - tcg_temp_free_i64(tmp); + tcg_gen_gvec_dup_mem(size, vec_full_reg_offset(s, rd), + vec_reg_offset(s, rn, index, size), + is_q ? 16 : 8, vec_full_reg_size(s)); } /* DUP (element, scalar) @@ -5966,9 +5952,7 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64)/esize; - int i = 0; + uint32_t dofs, oprsz, maxsz; if (size > 3 || ((size == 3) && !is_q)) { unallocated_encoding(s); @@ -5979,12 +5963,11 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, return; } - for (i = 0; i < elements; i++) { - write_vec_element(s, cpu_reg(s, rn), rd, i, size); - } - if (!is_q) { - clear_vec_high(s, rd); - } + dofs = vec_full_reg_offset(s, rd); + oprsz = is_q ? 16 : 8; + maxsz = vec_full_reg_size(s); + + tcg_gen_gvec_dup_i64(size, dofs, oprsz, maxsz, cpu_reg(s, rn)); } /* INS (Element) @@ -6175,7 +6158,6 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) bool is_neg = extract32(insn, 29, 1); bool is_q = extract32(insn, 30, 1); uint64_t imm = 0; - TCGv_i64 tcg_rd, tcg_imm; int i; if (o2 != 0 || ((cmode == 0xf) && is_neg && !is_q)) { @@ -6257,32 +6239,35 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) imm = ~imm; } - tcg_imm = tcg_const_i64(imm); - tcg_rd = new_tmp_a64(s); + if (!((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9)) { + /* MOVI or MVNI, with MVNI negation handled above. */ + tcg_gen_gvec_dup64i(vec_full_reg_offset(s, rd), is_q ? 16 : 8, + vec_full_reg_size(s), imm); + } else { + TCGv_i64 tcg_imm = tcg_const_i64(imm); + TCGv_i64 tcg_rd = new_tmp_a64(s); - for (i = 0; i < 2; i++) { - int foffs = i ? fp_reg_hi_offset(s, rd) : fp_reg_offset(s, rd, MO_64); + for (i = 0; i < 2; i++) { + int foffs = vec_reg_offset(s, rd, i, MO_64); - if (i == 1 && !is_q) { - /* non-quad ops clear high half of vector */ - tcg_gen_movi_i64(tcg_rd, 0); - } else if ((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9) { - tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); - if (is_neg) { - /* AND (BIC) */ - tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + if (i == 1 && !is_q) { + /* non-quad ops clear high half of vector */ + tcg_gen_movi_i64(tcg_rd, 0); } else { - /* ORR */ - tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); + if (is_neg) { + /* AND (BIC) */ + tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + } else { + /* ORR */ + tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + } } - } else { - /* MOVI */ - tcg_gen_mov_i64(tcg_rd, tcg_imm); + tcg_gen_st_i64(tcg_rd, cpu_env, foffs); } - tcg_gen_st_i64(tcg_rd, cpu_env, foffs); - } - tcg_temp_free_i64(tcg_imm); + tcg_temp_free_i64(tcg_imm); + } } /* AdvSIMD scalar copy