From patchwork Tue Jan 23 20:35:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 125586 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp1990179ljf; Tue, 23 Jan 2018 12:35:58 -0800 (PST) X-Google-Smtp-Source: AH8x224tDTjSfVX+IkhIS0A87TFEHtWEqdHr/jSGtY7dP555rCXCDLrHZPl+NEn5GTt18A4L0DHp X-Received: by 10.129.102.70 with SMTP id a67mr3624826ywc.356.1516739758596; Tue, 23 Jan 2018 12:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516739758; cv=none; d=google.com; s=arc-20160816; b=ueuiqyefbfwZZA9bymJemGd58jRr09b+Aj8Z9PJuzKP2PRZ5rhCGBabgSJZrJ1rqSs 26A2vlV0U7d9rXFxLAF3NltyUZb8p0hj1M4FMSS1LUiwGnwbbSAsmhPJHhAtx9JMykOd JjqO9C/q7LghiRVMpGeh0cyJxrBma1Kral2fqIvia86csgfiJ8fuk+EE6RVUDNTbxH+N dWUIK5ygi7OiQyYUv4shcV21WlxLPCfXpqtDKThhcMZwNjwW2NnNUv7/ST1VEMrMdbi0 ZJOtG5c2JhkrPkS06eXCrTRRDWP3SrdMgchRcCHZwCQH99NJ9IeHDnKfz5JAcr0bH8JF /79Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=jEokhSTD0km1Ad3/quvU0Clwax8ilHswUE3LoQvIehA=; b=OdHfFGGaf7j4H76U0uscnLRJYoDf3zSuHm7Cxk9PsZmAoBty9gPz1IIQzyzwe6B3ez RIgqpaUNdzpmmG+nSQFOkevbUmf7tyNcWwZGcAfeM/DRhks6NGlupWpysx5KKyzR+0yX q8ZtLrlyomuS5b4YRzAdpalYsWOJ1xlYZq1qXZtGM+84Za/1UxdubrXyc2rDdCOF6uQw 4dr2qz/BpShxrpJHSQAioJoGdRfN3IJ4vRGut6r6DzTdrrsNbKvxQXQb/ZaFQLlGE0ID MLt90w27i7XNqJh0/+N7XSYwV9z4ONUJG5xX3mI/rCWgH6HGyLwlbqtbguEfpLY2d1F8 3/oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=D6doreEF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id w62si1843311ybb.114.2018.01.23.12.35.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 23 Jan 2018 12:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=D6doreEF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51650 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5IU-0005G1-1Z for patch@linaro.org; Tue, 23 Jan 2018 15:35:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5IF-0005Fg-FZ for qemu-devel@nongnu.org; Tue, 23 Jan 2018 15:35:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee5IA-0000H1-DV for qemu-devel@nongnu.org; Tue, 23 Jan 2018 15:35:43 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:46081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee5IA-0000GO-1Q for qemu-devel@nongnu.org; Tue, 23 Jan 2018 15:35:38 -0500 Received: by mail-wm0-x241.google.com with SMTP id 143so4296242wma.5 for ; Tue, 23 Jan 2018 12:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=jEokhSTD0km1Ad3/quvU0Clwax8ilHswUE3LoQvIehA=; b=D6doreEFnYMqd6fzrHe1I7UeIyzn+Akp6VCEAme/rvPiNtgv0XNanifCXTcLVBXso7 0Sq/EMDCJ9UCrQQQ/whSRE/CVUvvrPkSzPz6p0hEPPBiM1dzI2a3nRkW0wFDnIaULuDC ojeOk+U6MAoa/MvOl8wOS/qYijTxQciBzAnLk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jEokhSTD0km1Ad3/quvU0Clwax8ilHswUE3LoQvIehA=; b=bdi2bBIwVVi/Ygi1bsGWilQGVQ0sspQrKoFaLJCJjSMwLiJ0SQm9s9fpI0sUzibmQT YczYaz6FdU/cacM6sBXoD3pax6UhSP6ZJzgbtuYAgMpRYzNzKf6VFQqn7CtN9Hsgtcc9 iW4/9xR3rWd0WeOx1vTVuM5T6ZeTcu9EAWzY9B/8dBfcjoxKgD4gnbkQjtlTNcb9L/FO w80+Y3H+UEJA8a6zhVpW41udX7qATR3AUFxWTtTDi9J/mLesteXfVM4dXIBep+I/nxAB ZGulaVw1yp/Oz2WN6YJiT52wpyaofeovlPFpoRqm78BSQOyRUhIIn6pTtDcgAE6oZ/w0 GpZg== X-Gm-Message-State: AKwxytedkqSJJp2zOpc+x+wA8Vj6hxp3k2tA28ajlxHoroLD6kKRmP7/ XkkiQmWNQo/Rwed7sK4HLZWHID9rp2Q= X-Received: by 10.28.70.196 with SMTP id t187mr2670451wma.129.1516739736319; Tue, 23 Jan 2018 12:35:36 -0800 (PST) Received: from localhost.localdomain ([160.163.176.196]) by smtp.gmail.com with ESMTPSA id y6sm7224565wmy.14.2018.01.23.12.35.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jan 2018 12:35:34 -0800 (PST) From: Ard Biesheuvel To: qemu-devel@nongnu.org Date: Tue, 23 Jan 2018 20:35:27 +0000 Message-Id: <20180123203527.32726-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PATCH] target/arm: implement SM4 instructions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Ard Biesheuvel Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This implements emulation of the new SM4 instructions that have been added as an optional extension to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- I went ahead and did the implementation according to the pseudocode in the ARM ARM, even though i have no test code or reference vectors to compare it against. (There is some example code in the ARM ARM as well, but I haven't played with that) target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 91 ++++++++++++++++++++ target/arm/helper.h | 3 + target/arm/translate-a64.c | 8 ++ 4 files changed, 103 insertions(+) -- 2.11.0 diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 18383666e02d..bad13a76d06c 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1375,6 +1375,7 @@ enum arm_features { ARM_FEATURE_V8_SHA512, /* implements SHA512 part of v8 Crypto Extensions */ ARM_FEATURE_V8_SHA3, /* implements SHA3 part of v8 Crypto Extensions */ ARM_FEATURE_V8_SM3, /* implements SM3 part of v8 Crypto Extensions */ + ARM_FEATURE_V8_SM4, /* implements SM4 part of v8 Crypto Extensions */ }; static inline int arm_feature(CPUARMState *env, int feature) diff --git a/target/arm/crypto_helper.c b/target/arm/crypto_helper.c index c1d9f765cd40..b42c7e046ba3 100644 --- a/target/arm/crypto_helper.c +++ b/target/arm/crypto_helper.c @@ -609,3 +609,94 @@ void HELPER(crypto_sm3tt)(void *vd, void *vn, void *vm, uint32_t imm2, rd[0] = d.l[0]; rd[1] = d.l[1]; } + +static uint8_t const sm4_sbox[] = { + 0xd6, 0x90, 0xe9, 0xfe, 0xcc, 0xe1, 0x3d, 0xb7, + 0x16, 0xb6, 0x14, 0xc2, 0x28, 0xfb, 0x2c, 0x05, + 0x2b, 0x67, 0x9a, 0x76, 0x2a, 0xbe, 0x04, 0xc3, + 0xaa, 0x44, 0x13, 0x26, 0x49, 0x86, 0x06, 0x99, + 0x9c, 0x42, 0x50, 0xf4, 0x91, 0xef, 0x98, 0x7a, + 0x33, 0x54, 0x0b, 0x43, 0xed, 0xcf, 0xac, 0x62, + 0xe4, 0xb3, 0x1c, 0xa9, 0xc9, 0x08, 0xe8, 0x95, + 0x80, 0xdf, 0x94, 0xfa, 0x75, 0x8f, 0x3f, 0xa6, + 0x47, 0x07, 0xa7, 0xfc, 0xf3, 0x73, 0x17, 0xba, + 0x83, 0x59, 0x3c, 0x19, 0xe6, 0x85, 0x4f, 0xa8, + 0x68, 0x6b, 0x81, 0xb2, 0x71, 0x64, 0xda, 0x8b, + 0xf8, 0xeb, 0x0f, 0x4b, 0x70, 0x56, 0x9d, 0x35, + 0x1e, 0x24, 0x0e, 0x5e, 0x63, 0x58, 0xd1, 0xa2, + 0x25, 0x22, 0x7c, 0x3b, 0x01, 0x21, 0x78, 0x87, + 0xd4, 0x00, 0x46, 0x57, 0x9f, 0xd3, 0x27, 0x52, + 0x4c, 0x36, 0x02, 0xe7, 0xa0, 0xc4, 0xc8, 0x9e, + 0xea, 0xbf, 0x8a, 0xd2, 0x40, 0xc7, 0x38, 0xb5, + 0xa3, 0xf7, 0xf2, 0xce, 0xf9, 0x61, 0x15, 0xa1, + 0xe0, 0xae, 0x5d, 0xa4, 0x9b, 0x34, 0x1a, 0x55, + 0xad, 0x93, 0x32, 0x30, 0xf5, 0x8c, 0xb1, 0xe3, + 0x1d, 0xf6, 0xe2, 0x2e, 0x82, 0x66, 0xca, 0x60, + 0xc0, 0x29, 0x23, 0xab, 0x0d, 0x53, 0x4e, 0x6f, + 0xd5, 0xdb, 0x37, 0x45, 0xde, 0xfd, 0x8e, 0x2f, + 0x03, 0xff, 0x6a, 0x72, 0x6d, 0x6c, 0x5b, 0x51, + 0x8d, 0x1b, 0xaf, 0x92, 0xbb, 0xdd, 0xbc, 0x7f, + 0x11, 0xd9, 0x5c, 0x41, 0x1f, 0x10, 0x5a, 0xd8, + 0x0a, 0xc1, 0x31, 0x88, 0xa5, 0xcd, 0x7b, 0xbd, + 0x2d, 0x74, 0xd0, 0x12, 0xb8, 0xe5, 0xb4, 0xb0, + 0x89, 0x69, 0x97, 0x4a, 0x0c, 0x96, 0x77, 0x7e, + 0x65, 0xb9, 0xf1, 0x09, 0xc5, 0x6e, 0xc6, 0x84, + 0x18, 0xf0, 0x7d, 0xec, 0x3a, 0xdc, 0x4d, 0x20, + 0x79, 0xee, 0x5f, 0x3e, 0xd7, 0xcb, 0x39, 0x48, +}; + +void HELPER(crypto_sm4e)(void *vd, void *vn) +{ + uint64_t *rd = vd; + uint64_t *rn = vn; + union CRYPTO_STATE d = { .l = { rd[0], rd[1] } }; + union CRYPTO_STATE n = { .l = { rn[0], rn[1] } }; + uint32_t t, i; + + for (i = 0; i < 3; i++) { + t = CR_ST_WORD(d, (i + 1) % 4) ^ + CR_ST_WORD(d, (i + 2) % 4) ^ + CR_ST_WORD(d, (i + 3) % 4) ^ + CR_ST_WORD(n, i); + + t = sm4_sbox[t & 0xff] | + sm4_sbox[(t >> 8) & 0xff] << 8 | + sm4_sbox[(t >> 16) & 0xff] << 16 | + sm4_sbox[(t >> 24) & 0xff] << 24; + + CR_ST_WORD(d, i) ^= t ^ rol32(t, 2) ^ rol32(t, 10) ^ rol32(t, 18) ^ + rol32(t, 24); + } + + rd[0] = d.l[0]; + rd[1] = d.l[1]; +} + +void HELPER(crypto_sm4ekey)(void *vd, void *vn, void* vm) +{ + uint64_t *rd = vd; + uint64_t *rn = vn; + uint64_t *rm = vm; + union CRYPTO_STATE d; + union CRYPTO_STATE n = { .l = { rn[0], rn[1] } }; + union CRYPTO_STATE m = { .l = { rm[0], rm[1] } }; + uint32_t t, i; + + d = n; + for (i = 0; i < 3; i++) { + t = CR_ST_WORD(d, (i + 1) % 4) ^ + CR_ST_WORD(d, (i + 2) % 4) ^ + CR_ST_WORD(d, (i + 3) % 4) ^ + CR_ST_WORD(m, i); + + t = sm4_sbox[t & 0xff] | + sm4_sbox[(t >> 8) & 0xff] << 8 | + sm4_sbox[(t >> 16) & 0xff] << 16 | + sm4_sbox[(t >> 24) & 0xff] << 24; + + CR_ST_WORD(d, i) ^= t ^ rol32(t, 13) ^ rol32(t, 23); + } + + rd[0] = d.l[0]; + rd[1] = d.l[1]; +} diff --git a/target/arm/helper.h b/target/arm/helper.h index 2d0bba10c006..ee5b0e98f624 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -544,6 +544,9 @@ DEF_HELPER_FLAGS_5(crypto_sm3tt, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32, i32) DEF_HELPER_FLAGS_3(crypto_sm3partw1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) DEF_HELPER_FLAGS_3(crypto_sm3partw2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) +DEF_HELPER_FLAGS_2(crypto_sm4e, TCG_CALL_NO_RWG, void, ptr, ptr) +DEF_HELPER_FLAGS_3(crypto_sm4ekey, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) + DEF_HELPER_FLAGS_3(crc32, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) DEF_HELPER_FLAGS_3(crc32c, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) DEF_HELPER_2(dc_zva, void, env, i64) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 57cf1ded4db7..180882ad178e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11177,6 +11177,10 @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) feature = ARM_FEATURE_V8_SM3; genfn = gen_helper_crypto_sm3partw2; break; + case 2: /* SM4EKEY */ + feature = ARM_FEATURE_V8_SM4; + genfn = gen_helper_crypto_sm4ekey; + break; default: unallocated_encoding(s); return; @@ -11250,6 +11254,10 @@ static void disas_crypto_two_reg_sha512(DisasContext *s, uint32_t insn) feature = ARM_FEATURE_V8_SHA512; genfn = gen_helper_crypto_sha512su0; break; + case 1: /* SM4E */ + feature = ARM_FEATURE_V8_SM4; + genfn = gen_helper_crypto_sm4e; + break; default: unallocated_encoding(s); return;