From patchwork Mon Jan 22 03:42:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 125327 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp952368ljf; Sun, 21 Jan 2018 20:14:50 -0800 (PST) X-Google-Smtp-Source: AH8x226zdB0i+CwpXNf+2g9YT948sPUuGW+x5chZtS/pSmhcqRinNLAOQcUki2a/W2srn73QtbLi X-Received: by 10.129.239.14 with SMTP id o14mr6292007ywm.193.1516594489976; Sun, 21 Jan 2018 20:14:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516594489; cv=none; d=google.com; s=arc-20160816; b=JoeYYoKai2Fnzeu00PlfMPmkIhebVgUXHBr35XQYFJx1OuKZs4zl0CNNriXi23a3bz 7JIrrlhGBITAnY2QtmsGm2xy9sRtS5TI2wdbNREreDT6jc7+p8Nll7x4W4Ptwi1hP8qR p+QOWE1CFSa1l6GN53I/IegAqNy90sWw1JtYYVwqOsxf2B4lrgpa4hIbrWRSKZM5Opef roiCR/E6gyq9wGGl6TaL21NSRTHcq3PUZAv4A5N9RDu+vmw1vKIOk1ZvQ7wviShSOWPf 9CRuzFeFkr7K5KIiaVanVxGYbI7qmPYLJy5P3BTGuGQI4MHzwIKwVt+Se2/P8qKEDmTa xWUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=DiACuF9fSwjx/ljspLFoCBRlabayy+kU1qcoqcfzFP4=; b=dxAXJf9VCVhnRsSV27iiTuRWvBR7Gr87MYixJylllcuFDqbQ047GgXanvsZ3BP5la0 hUonEsYY/KoTI3Sv2+5lfSH1dj65X6dJsKQuzziLIliaLtL/0pRNSg5nfgmINj3jJQLe yn3FPf5UMqI8Qq+1vhw/0sRMgY1x2Gzkj1KbxHJXDb19dG0g7bOIPHqoDZDw27fPC/EW YP4s72SpL3NdpSP1howHc0+9vnsd/2hw8jvO0c9iM9r/5oN6Sl78pz2z5pXB4q3DLLRB Rv7wnXHqBTs3S5OBkaUh9qN8nKLpd3ZwhqchB137SK9O5eKw/+l/XfWGYkwgkscbmhFn l49Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QNEKRa0N; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id g29si1827856ybj.301.2018.01.21.20.14.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 21 Jan 2018 20:14:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QNEKRa0N; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edTVR-0004P3-Aa for patch@linaro.org; Sun, 21 Jan 2018 23:14:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edT0p-0005w2-M8 for qemu-devel@nongnu.org; Sun, 21 Jan 2018 22:43:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edT0k-0006hU-Nl for qemu-devel@nongnu.org; Sun, 21 Jan 2018 22:43:11 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:37887) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edT0k-0006hD-HP for qemu-devel@nongnu.org; Sun, 21 Jan 2018 22:43:06 -0500 Received: by mail-pf0-x244.google.com with SMTP id p1so6085188pfh.4 for ; Sun, 21 Jan 2018 19:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DiACuF9fSwjx/ljspLFoCBRlabayy+kU1qcoqcfzFP4=; b=QNEKRa0NJ5wSVrzHvCMcjTXS6Fgq4Z0rKQtyw3ayIc/b7AvM3jF8nAzBzszk5iLslJ DzltWFqGAbcmK8ySLPYYQyPNzJS+W0C/44JwwEr5pPHeHE1sbLto2PtIoWFI8ACDDx80 Ux/ST1epuGfUhnADj78VTpKfG8hOEq28K8zw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DiACuF9fSwjx/ljspLFoCBRlabayy+kU1qcoqcfzFP4=; b=TeQZ4WsFoEhxscmvrJl1+aOig+O+EfZ0LEVNCHSi2shhXbzfNejGC1pfGveaYHhKVZ L2x/P0KE4eoaiDuQCaMxUTgJ9FmguwCrz3bM4u42CaJnYunPq9zagn5ofpk+hBvnz+Ag 7XfemXE8uuAT4SFFmfwJdH3aJLg5uRCZIvKnhu8xWzXgfqEwhyXk/NSO3jpLwsonhiqx Bm3VXcAlj7QHjlmZeRDPEHW6/cgejgPBEapsofqrJXb1H0rm2dbCbrc/rOD2fkImmpG1 tE8ZlR4my6iXEmQEdukkGODnkIN37o7kc1NIDOc13X5JUSL5mbnJ8W+jgqocEr0spGv+ TXQw== X-Gm-Message-State: AKwxytcT2fXXm92EGtssTOLnvZxnjQT+lfl1A0YcyS/mn7jD1vjgT3nQ SgThjSnywWGzLeuYYrYJ8jZX67ch3+Q= X-Received: by 10.101.88.138 with SMTP id d10mr6288258pgu.52.1516592585288; Sun, 21 Jan 2018 19:43:05 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id z125sm182023pfz.27.2018.01.21.19.43.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Jan 2018 19:43:04 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 21 Jan 2018 19:42:06 -0800 Message-Id: <20180122034217.19593-33-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180122034217.19593-1-richard.henderson@linaro.org> References: <20180122034217.19593-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PULL 32/43] target/hppa: Only use EXCP_DTLB_MISS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Unknown why this works, but if we return EXCP_ITLB_MISS we will triple-fault the first userland instruction fetch. Is it something to do with having a combined I/DTLB? Signed-off-by: Richard Henderson --- target/hppa/mem_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.14.3 diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index e2f94faab5..a0a385cb54 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -97,7 +97,9 @@ int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx, if (ent == NULL || !ent->entry_valid) { phys = 0; prot = 0; - ret = (ifetch ? EXCP_ITLB_MISS : EXCP_DTLB_MISS); + /* ??? Unconditionally report data tlb miss, + even if this is an instruction fetch. */ + ret = EXCP_DTLB_MISS; goto egress; }