From patchwork Mon Dec 11 12:56:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 121400 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2761792qgn; Mon, 11 Dec 2017 05:03:13 -0800 (PST) X-Google-Smtp-Source: ACJfBovt2Kb8aBjelPROOV9fpMa5S7zTmPvRJq8av02Xt9vU0PA9eYgljrTRRWQCyyGtTXc4uHwn X-Received: by 10.37.102.75 with SMTP id z11mr189803ybm.500.1512997393773; Mon, 11 Dec 2017 05:03:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512997393; cv=none; d=google.com; s=arc-20160816; b=FZQ+nZs6AifnwsN5p6GXPHbR4Gp+jyQXqlq0D+cbLI+LpGNFPlzhOxrxahTSmjvh5I qP9W192RXDF7Dj3fNdNa2sepqbUqeKJuoX7aUCH4KhQ8jhoueF3VaTXS6B0qmcNUyk3C ZzC9Sru7ud/iJV1iPzDkHSt5ycF/6Jsl6LLbPFIVUFTpAHibb3MY099cd22dqFRCsM2t j/md7EAbJKr8PFl2ibdf/4p03U5JjyEGlAXLd2a+k/ImtKzzp9fDm6P0y35oMhNHtyFx +TpiXH7DadalcXHyzAR1zz2EjIU7erluvBImwCNkb4cwZKGZqviS0Bk2o4cJycwepqw9 xguQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=FzwTmZYzQddLlG5oQWYZVSPcWE3+WT8pXshd4eSan+k=; b=THTgcAmINU8zikgmzjbU1O9JhqPzc4cVT/8+KHQpCfA5r/Nb1Mwb45154rfYs/BXu9 6mIWFFHQan5WZdLHBaIlTS2T+ak0juvSoEbyeKzGyxJriPxDIbhODFKV2M9czeQC91OW eKTBRs1umJkluvKl9Jj2Na1xo42MIMqiI+N+gm7D/bnFYGxxHsaARb6gEpti6QOxfCvI HLARiTjUx1EPL9APivZOzErzDEoZjWLC+ub2vSp0p6L1KIiU3kAhzIjvZCGqYcxjrEPi eSptHrdcMzN+4A0N6wWDZ4yRQwrWuxWJJbLQ1Zu3//fX9YmLxRI+H3dqtQ4kxSDXQVgd Du2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KS3Qj0Jn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id h81si2984753ybc.735.2017.12.11.05.03.13 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Dec 2017 05:03:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KS3Qj0Jn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52610 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eONjl-0006OQ-9H for patch@linaro.org; Mon, 11 Dec 2017 08:03:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eONe4-0002QK-Bb for qemu-devel@nongnu.org; Mon, 11 Dec 2017 07:57:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eONe1-0007hy-Uz for qemu-devel@nongnu.org; Mon, 11 Dec 2017 07:57:20 -0500 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:35787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eONe1-0007gp-PO for qemu-devel@nongnu.org; Mon, 11 Dec 2017 07:57:17 -0500 Received: by mail-wr0-x244.google.com with SMTP id g53so17479029wra.2 for ; Mon, 11 Dec 2017 04:57:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FzwTmZYzQddLlG5oQWYZVSPcWE3+WT8pXshd4eSan+k=; b=KS3Qj0JnsDt0s3wqunMV3ZVgte8dRN+cD4nBkqN8qQCfevueyXZctFUxKrwzqnU6qN xpbPjXtiJb2y0q2pw7PYSTDJQIBk9FaHlD6ztz6LYdyRCYVehobaPBbueZU6ZIfATCCo aPXU8+x40+BhCE0V9SyE1VwyvQbb90wgCn/3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FzwTmZYzQddLlG5oQWYZVSPcWE3+WT8pXshd4eSan+k=; b=ey4Y5AsUCTTu/GFPbcNPy1NDdqduNLrCibiCey/1CSTBZhKgG7+m/V0SflrY6cRTTy fTmvLsTQPco8BAj133rCHDzbqv19k7tfrDcrMrPpWcSbE2c1DvRo0r4u9mmFwZBm5dsu y0U3BTbJIZl9DxVLtQCNd6oXf9sCYhI49csjGXtVUAtzRtFLDv8f00YaVUZdVA+MkFFv oeXhXVXIFVVPE22X8l0MaVcDFIo2Wm1rlxezcn9kRtatFqOn+Vj4bhJMfIPcmZ1JuQ4m 8KcVeuDvhMRZuZ38v9vTqbyk+r8HyvWRtaLRUFnlmhHQOndIyitkcTcPbBWSVwN6pLSh wpxw== X-Gm-Message-State: AKGB3mJ8waswnOxOzdh9MxUQ0nkgDZpu9CGFdzoZDtDn9DgOv7wEFadH 8OHqakPFedePwDp08+MAUo8lfA== X-Received: by 10.223.181.132 with SMTP id c4mr319251wre.42.1512997036638; Mon, 11 Dec 2017 04:57:16 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id s30sm17434558wrc.89.2017.12.11.04.57.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 04:57:11 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id DF2C43E099D; Mon, 11 Dec 2017 12:57:05 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: richard.henderson@linaro.org, peter.maydell@linaro.org, laurent@vivier.eu, bharata@linux.vnet.ibm.com, andrew@andrewdutcher.com, aleksandar.markovic@imgtec.com Date: Mon, 11 Dec 2017 12:56:53 +0000 Message-Id: <20171211125705.16120-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171211125705.16120-1-alex.bennee@linaro.org> References: <20171211125705.16120-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PATCH v1 07/19] fpu/softfloat: improve comments on ARM NaN propagation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Mention the pseudo-code fragment from which this is based and correct the spelling of signalling. Signed-off-by: Alex Bennée --- fpu/softfloat-specialize.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.15.1 Reviewed-by: Richard Henderson diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index de2c5d5702..3d507d8c77 100644 --- a/fpu/softfloat-specialize.h +++ b/fpu/softfloat-specialize.h @@ -445,14 +445,15 @@ static float32 commonNaNToFloat32(commonNaNT a, float_status *status) #if defined(TARGET_ARM) static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag bIsQNaN, flag bIsSNaN, - flag aIsLargerSignificand) + flag aIsLargerSignificand) { - /* ARM mandated NaN propagation rules: take the first of: - * 1. A if it is signaling - * 2. B if it is signaling + /* ARM mandated NaN propagation rules (see FPProcessNaNs()), take + * the first of: + * 1. A if it is signalling + * 2. B if it is signalling * 3. A (quiet) * 4. B (quiet) - * A signaling NaN is always quietened before returning it. + * A signalling NaN is always quietened before returning it. */ if (aIsSNaN) { return 0;